Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Commit 264619a

Browse files
authored
Merge pull request #64 from Random-Liu/cleanup-code
Cleanup code.
2 parents a4e067c + 95e0fc6 commit 264619a

File tree

3 files changed

+0
-14
lines changed

3 files changed

+0
-14
lines changed

pkg/server/image_pull.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ func (r *resourceSet) all() map[string]struct{} {
186186

187187
// pullImage pulls image and returns image id (config digest) and manifest digest.
188188
// The ref should be normalized image reference.
189-
// TODO(random-liu): [P0] Wait for all downloadings to be done before return.
190189
func (c *criContainerdService) pullImage(ctx context.Context, ref string) (
191190
imagedigest.Digest, imagedigest.Digest, error) {
192191
// Resolve the image reference to get descriptor and fetcher.

pkg/server/sandbox_run.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ func (c *criContainerdService) RunPodSandbox(ctx context.Context, r *runtime.Run
152152
TypeUrl: runtimespec.Version,
153153
Value: rawSpec,
154154
},
155-
// TODO(random-liu): [P0] Get rootfs mount from containerd.
156155
Rootfs: rootfsMounts,
157156
Runtime: defaultRuntime,
158157
// No stdin for sandbox container.

pkg/server/service.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,6 @@ import (
4040
"github.com/kubernetes-incubator/cri-containerd/pkg/registrar"
4141
)
4242

43-
// TODO remove the underscores from the following imports as the services are
44-
// implemented. "_" is being used to hold the reference to keep autocomplete
45-
// from deleting them until referenced below.
46-
// nolint: golint
47-
import (
48-
_ "github.com/containerd/containerd/api/types/container"
49-
_ "github.com/containerd/containerd/api/types/descriptor"
50-
_ "github.com/containerd/containerd/api/types/mount"
51-
_ "github.com/opencontainers/image-spec/specs-go"
52-
_ "github.com/opencontainers/runtime-spec/specs-go"
53-
)
54-
5543
// CRIContainerdService is the interface implement CRI remote service server.
5644
type CRIContainerdService interface {
5745
Start()

0 commit comments

Comments
 (0)