Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Commit 23b8330

Browse files
authored
Merge pull request #322 from miaoyq/fix-314
Update kubernetes version to the PR#52395 and support `unconfined` apparmor
2 parents cfa7acf + 9f656cd commit 23b8330

File tree

8 files changed

+28
-6
lines changed

8 files changed

+28
-6
lines changed

pkg/server/container_create.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,7 @@ func generateApparmorSpecOpts(apparmorProf string, privileged, apparmorEnabled b
786786
if !apparmorEnabled {
787787
// Should fail loudly if user try to specify apparmor profile
788788
// but we don't support it.
789-
if apparmorProf != "" {
789+
if apparmorProf != "" && apparmorProf != unconfinedProfile {
790790
return nil, fmt.Errorf("apparmor is not supported")
791791
}
792792
return nil, nil
@@ -795,7 +795,8 @@ func generateApparmorSpecOpts(apparmorProf string, privileged, apparmorEnabled b
795795
case runtimeDefault:
796796
// TODO (mikebrow): delete created apparmor default profile
797797
return apparmor.WithDefaultProfile(appArmorDefaultProfileName), nil
798-
// TODO(random-liu): Should support "unconfined" after kubernetes#52395 lands.
798+
case unconfinedProfile:
799+
return nil, nil
799800
case "":
800801
// Based on kubernetes#51746, default apparmor profile should be applied
801802
// for non-privileged container when apparmor is not specified.

pkg/server/container_create_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -809,6 +809,17 @@ func TestGenerateApparmorSpecOpts(t *testing.T) {
809809
profile: "",
810810
privileged: true,
811811
},
812+
"should not return error if apparmor is unconfined when apparmor is not supported": {
813+
profile: unconfinedProfile,
814+
disable: true,
815+
},
816+
"should not apparmor when apparmor is unconfined": {
817+
profile: unconfinedProfile,
818+
},
819+
"should not apparmor when apparmor is unconfined and privileged is true": {
820+
profile: unconfinedProfile,
821+
privileged: true,
822+
},
812823
"should set default apparmor when apparmor is runtime/default": {
813824
profile: runtimeDefault,
814825
specOpts: apparmor.WithDefaultProfile(appArmorDefaultProfileName),

vendor.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,5 @@ k8s.io/apimachinery 4fd33e5925599d66528ef4f1a5c80f4aa2e27c98
6464
k8s.io/apiserver c1e53d745d0fe45bf7d5d44697e6eface25fceca
6565
k8s.io/client-go 82aa063804cf055e16e8911250f888bc216e8b61
6666
k8s.io/kube-openapi abfc5fbe1cf87ee697db107fdfd24c32fe4397a8
67-
k8s.io/kubernetes v1.8.0
67+
k8s.io/kubernetes 5e96f7cae900f71389f3fa291aa307169a44a65a
6868
k8s.io/utils 4fe312863be2155a7b68acd2aff1c9221b24e68c

vendor/k8s.io/kubernetes/README.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/kubernetes/pkg/api/types.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/kubernetes/pkg/api/zz_generated.deepcopy.go

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime/api.pb.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime/api.proto

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)