Skip to content

Commit aa80a63

Browse files
authored
Merge pull request #310 from saad-ali/readonlyOptional
Add capability for `ControllerPublishVolume.readonly` field
2 parents 5d436c6 + d7df952 commit aa80a63

File tree

3 files changed

+295
-277
lines changed

3 files changed

+295
-277
lines changed

csi.proto

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -584,8 +584,10 @@ message ControllerPublishVolumeRequest {
584584
// This is a REQUIRED field.
585585
VolumeCapability volume_capability = 3;
586586

587-
// Whether to publish the volume in readonly mode. This field is
588-
// REQUIRED.
587+
// Whether to publish the volume in readonly mode.
588+
// CO MUST set this field to false if SP does not have the
589+
// PUBLISH_READONLY controller capability.
590+
// This is a REQUIRED field.
589591
bool readonly = 4;
590592

591593
// Secrets required by plugin to complete controller publish volume
@@ -776,6 +778,9 @@ message ControllerServiceCapability {
776778
// the same plugin. Not all volume sources and parameters
777779
// combinations may work.
778780
CLONE_VOLUME = 7;
781+
// Indicates the SP supports ControllerPublishVolume.readonly
782+
// field.
783+
PUBLISH_READONLY = 8;
779784
}
780785

781786
Type type = 1;

0 commit comments

Comments
 (0)