Latin1fix (#89)

* latin1 fix

* strict

* return

* codecleanup

* cache

* version

Author: laliconfigcat

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "configcat-js",
-  "version": "9.0.0",
+  "version": "9.1.0",
   "description": "ConfigCat is a configuration as a service that lets you manage your features and configurations without actually deploying new code.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

package.json

@@ -3,7 +3,7 @@ import type { IConfigCatCache } from "configcat-common";
 export class LocalStorageCache implements IConfigCatCache {
   set(key: string, value: string): void {
     try {
-      localStorage.setItem(key, btoa(value));
+      localStorage.setItem(key, this.b64EncodeUnicode(value));
     }
     catch (ex) {
       // local storage is unavailable
@@ -14,11 +14,24 @@ export class LocalStorageCache implements IConfigCatCache {
     try {
       const configString = localStorage.getItem(key);
       if (configString) {
-        return atob(configString);
+        return this.b64DecodeUnicode(configString);
       }
     }
     catch (ex) {
       // local storage is unavailable or invalid cache value in localstorage
     }
+    return void 0;
+  }
+
+  private b64EncodeUnicode(str: string): string {
+    return btoa(encodeURIComponent(str).replace(/%([0-9A-F]{2})/g, function (_, p1) {
+      return String.fromCharCode(parseInt(p1, 16))
+    }));
+  }
+
+  private b64DecodeUnicode(str: string): string {
+    return decodeURIComponent(Array.prototype.map.call(atob(str), function (c: string) {
+      return '%' + ('00' + c.charCodeAt(0).toString(16)).slice(-2)
+    }).join(''));
   }
 }

src/Cache.ts

@@ -0,0 +1,14 @@
+import { assert } from "chai";
+import { LocalStorageCache } from "../lib/Cache";
+
+
+describe("LocalStorageCache cache tests", () => {
+    it("LocalStorageCache works with non latin 1 characters", () => {
+        const cache = new LocalStorageCache();
+        const key = "testkey";
+        const text = "äöüÄÖÜçéèñışğ⢙✓😀";
+        cache.set(key, text);
+        const retrievedValue = cache.get(key);
+        assert.strictEqual(retrievedValue, text);
+    });
+});

test/CacheTests.ts

@@ -5,7 +5,7 @@ import { FakeLogger } from "./helpers/fakes";
 import * as utils from "./helpers/utils";
 
 describe("HTTP tests", () => {
-  const sdkKey = "PKDVCLf-Hq-h-kCzMp-L7Q/psuH7BGHoUmdONrzzUOY7A";
+  const sdkKey = "configcat-sdk-1/PKDVCLf-Hq-h-kCzMp-L7Q/AG6C1ngVb0CvM07un6JisQ";
   const baseUrl = "https://cdn-global.test.com";
 
   it("HTTP timeout", async () => {

test/HttpTests.ts

@@ -3,7 +3,7 @@ import { IConfigCatClient, IEvaluationDetails, IOptions, LogLevel, PollingMode,
 import * as configcatClient from "../src";
 import { createConsoleLogger } from "../src";
 
-const sdkKey = "PKDVCLf-Hq-h-kCzMp-L7Q/psuH7BGHoUmdONrzzUOY7A";
+const sdkKey = "configcat-sdk-1/PKDVCLf-Hq-h-kCzMp-L7Q/AG6C1ngVb0CvM07un6JisQ";
 
 describe("Integration tests - Normal use", () => {
 

test/IntegrationTests.ts

@@ -0,0 +1,31 @@
+import { assert } from "chai";
+import { IConfigCatClient, IEvaluationDetails, IOptions, LogLevel, PollingMode, SettingKeyValue, User } from "configcat-common";
+import * as configcatClient from "../src";
+import { createConsoleLogger } from "../src";
+
+const sdkKey = "configcat-sdk-1/PKDVCLf-Hq-h-kCzMp-L7Q/u28_1qNyZ0Wz-ldYHIU7-g";
+
+describe("Special characters test", () => {
+
+    const options: IOptions = { logger: createConsoleLogger(LogLevel.Off) };
+
+    let client: IConfigCatClient;
+
+    beforeEach(function () {
+        client = configcatClient.getClient(sdkKey, PollingMode.AutoPoll, options);
+    });
+
+    afterEach(function () {
+        client.dispose();
+    });
+
+    it(`Special characters works - cleartext`, async () => {
+        const actual: string = await client.getValueAsync("specialCharacters", "NOT_CAT", new User("äöüÄÖÜçéèñışğ⢙✓😀"));
+        assert.strictEqual(actual, "äöüÄÖÜçéèñışğ⢙✓😀");
+    });
+
+    it(`Special characters works - hashed`, async () => {
+        const actual: string = await client.getValueAsync("specialCharactersHashed", "NOT_CAT", new User("äöüÄÖÜçéèñışğ⢙✓😀"));
+        assert.strictEqual(actual, "äöüÄÖÜçéèñışğ⢙✓😀");
+    });
+});