Skip to content

Commit f93fe3b

Browse files
committed
timeoutMs
1 parent d5e2681 commit f93fe3b

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

include/configcat/configcatoptions.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ struct ProxyAuthentication {
1818
struct ConfigCatOptions {
1919
std::string baseUrl = "";
2020
DataGovernance dataGovernance = Global;
21-
uint32_t connectTimeout = 8000; // milliseconds (0 means it never times out during transfer)
22-
uint32_t readTimeout = 5000; // milliseconds (0 means it never times out during transfer)
21+
uint32_t connectTimeoutMs = 8000; // milliseconds (0 means it never times out during transfer)
22+
uint32_t readTimeoutMs = 5000; // milliseconds (0 means it never times out during transfer)
2323
std::shared_ptr<PollingMode> mode = PollingMode::autoPoll();
2424
std::shared_ptr<ConfigCatCache> cache;
2525
std::shared_ptr<FlagOverrides> override;

src/configfetcher.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ class SessionInterceptor : public cpr::Interceptor {
4848
ConfigFetcher::ConfigFetcher(const string& sdkKey, const string& mode, const ConfigCatOptions& options):
4949
sdkKey(sdkKey),
5050
mode(mode),
51-
connectTimeout(options.connectTimeout),
52-
readTimeout(options.readTimeout) {
51+
connectTimeoutMs(options.connectTimeoutMs),
52+
readTimeoutMs(options.readTimeoutMs) {
5353
if (options.httpSessionAdapter) {
5454
sessionInterceptor = make_shared<SessionInterceptor>(options.httpSessionAdapter);
5555
}
5656
session = make_unique<cpr::Session>();
57-
session->SetConnectTimeout(connectTimeout);
58-
session->SetTimeout(readTimeout);
57+
session->SetConnectTimeout(connectTimeoutMs);
58+
session->SetTimeout(readTimeoutMs);
5959
session->SetProxies(options.proxies);
6060
std::map<std::string, cpr::EncodedAuthentication> proxyAuthentications;
6161
for (auto& keyValue : options.proxyAuthentications) {
@@ -159,7 +159,7 @@ FetchResponse ConfigFetcher::fetch(const std::string& eTag) {
159159
LogEntry logEntry(LOG_LEVEL_ERROR);
160160
logEntry << "An error occurred during the config fetch: " << response.error.message << ".";
161161
if (response.error.code == cpr::ErrorCode::OPERATION_TIMEDOUT) {
162-
logEntry << " Timeout values: [connect: " << connectTimeout << "ms, read: " << readTimeout << "ms]";
162+
logEntry << " Timeout values: [connect: " << connectTimeoutMs << "ms, read: " << readTimeoutMs << "ms]";
163163
}
164164
return FetchResponse({failure, ConfigEntry::empty});
165165
}

src/configfetcher.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ class ConfigFetcher {
5959

6060
std::string sdkKey;
6161
std::string mode;
62-
uint32_t connectTimeout; // milliseconds (0 means it never times out during transfer)
63-
uint32_t readTimeout; // milliseconds (0 means it never times out during transfer)
62+
uint32_t connectTimeoutMs; // milliseconds (0 means it never times out during transfer)
63+
uint32_t readTimeoutMs; // milliseconds (0 means it never times out during transfer)
6464
std::shared_ptr<SessionInterceptor> sessionInterceptor;
6565
std::unique_ptr<cpr::Session> session;
6666
bool urlIsCustom = false;

src/version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#pragma once
22

3-
#define CONFIGCAT_VERSION "0.1.0"
3+
#define CONFIGCAT_VERSION "1.0.0"

test/test-configcatclientintegration.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ using namespace std;
99
TEST(ConfigCatClientIntegrationTest, RequestTimeout) {
1010
ConfigCatOptions options;
1111
options.mode = PollingMode::autoPoll(120);
12-
options.connectTimeout = 1; // milliseconds
13-
options.readTimeout = 1; // milliseconds
12+
options.connectTimeoutMs = 1; // milliseconds
13+
options.readTimeoutMs = 1; // milliseconds
1414
auto client = ConfigCatClient::get("PKDVCLf-Hq-h-kCzMp-L7Q/psuH7BGHoUmdONrzzUOY7A", options);
1515
auto startTime = chrono::steady_clock::now();
1616

0 commit comments

Comments
 (0)