Skip to content

Commit 272aefa

Browse files
authored
Merge pull request #231 from common-workflow-language/restore-workflow-outparam-type
finish restoring allowable types for parameters
2 parents 06c9ba7 + 3940210 commit 272aefa

File tree

3 files changed

+83
-45
lines changed

3 files changed

+83
-45
lines changed

draft-4/CommandLineTool.yml

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -368,18 +368,11 @@ $graph:
368368
- specializeFrom: "#InputBinding"
369369
specializeTo: "#CommandLineBinding"
370370

371-
372371
- type: record
373372
name: CommandOutputParameter
374373
extends: "#OutputParameter"
375374
doc: An output parameter for a CommandLineTool.
376375
specialize:
377-
- specializeFrom: "#OutputRecordSchema"
378-
specializeTo: "#CommandOutputRecordSchema"
379-
- specializeFrom: "#OutputEnumSchema"
380-
specializeTo: "#CommandOutputEnumSchema"
381-
- specializeFrom: "#OutputArraySchema"
382-
specializeTo: "#CommandOutputArraySchema"
383376
- specializeFrom: "#OutputBinding"
384377
specializeTo: "#CommandOutputBinding"
385378
fields:
@@ -389,16 +382,16 @@ $graph:
389382
- "#CWLType"
390383
- "#stdout"
391384
- "#stderr"
392-
- "sld:RecordSchema"
393-
- "sld:EnumSchema"
394-
- "sld:ArraySchema"
385+
- "#CommandOutputRecordSchema"
386+
- "#CommandOutputEnumSchema"
387+
- "#CommandOutputArraySchema"
395388
- string
396389
- type: array
397390
items:
398391
- "#CWLType"
399-
- "sld:RecordSchema"
400-
- "sld:EnumSchema"
401-
- "sld:ArraySchema"
392+
- "#CommandOutputRecordSchema"
393+
- "#CommandOutputEnumSchema"
394+
- "#CommandOutputArraySchema"
402395
- string
403396
jsonldPredicate:
404397
"_id": "sld:type"
@@ -413,7 +406,8 @@ $graph:
413406
symbols: [ "cwl:stdout" ]
414407
docParent: "#CommandOutputParameter"
415408
doc: |
416-
Only valid as a `type` for an output.
409+
Only valid as a `type` for a `CommandLineTool` output with no
410+
`outputBinding` set.
417411
418412
The following
419413
```
@@ -442,7 +436,8 @@ $graph:
442436
symbols: [ "cwl:stderr" ]
443437
docParent: "#CommandOutputParameter"
444438
doc: |
445-
Only valid as a `type` for an output.
439+
Only valid as a `type` for a `CommandLineTool` output with no
440+
`outputBinding` set.
446441
447442
The following
448443
```

draft-4/Process.yml

Lines changed: 22 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -370,37 +370,7 @@ $graph:
370370
- name: InputParameter
371371
type: record
372372
extends: "#Parameter"
373-
specialize:
374-
- specializeFrom: "sld:RecordSchema"
375-
specializeTo: "#InputRecordSchema"
376-
- specializeFrom: "sld:EnumSchema"
377-
specializeTo: "#InputEnumSchema"
378-
- specializeFrom: "sld:ArraySchema"
379-
specializeTo: "#InputArraySchema"
380373
fields:
381-
- name: type
382-
type:
383-
- "null"
384-
- "#CWLType"
385-
- "sld:RecordSchema"
386-
- "sld:EnumSchema"
387-
- "sld:ArraySchema"
388-
- string
389-
- type: array
390-
items:
391-
- "#CWLType"
392-
- "sld:RecordSchema"
393-
- "sld:EnumSchema"
394-
- "sld:ArraySchema"
395-
- string
396-
jsonldPredicate:
397-
"_id": "sld:type"
398-
"_type": "@vocab"
399-
refScope: 2
400-
typeDSL: True
401-
doc: |
402-
Specify valid types of data that may be assigned to this parameter.
403-
404374
- name: id
405375
type: string
406376
jsonldPredicate: "@id"
@@ -420,6 +390,28 @@ $graph:
420390
The default value for this parameter if not provided in the input
421391
object.
422392
393+
- name: type
394+
type:
395+
- "null"
396+
- "#CWLType"
397+
- "#InputRecordSchema"
398+
- "#InputEnumSchema"
399+
- "#InputArraySchema"
400+
- string
401+
- type: array
402+
items:
403+
- "#CWLType"
404+
- "#InputRecordSchema"
405+
- "#InputEnumSchema"
406+
- "#InputArraySchema"
407+
- string
408+
jsonldPredicate:
409+
"_id": "sld:type"
410+
"_type": "@vocab"
411+
refScope: 2
412+
typeDSL: True
413+
doc: |
414+
Specify valid types of data that may be assigned to this parameter.
423415
424416
- name: OutputParameter
425417
type: record

draft-4/Workflow.yml

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,39 @@ $graph:
5050
5151
- {$include: concepts.md}
5252

53+
- name: ExpressionToolOutputParameter
54+
type: record
55+
extends: Parameter
56+
fields:
57+
- name: type
58+
type:
59+
- "null"
60+
- "#CWLType"
61+
- "sld:RecordSchema"
62+
- "sld:EnumSchema"
63+
- "sld:ArraySchema"
64+
- string
65+
- type: array
66+
items:
67+
- "#CWLType"
68+
- "sld:RecordSchema"
69+
- "sld:EnumSchema"
70+
- "sld:ArraySchema"
71+
- string
72+
jsonldPredicate:
73+
"_id": "sld:type"
74+
"_type": "@vocab"
75+
refScope: 2
76+
typeDSL: True
77+
doc: |
78+
Specify valid types of data that may be assigned to this parameter.
5379
5480
- type: record
5581
name: ExpressionTool
5682
extends: Process
83+
specialize:
84+
- specializeFrom: "#OutputParameter"
85+
specializeTo: "#ExpressionToolOutputParameter"
5786
documentRoot: true
5887
doc: |
5988
Execute an expression as a process step.
@@ -104,6 +133,28 @@ $graph:
104133
doc: |
105134
The method to use to merge multiple sources into a single array.
106135
If not specified, the default method is "merge_nested".
136+
- name: type
137+
type:
138+
- "null"
139+
- "#CWLType"
140+
- "#OutputRecordSchema"
141+
- "#OutputEnumSchema"
142+
- "#OutputArraySchema"
143+
- string
144+
- type: array
145+
items:
146+
- "#CWLType"
147+
- "#OutputRecordSchema"
148+
- "#OutputEnumSchema"
149+
- "#OutputArraySchema"
150+
- string
151+
jsonldPredicate:
152+
"_id": "sld:type"
153+
"_type": "@vocab"
154+
refScope: 2
155+
typeDSL: True
156+
doc: |
157+
Specify valid types of data that may be assigned to this parameter.
107158
108159
109160
- name: Sink

0 commit comments

Comments
 (0)