Skip to content

Commit 32ab419

Browse files
authored
fix(use-files): make files reference more stable (#760)
1 parent 721ad28 commit 32ab419

File tree

11 files changed

+125
-469
lines changed

11 files changed

+125
-469
lines changed

.codesandbox/ci.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"packages": ["sandpack-client", "sandpack-react"],
3-
"sandboxes": ["sowx8r"],
3+
"sandboxes": ["sowx8r", "909l3f"],
44
"node": "16"
55
}

sandpack-client/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,10 @@
4747
],
4848
"dependencies": {
4949
"@codesandbox/nodebox": "0.1.0",
50-
"lodash.isequal": "^4.5.0",
50+
"dequal": "^2.0.2",
5151
"outvariant": "1.3.0"
5252
},
5353
"devDependencies": {
54-
"@types/lodash.isequal": "^4.5.2",
5554
"@types/node": "^9.3.0",
5655
"console-feed": "3.3.0",
5756
"del": "^6.0.0",

sandpack-client/src/clients/base.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import isEqual from "lodash.isequal";
1+
import { dequal as deepEqual } from "dequal";
22

33
import type {
44
ClientOptions,
@@ -35,7 +35,7 @@ export class SandpackClient {
3535
* Clients handles
3636
*/
3737
public updateOptions(options: ClientOptions): void {
38-
if (!isEqual(this.options, options)) {
38+
if (!deepEqual(this.options, options)) {
3939
this.options = options;
4040
this.updateSandbox();
4141
}

sandpack-client/src/clients/runtime/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import isEqual from "lodash.isequal";
1+
import { dequal as deepEqual } from "dequal";
22

33
import type { SandpackMessage } from "../..";
44
import { nullthrows } from "../..";
@@ -163,7 +163,7 @@ export class SandpackRuntime extends SandpackClient {
163163
}
164164

165165
updateOptions(options: ClientOptions): void {
166-
if (!isEqual(this.options, options)) {
166+
if (!deepEqual(this.options, options)) {
167167
this.options = options;
168168
this.updateSandbox();
169169
}

sandpack-react/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
"README.md"
3636
],
3737
"dependencies": {
38+
"use-deep-compare-effect": "1.8.1",
3839
"@code-hike/classer": "^0.0.0-aa6efee",
3940
"@codemirror/autocomplete": "^6.4.0",
4041
"@codemirror/commands": "^6.1.3",
@@ -51,7 +52,7 @@
5152
"ansi-to-react": "6.1.6",
5253
"clean-set": "^1.1.2",
5354
"codesandbox-import-util-types": "^2.2.3",
54-
"lodash.isequal": "^4.5.0",
55+
"dequal": "^2.0.2",
5556
"lz-string": "^1.4.4",
5657
"react-devtools-inline": "4.4.0",
5758
"react-is": "^17.0.2"
@@ -66,7 +67,6 @@
6667
"@testing-library/react-hooks": "8.0.1",
6768
"@types/fs-extra": "^5.0.4",
6869
"@types/glob": "^5.0.35",
69-
"@types/lodash.isequal": "^4.5.2",
7070
"@types/lz-string": "^1.3.34",
7171
"@types/node": "^9.4.6",
7272
"@types/react": "^18.0.15",

0 commit comments

Comments
 (0)