From d709e85215de54fa0d5fcb18515e294426043ff7 Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Fri, 1 Mar 2024 09:13:52 +0700 Subject: [PATCH 1/5] fix: [DebugBar] scroll to top on open/close --- system/Debug/Toolbar/Views/toolbar.tpl.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/Debug/Toolbar/Views/toolbar.tpl.php b/system/Debug/Toolbar/Views/toolbar.tpl.php index e2336326088e..768f9d38c65e 100644 --- a/system/Debug/Toolbar/Views/toolbar.tpl.php +++ b/system/Debug/Toolbar/Views/toolbar.tpl.php @@ -27,7 +27,7 @@
- +
@@ -80,7 +80,7 @@ - + From 91c3c59c94ebac13a7cbc3e080f0329577ac3bcd Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Sat, 2 Mar 2024 07:04:45 +0700 Subject: [PATCH 2/5] change all href to role button --- system/Debug/Toolbar/Views/toolbar.tpl.php | 30 +++++++++++----------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/system/Debug/Toolbar/Views/toolbar.tpl.php b/system/Debug/Toolbar/Views/toolbar.tpl.php index 768f9d38c65e..4bae5b54c7c7 100644 --- a/system/Debug/Toolbar/Views/toolbar.tpl.php +++ b/system/Debug/Toolbar/Views/toolbar.tpl.php @@ -33,15 +33,15 @@
- - 🔅 + + 🔅 - + - + ms   MB @@ -50,7 +50,7 @@ - + @@ -64,7 +64,7 @@ - + Vars @@ -72,7 +72,7 @@

- + @@ -80,7 +80,7 @@

- +
@@ -124,7 +124,7 @@ $items) : ?> - +

@@ -148,7 +148,7 @@ - +

Session User Data

@@ -174,7 +174,7 @@

Request ( )

- +

$_GET

@@ -191,7 +191,7 @@ - +

$_POST

@@ -208,7 +208,7 @@ - +

Headers

@@ -225,7 +225,7 @@ - +

Cookies

@@ -246,7 +246,7 @@ - +

Headers

From e2c488b610616fea0b12d0eceb5d893c314ad393 Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Sat, 2 Mar 2024 07:05:25 +0700 Subject: [PATCH 3/5] style css and run sass --- admin/css/debug-toolbar/toolbar.scss | 39 +++++++++++++++----------- system/Debug/Toolbar/Views/toolbar.css | 14 ++++++--- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/admin/css/debug-toolbar/toolbar.scss b/admin/css/debug-toolbar/toolbar.scss index 9c5b149d392c..8d7bed21b361 100644 --- a/admin/css/debug-toolbar/toolbar.scss +++ b/admin/css/debug-toolbar/toolbar.scss @@ -13,6 +13,9 @@ @import '_mixins'; @import '_settings'; +[role="button"] { + cursor: pointer; +} // DEBUG ICON // ========================================================================== */ @@ -36,6 +39,9 @@ clear: both; text-align: center; + // Cursor + cursor: pointer; + a svg { margin: 8px; max-width: 20px; @@ -227,14 +233,13 @@ // The toolbar preferences #toolbar-position, #toolbar-theme { - a { - padding: 0 6px; - display: inline-flex; - vertical-align: top; + padding: 0 6px; + display: inline-flex; + vertical-align: top; + cursor: pointer; - &:hover { - text-decoration: none; - } + &:hover { + text-decoration: none; } } @@ -518,43 +523,43 @@ .debug-bar-dtableRow { display: table-row; } - + .debug-bar-dinlineBlock { display: inline-block; } - + .debug-bar-pointer { cursor: pointer; } - + .debug-bar-mleft4 { margin-left: 4px; } - + .debug-bar-level-0 { --level: 0; } - + .debug-bar-level-1 { --level: 1; } - + .debug-bar-level-2 { --level: 2; } - + .debug-bar-level-3 { --level: 3; } - + .debug-bar-level-4 { --level: 4; } - + .debug-bar-level-5 { --level: 5; } - + .debug-bar-level-6 { --level: 6; } diff --git a/system/Debug/Toolbar/Views/toolbar.css b/system/Debug/Toolbar/Views/toolbar.css index a3b934b68bd4..175f7725f8c8 100644 --- a/system/Debug/Toolbar/Views/toolbar.css +++ b/system/Debug/Toolbar/Views/toolbar.css @@ -6,6 +6,10 @@ * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ +[role=button] { + cursor: pointer; +} + #debug-icon { bottom: 0; position: fixed; @@ -17,6 +21,7 @@ padding: 0px; clear: both; text-align: center; + cursor: pointer; } #debug-icon a svg { margin: 8px; @@ -156,14 +161,15 @@ bottom: auto; top: 36px; } -#debug-bar #toolbar-position a, -#debug-bar #toolbar-theme a { +#debug-bar #toolbar-position, +#debug-bar #toolbar-theme { padding: 0 6px; display: inline-flex; vertical-align: top; + cursor: pointer; } -#debug-bar #toolbar-position a:hover, -#debug-bar #toolbar-theme a:hover { +#debug-bar #toolbar-position:hover, +#debug-bar #toolbar-theme:hover { text-decoration: none; } #debug-bar #debug-bar-link { From 1ceafd6727924694b2bbd8e2b839061eecb93f2a Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Sat, 2 Mar 2024 07:10:10 +0700 Subject: [PATCH 4/5] just element anchor in role button --- admin/css/debug-toolbar/toolbar.scss | 2 +- system/Debug/Toolbar/Views/toolbar.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/css/debug-toolbar/toolbar.scss b/admin/css/debug-toolbar/toolbar.scss index 8d7bed21b361..dfcb7e58aeea 100644 --- a/admin/css/debug-toolbar/toolbar.scss +++ b/admin/css/debug-toolbar/toolbar.scss @@ -13,7 +13,7 @@ @import '_mixins'; @import '_settings'; -[role="button"] { +a[role="button"] { cursor: pointer; } diff --git a/system/Debug/Toolbar/Views/toolbar.css b/system/Debug/Toolbar/Views/toolbar.css index 175f7725f8c8..612a1ee873e1 100644 --- a/system/Debug/Toolbar/Views/toolbar.css +++ b/system/Debug/Toolbar/Views/toolbar.css @@ -6,7 +6,7 @@ * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ -[role=button] { +a[role=button] { cursor: pointer; } From 0fc548518e0a6f53f70ea0a3359dde927af6caf2 Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Sat, 9 Mar 2024 06:46:03 +0700 Subject: [PATCH 5/5] fix: make css button for vars --- admin/css/debug-toolbar/toolbar.scss | 10 +++++----- system/Debug/Toolbar/Views/toolbar.css | 9 +++++---- system/Debug/Toolbar/Views/toolbar.tpl.php | 14 +++++++------- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git a/admin/css/debug-toolbar/toolbar.scss b/admin/css/debug-toolbar/toolbar.scss index dfcb7e58aeea..e129a4b1c5b6 100644 --- a/admin/css/debug-toolbar/toolbar.scss +++ b/admin/css/debug-toolbar/toolbar.scss @@ -13,10 +13,6 @@ @import '_mixins'; @import '_settings'; -a[role="button"] { - cursor: pointer; -} - // DEBUG ICON // ========================================================================== */ @@ -39,7 +35,6 @@ a[role="button"] { clear: both; text-align: center; - // Cursor cursor: pointer; a svg { @@ -62,6 +57,10 @@ a[role="button"] { // DEBUG BAR // ========================================================================== */ +.debug-bar-vars { + cursor: pointer; +} + #debug-bar { // Position bottom: 0; @@ -247,6 +246,7 @@ a[role="button"] { #debug-bar-link { display: flex; padding: 6px; + cursor: pointer; } // The toolbar menus diff --git a/system/Debug/Toolbar/Views/toolbar.css b/system/Debug/Toolbar/Views/toolbar.css index 612a1ee873e1..4154f4c5c4ca 100644 --- a/system/Debug/Toolbar/Views/toolbar.css +++ b/system/Debug/Toolbar/Views/toolbar.css @@ -6,10 +6,6 @@ * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ -a[role=button] { - cursor: pointer; -} - #debug-icon { bottom: 0; position: fixed; @@ -36,6 +32,10 @@ a[role=button] { display: none; } +.debug-bar-vars { + cursor: pointer; +} + #debug-bar { bottom: 0; left: 0; @@ -175,6 +175,7 @@ a[role=button] { #debug-bar #debug-bar-link { display: flex; padding: 6px; + cursor: pointer; } #debug-bar .ci-label { display: inline-flex; diff --git a/system/Debug/Toolbar/Views/toolbar.tpl.php b/system/Debug/Toolbar/Views/toolbar.tpl.php index 4bae5b54c7c7..03500456757e 100644 --- a/system/Debug/Toolbar/Views/toolbar.tpl.php +++ b/system/Debug/Toolbar/Views/toolbar.tpl.php @@ -124,7 +124,7 @@ $items) : ?> - +

@@ -148,7 +148,7 @@ - +

Session User Data

@@ -174,7 +174,7 @@

Request ( )

- +

$_GET

@@ -191,7 +191,7 @@ - +

$_POST

@@ -208,7 +208,7 @@ - +

Headers

@@ -225,7 +225,7 @@ - +

Cookies

@@ -246,7 +246,7 @@ - +

Headers