Merge pull request #9358 from codeigniter4/develop

4.5.7 Ready code

Author: paulbalandan

.github/ISSUE_TEMPLATE/config.yml

@@ -2,7 +2,7 @@ blank_issues_enabled: false
 contact_links:
   - name: CodeIgniter Forum
     url: https://forum.codeigniter.com/forum-30.html
-    about: Please ask your support questions in the forums. Thanks!
+    about: Please ask your support questions and/or feature requests in the forums. Thanks!
 
   - name: CodeIgniter Slack channel
     url: https://codeigniterchat.slack.com

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,10 +1,10 @@
 ---
 name: Planned work
-about: Approved work planning
+about: Maintainers' space. DO NOT use this for your bug reports!
 title: 'Dev: '
 labels: dev
 assignees: ''
 
 ---
 
-Repo maintainers will create "issues" for planned work, so it can be tracked.
+Maintainers will create "issues" for planned work, so it can be tracked.

.github/ISSUE_TEMPLATE/planned-work.md

@@ -0,0 +1,41 @@
+# https://mergeable.readthedocs.io/en/latest/configuration.html
+
+version: 2
+mergeable:
+  - when: issues.opened
+    validate:
+      - do: description
+        and:
+          - must_include:
+              regex: '^### PHP Version'
+          - must_include:
+              regex: '^### CodeIgniter4 Version'
+      - do: author
+        and:
+          - must_exclude:
+              regex: 'kenjis'
+          - must_exclude:
+              regex: 'lonnieezell'
+          - must_exclude:
+              regex: 'MGatner'
+          - must_exclude:
+              regex: 'michalsn'
+          - must_exclude:
+              regex: 'paulbalandan'
+          - must_exclude:
+              regex: 'samsonasik'
+    fail:
+      - do: comment
+        payload: |
+          Hi there! :wave:
+
+          It looks like you opened an issue without following the bug report template:
+
+          Bug report ([open an issue](https://github.com/codeigniter4/CodeIgniter4/issues/new?assignees=&labels=bug&projects=&template=bug_report.yml&title=Bug%3A+))
+
+          If you are opening a feature request or support question, please do so in the [forums](https://forum.codeigniter.com/forum-30.html).
+
+          The current issue will be closed. This is a precaution to save maintainers' time, I hope you'll understand.
+
+          Sincerely, the mergeable bot 🤖
+      - do: close

.github/mergeable.yml

@@ -1,5 +1,17 @@
 # Changelog
 
+## [v4.5.7](https://github.com/codeigniter4/CodeIgniter4/tree/v4.5.7) (2024-12-31)
+[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.5.6...v4.5.7)
+
+### Fixed Bugs
+
+* fix: handle namespaced helper found on Common helper by @samsonasik in https://github.com/codeigniter4/CodeIgniter4/pull/9354
+* fix: `Forge::dropColumn()` always returns `false` on SQLite3 driver by @paulbalandan in https://github.com/codeigniter4/CodeIgniter4/pull/9351
+
+### Refactoring
+
+* refactor: enable AddArrowFunctionReturnTypeRector by @samsonasik in https://github.com/codeigniter4/CodeIgniter4/pull/9343
+
 ## [v4.5.6](https://github.com/codeigniter4/CodeIgniter4/tree/v4.5.6) (2024-12-28)
 [Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.5.5...v4.5.6)
 

CHANGELOG.md

@@ -50,7 +50,7 @@
             $function .= $padClass . $error['function'];
         }
 
-        $args = implode(', ', array_map(static fn ($value) => match (true) {
+        $args = implode(', ', array_map(static fn ($value): string => match (true) {
             is_object($value) => 'Object(' . $value::class . ')',
             is_array($value)  => $value !== [] ? '[...]' : '[]',
             $value === null   => 'null', // return the lowercased version

app/Views/errors/cli/error_exception.php

@@ -10,7 +10,7 @@
         <output>api/build/</output>
         <cache>api/cache/</cache>
     </paths>
-    <version number="4.5.6">
+    <version number="4.5.7">
         <api format="php">
             <source dsn=".">
                 <path>system</path>

phpdoc.dist.xml

@@ -41,6 +41,7 @@
 use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
 use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
+use Rector\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector;
 use Rector\TypeDeclaration\Rector\Closure\AddClosureVoidReturnTypeWhereNoReturnRector;
@@ -201,6 +202,7 @@
         TypedPropertyFromAssignsRector::class,
         ClosureReturnTypeRector::class,
         FlipTypeControlToUseExclusiveTypeRector::class,
+        AddArrowFunctionReturnTypeRector::class,
     ])
     ->withConfiguredRule(StringClassNameToClassConstantRector::class, [
         // keep '\\' prefix string on string '\Foo\Bar'

rector.php

@@ -339,7 +339,7 @@ public static function promptByMultipleKeys(string $text, array $options): array
             $pattern = preg_match_all('/^\d+(,\d+)*$/', trim($input));
 
             // separate input by comma and convert all to an int[]
-            $inputToArray = array_map(static fn ($value) => (int) $value, explode(',', $input));
+            $inputToArray = array_map(static fn ($value): int => (int) $value, explode(',', $input));
             // find max from key of $options
             $maxOptions = array_key_last($options);
             // find max from input

system/CLI/CLI.php

@@ -56,7 +56,7 @@ class CodeIgniter
     /**
      * The current version of CodeIgniter Framework
      */
-    public const CI_VERSION = '4.5.6';
+    public const CI_VERSION = '4.5.7';
 
     /**
      * App startup time.