Skip to content

Commit 4d78e93

Browse files
committed
[Fizz] Share code between inline and external runtime (facebook#33066)
Stacked on facebook#33065. The runtime is about to be a lot more complicated so we need to start sharing some more code. The problem with sharing code is that we want the inline runtime to as much as possible be isolated in its scope using only a few global variables to refer across runtimes. A problem with Closure Compiler is that it refuses to inline functions if they have closures inside of them. Which makes sense because of how VMs work it can cause memory leaks. However, in our cases this doesn't matter and code size matters more. So we can't use many clever tricks. So this just favors writing the source in the inline form. Then we add an extra compiler pass to turn those global variables into local variables in the external runtime. DiffTrain build for [bb57fa7](facebook@bb57fa7)
1 parent 7aaf1bd commit 4d78e93

37 files changed

+182
-178
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e9db3cc2d4175849578418a37f33a6fde5b3c6d8
1+
bb57fa7351776a86448c1a094bea8108fd6b34ff
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e9db3cc2d4175849578418a37f33a6fde5b3c6d8
1+
bb57fa7351776a86448c1a094bea8108fd6b34ff

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1538,7 +1538,7 @@ __DEV__ &&
15381538
exports.useTransition = function () {
15391539
return resolveDispatcher().useTransition();
15401540
};
1541-
exports.version = "19.2.0-www-classic-e9db3cc2-20250501";
1541+
exports.version = "19.2.0-www-classic-bb57fa73-20250501";
15421542
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15431543
"function" ===
15441544
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1538,7 +1538,7 @@ __DEV__ &&
15381538
exports.useTransition = function () {
15391539
return resolveDispatcher().useTransition();
15401540
};
1541-
exports.version = "19.2.0-www-modern-e9db3cc2-20250501";
1541+
exports.version = "19.2.0-www-modern-bb57fa73-20250501";
15421542
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15431543
"function" ===
15441544
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,4 +636,4 @@ exports.useSyncExternalStore = function (
636636
exports.useTransition = function () {
637637
return ReactSharedInternals.H.useTransition();
638638
};
639-
exports.version = "19.2.0-www-classic-e9db3cc2-20250501";
639+
exports.version = "19.2.0-www-classic-bb57fa73-20250501";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,4 +636,4 @@ exports.useSyncExternalStore = function (
636636
exports.useTransition = function () {
637637
return ReactSharedInternals.H.useTransition();
638638
};
639-
exports.version = "19.2.0-www-modern-e9db3cc2-20250501";
639+
exports.version = "19.2.0-www-modern-bb57fa73-20250501";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ exports.useSyncExternalStore = function (
640640
exports.useTransition = function () {
641641
return ReactSharedInternals.H.useTransition();
642642
};
643-
exports.version = "19.2.0-www-classic-e9db3cc2-20250501";
643+
exports.version = "19.2.0-www-classic-bb57fa73-20250501";
644644
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
645645
"function" ===
646646
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ exports.useSyncExternalStore = function (
640640
exports.useTransition = function () {
641641
return ReactSharedInternals.H.useTransition();
642642
};
643-
exports.version = "19.2.0-www-modern-e9db3cc2-20250501";
643+
exports.version = "19.2.0-www-modern-bb57fa73-20250501";
644644
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
645645
"function" ===
646646
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19014,10 +19014,10 @@ __DEV__ &&
1901419014
(function () {
1901519015
var internals = {
1901619016
bundleType: 1,
19017-
version: "19.2.0-www-classic-e9db3cc2-20250501",
19017+
version: "19.2.0-www-classic-bb57fa73-20250501",
1901819018
rendererPackageName: "react-art",
1901919019
currentDispatcherRef: ReactSharedInternals,
19020-
reconcilerVersion: "19.2.0-www-classic-e9db3cc2-20250501"
19020+
reconcilerVersion: "19.2.0-www-classic-bb57fa73-20250501"
1902119021
};
1902219022
internals.overrideHookState = overrideHookState;
1902319023
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19051,7 +19051,7 @@ __DEV__ &&
1905119051
exports.Shape = Shape;
1905219052
exports.Surface = Surface;
1905319053
exports.Text = Text;
19054-
exports.version = "19.2.0-www-classic-e9db3cc2-20250501";
19054+
exports.version = "19.2.0-www-classic-bb57fa73-20250501";
1905519055
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1905619056
"function" ===
1905719057
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18786,10 +18786,10 @@ __DEV__ &&
1878618786
(function () {
1878718787
var internals = {
1878818788
bundleType: 1,
18789-
version: "19.2.0-www-modern-e9db3cc2-20250501",
18789+
version: "19.2.0-www-modern-bb57fa73-20250501",
1879018790
rendererPackageName: "react-art",
1879118791
currentDispatcherRef: ReactSharedInternals,
18792-
reconcilerVersion: "19.2.0-www-modern-e9db3cc2-20250501"
18792+
reconcilerVersion: "19.2.0-www-modern-bb57fa73-20250501"
1879318793
};
1879418794
internals.overrideHookState = overrideHookState;
1879518795
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18823,7 +18823,7 @@ __DEV__ &&
1882318823
exports.Shape = Shape;
1882418824
exports.Surface = Surface;
1882518825
exports.Text = Text;
18826-
exports.version = "19.2.0-www-modern-e9db3cc2-20250501";
18826+
exports.version = "19.2.0-www-modern-bb57fa73-20250501";
1882718827
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1882818828
"function" ===
1882918829
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)