Revert Slot changes causing RSC errors (radix-ui#3554)

Author: chaance

.changeset/twenty-apples-stay.md

@@ -0,0 +1,5 @@
+---
+'@radix-ui/react-slot': patch
+---
+
+Revert slot changes causing errors in server components

packages/react/slot/src/index.ts

@@ -1,4 +1,3 @@
-'use client';
 export {
   Slot,
   Slottable,

packages/react/slot/src/slot.test.tsx

@@ -1,4 +1,4 @@
-import React, { useState } from 'react';
+import * as React from 'react';
 import { cleanup, render, screen, fireEvent } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import { Slot, Slottable } from './slot';
@@ -140,7 +140,9 @@ describe('given a Button with Slottable', () => {
   });
 });
 
-describe('given an Input', () => {
+// TODO: Unskip when underlying issue is resolved
+// Reverted in https://github.com/radix-ui/primitives/pull/3554
+describe.skip('given an Input', () => {
   const handleRef = vi.fn();
 
   beforeEach(() => {
@@ -199,7 +201,7 @@ const Input = React.forwardRef<
   }
 >(({ asChild, children, ...props }, forwardedRef) => {
   const Comp = asChild ? Slot : 'input';
-  const [value, setValue] = useState('');
+  const [value, setValue] = React.useState('');
 
   return (
     <Comp

packages/react/slot/src/slot.tsx

@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { useComposedRefs } from '@radix-ui/react-compose-refs';
+import { composeRefs } from '@radix-ui/react-compose-refs';
 
 /* -------------------------------------------------------------------------------------------------
  * Slot
@@ -66,14 +66,13 @@ interface SlotCloneProps {
 /* @__NO_SIDE_EFFECTS__ */ function createSlotClone(ownerName: string) {
   const SlotClone = React.forwardRef<any, SlotCloneProps>((props, forwardedRef) => {
     const { children, ...slotProps } = props;
-    const childrenRef = React.isValidElement(children) ? getElementRef(children) : undefined;
-    const ref = useComposedRefs(childrenRef, forwardedRef);
 
     if (React.isValidElement(children)) {
+      const childrenRef = getElementRef(children);
       const props = mergeProps(slotProps, children.props as AnyProps);
       // do not pass ref to React.Fragment for React 19 compatibility
       if (children.type !== React.Fragment) {
-        props.ref = ref;
+        props.ref = forwardedRef ? composeRefs(forwardedRef, childrenRef) : childrenRef;
       }
       return React.cloneElement(children, props);
     }