Skip to content

Commit 75abc51

Browse files
committed
feat(rx): increase test coverage
1 parent 331c44c commit 75abc51

22 files changed

+78
-16
lines changed

libs/rx/platform/src/lib/create-intersection-observer.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {createElementRef, mockIntersectionObserver} from '@angular-kit/testing';
1+
import {createElementRef, mockIntersectionObserver} from '@angular-kit/test-helpers';
22
import {createIntersectionObserver} from './create-intersection-observer';
33
import {subscribeSpyTo} from '@hirez_io/observer-spy';
44
import {fakeAsync, tick} from '@angular/core/testing';

libs/rx/platform/src/lib/create-mutation-observer.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {createMutationObserver} from './create-mutation-observer';
22
import {subscribeSpyTo} from '@hirez_io/observer-spy';
3-
import {createElementRef, mockMutationObserver} from '@angular-kit/testing';
3+
import {createElementRef, mockMutationObserver} from '@angular-kit/test-helpers';
44
import {fakeAsync, tick} from '@angular/core/testing';
55

66
describe('createMutationObserver', () => {

libs/rx/platform/src/lib/create-resize-observer.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {createResizeObserver} from './create-resize-observer';
22
import {fakeAsync, tick} from '@angular/core/testing';
33
import {subscribeSpyTo} from '@hirez_io/observer-spy';
4-
import {createElementRef, mockResizeObserver} from '@angular-kit/testing';
4+
import {createElementRef, mockResizeObserver} from '@angular-kit/test-helpers';
55

66
describe('createResizeObserver', () => {
77
describe('supported', () => {

libs/rx/platform/src/lib/directives/observe-intersection.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {Directive, NgModule} from '@angular/core';
22
import {CommonModule} from '@angular/common';
33

44
@Directive({
5-
selector: '[angularKitObserveIntersection]',
5+
selector: '[observeIntersection]',
66
})
77
export class ObserveIntersectionDirective {
88
// todo

libs/rx/platform/src/lib/directives/observe-resize.directive.spec.ts

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,23 @@
11
import {ObserveResizeDirective, ObserveResizeDirectiveModule} from './observe-resize.directive';
2-
import {Component} from '@angular/core';
3-
import {ComponentFixture, TestBed} from '@angular/core/testing';
4-
import {mockResizeObserver} from '@angular-kit/testing';
2+
import {Component, ViewChild} from '@angular/core';
3+
import {ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
4+
import {mockResizeObserver} from '@angular-kit/test-helpers';
5+
import {subscribeSpyTo} from "@hirez_io/observer-spy";
56

67
describe('ObserveResizeDirective', () => {
78
it('should create an instance', async () => {
89
const { testComponent } = await create();
910
expect(testComponent).toBeTruthy();
1011
});
12+
13+
it('should emit on resize', fakeAsync (async () => {
14+
const {testComponent, fixture} = await create();
15+
const result = subscribeSpyTo(testComponent.directive.resizeEvent);
16+
17+
fixture.nativeElement.dispatchEvent(new Event('resize'));
18+
tick(1000)
19+
expect(result.getValues().length).toEqual(1)
20+
}));
1121
});
1222

1323
async function create() {
@@ -26,6 +36,7 @@ async function create() {
2636
`,
2737
})
2838
class TestComponent {
39+
@ViewChild(ObserveResizeDirective, {static: true}) directive!: ObserveResizeDirective;
2940
onResize = jest.fn();
3041
observe = true;
3142
}

libs/rx/platform/src/lib/directives/observe-resize.directive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import {Directive, ElementRef, Input, NgModule, OnDestroy, Output} from '@angula
22
import {CommonModule} from '@angular/common';
33
import {Subscription} from 'rxjs';
44
import {createResizeObserver, ResizeObserverConfig} from '../create-resize-observer';
5-
import {createSignal} from '@code-workers.io/angular-kit/rx/signal';
6-
import {Nullable} from '@code-workers.io/angular-kit/cdk/types';
5+
import {createSignal} from '@angular-kit/rx/signal';
6+
import {Nullable} from '@angular-kit/cdk/types';
77

88
@Directive({
99
selector: '[observeResize]',
File renamed without changes.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# testing
1+
# test-helpers
22

33
This library was generated with [Nx](https://nx.dev).
44

55
## Running unit tests
66

7-
Run `nx test testing` to execute the unit tests.
7+
Run `nx test test-helpers` to execute the unit tests.

libs/testing/jest.config.ts renamed to libs/test-helpers/jest.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable */
22
export default {
3-
displayName: 'testing',
3+
displayName: 'test-helpers',
44
preset: '../../jest.preset.js',
55
setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
66
globals: {
@@ -9,7 +9,7 @@ export default {
99
stringifyContentPathRegex: '\\.(html|svg)$',
1010
},
1111
},
12-
coverageDirectory: '../../coverage/libs/testing',
12+
coverageDirectory: '../../coverage/libs/test-helpers',
1313
transform: {
1414
'^.+\\.(ts|mjs|js|html)$': 'jest-preset-angular',
1515
},

libs/testing/ng-package.json renamed to libs/test-helpers/ng-package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
3-
"dest": "../../dist/libs/testing",
3+
"dest": "../../dist/libs/test-helpers",
44
"lib": {
55
"entryFile": "src/index.ts"
66
}

0 commit comments

Comments
 (0)