Skip to content

Commit 61f83f4

Browse files
committed
refactor(@angular/cli): remove unused update requirements metadata field
The internal `update` schematic was attempting to parse a `requirements` field on the `ng-update` package.json metadata. This field is otherwise unused and can be safely removed.
1 parent 98c207b commit 61f83f4

File tree

1 file changed

+3
-21
lines changed
  • packages/angular/cli/src/commands/update/schematic

1 file changed

+3
-21
lines changed

packages/angular/cli/src/commands/update/schematic/index.ts

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,12 @@
99
import { logging } from '@angular-devkit/core';
1010
import { Rule, SchematicContext, SchematicsException, Tree } from '@angular-devkit/schematics';
1111
import * as npa from 'npm-package-arg';
12-
import type { Manifest } from 'pacote';
1312
import * as semver from 'semver';
14-
import {
15-
NgPackageManifestProperties,
16-
NpmRepositoryPackageJson,
17-
getNpmPackageJson,
18-
} from '../../../utilities/package-metadata';
13+
import { PackageManifest } from '../../../package-managers';
14+
import { NpmRepositoryPackageJson, getNpmPackageJson } from '../../../utilities/package-metadata';
1915
import { Schema as UpdateSchema } from './schema';
2016

21-
interface JsonSchemaForNpmPackageJsonFiles extends Manifest, NgPackageManifestProperties {
17+
interface JsonSchemaForNpmPackageJsonFiles extends PackageManifest {
2218
peerDependenciesMeta?: Record<string, { optional?: boolean }>;
2319
}
2420

@@ -389,20 +385,6 @@ function _getUpdateMetadata(
389385
result.packageGroupName = metadata['packageGroupName'];
390386
}
391387

392-
if (metadata['requirements']) {
393-
const requirements = metadata['requirements'];
394-
// Verify that requirements are
395-
if (
396-
typeof requirements != 'object' ||
397-
Array.isArray(requirements) ||
398-
Object.keys(requirements).some((name) => typeof requirements[name] != 'string')
399-
) {
400-
logger.warn(`requirements metadata of package ${packageJson.name} is malformed. Ignoring.`);
401-
} else {
402-
result.requirements = requirements;
403-
}
404-
}
405-
406388
if (metadata['migrations']) {
407389
const migrations = metadata['migrations'];
408390
if (typeof migrations != 'string') {

0 commit comments

Comments
 (0)