Skip to content

Commit 5fd9626

Browse files
committed
fix(skill): update WrapModel to return error per interface change
1 parent 2064c47 commit 5fd9626

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

adk/middlewares/skill/skill.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -156,26 +156,26 @@ func (h *skillHandler) BeforeAgent(ctx context.Context, runCtx *adk.ChatModelAge
156156
return ctx, runCtx, nil
157157
}
158158

159-
func (h *skillHandler) WrapModel(ctx context.Context, m model.BaseChatModel, mc *adk.ModelContext) model.BaseChatModel {
159+
func (h *skillHandler) WrapModel(ctx context.Context, m model.BaseChatModel, mc *adk.ModelContext) (model.BaseChatModel, error) {
160160
if h.tool.modelHub == nil {
161-
return m
161+
return m, nil
162162
}
163163
modelName, found, err := adk.GetRunLocalValue(ctx, activeModelKey)
164164
if err != nil {
165-
return m
165+
return nil, fmt.Errorf("failed to get active model from run local value: %w", err)
166166
}
167167
if !found {
168-
return m
168+
return m, nil
169169
}
170170
name, ok := modelName.(string)
171171
if !ok || name == "" {
172-
return m
172+
return m, nil
173173
}
174174
newModel, err := h.tool.modelHub.Get(ctx, name)
175175
if err != nil {
176-
return m
176+
return nil, fmt.Errorf("failed to get model '%s' from ModelHub: %w", name, err)
177177
}
178-
return newModel
178+
return newModel, nil
179179
}
180180

181181
const activeModelKey = "__skill_active_model__"

0 commit comments

Comments
 (0)