Skip to content

Commit cba5a12

Browse files
Merge pull request #657 from cloudinary/fix/metadata-fields-api-response-types
Fix/metadata fields api response types
2 parents 7233d76 + cab4b7b commit cba5a12

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

types/cloudinary_ts_spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,9 @@ cloudinary.v2.api.add_metadata_field({
654654

655655
cloudinary.v2.api.list_metadata_fields().then((result) => {
656656
console.log(result.metadata_fields[0].datasource);
657+
console.log(result.metadata_fields[0].datasource.values[0].value);
658+
console.log(result.metadata_fields[0].datasource.values[0].external_id);
659+
console.log(result.metadata_fields[0].datasource.values[0].state);
657660
});
658661

659662
cloudinary.v2.api.delete_metadata_field('EXTERNAL_ID_GET_LIST').then((res) => {

types/index.d.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,9 @@ declare module 'cloudinary' {
702702
mandatory: boolean;
703703
default_value: number;
704704
validation: object; //there are 4 types, we need to discuss documentation team about it before implementing.
705-
datasource: DatasourceEntry;
705+
datasource: {
706+
values: Array<DatasourceEntry>
707+
};
706708

707709
[futureKey: string]: any;
708710
}
@@ -711,6 +713,12 @@ declare module 'cloudinary' {
711713
metadata_fields: MetadataFieldApiResponse[]
712714
}
713715

716+
export interface DatasourceEntry {
717+
external_id?: string;
718+
value: string;
719+
state?: 'active' | 'inactive'
720+
}
721+
714722
export interface DatasourceChange {
715723
values: Array<DatasourceEntry>
716724
}
@@ -831,11 +839,6 @@ declare module 'cloudinary' {
831839

832840
export type SignApiOptions = Record<string, any>;
833841

834-
export interface DatasourceEntry {
835-
external_id?: string;
836-
value: string;
837-
}
838-
839842
export namespace v2 {
840843

841844
/****************************** Global Utils *************************************/

0 commit comments

Comments
 (0)