[build] Expand clang-tidy coverage

Author: fhanau

.clang-tidy

@@ -16,11 +16,13 @@ Checks: >
   bugprone-return-const-ref-from-parameter,
   bugprone-suspicious-*,
   -bugprone-suspicious-semicolon,
+  bugprone-switch-missing-default-case,
   bugprone-undefined-memory-manipulation,
   bugprone-unhandled-self-assignment,
   bugprone-unused-raii,
   bugprone-use-after-move,
   cppcoreguidelines-c-copy-assignment-signature,
+  cppcoreguidelines-interfaces-global-init,
   cppcoreguidelines-misleading-capture-default-by-value,
   cppcoreguidelines-noexcept-destructor,
   cppcoreguidelines-prefer-member-initializer,
@@ -32,6 +34,7 @@ Checks: >
   misc-unused-alias-decls,
   misc-unused-using-decls,
   modernize-avoid-variadic-functions,
+  modernize-loop-convert,
   modernize-macro-to-enum,
   modernize-redundant-void-arg,
   modernize-type-traits,
@@ -72,6 +75,7 @@ Checks: >
 # modernize-use-override
 # modernize-use-ranges
 # readability-avoid-return-with-void-value
+# readability-convert-member-functions-to-static
 # readability-redundant-smartptr-get
 # readability-use-anyofallof
 

src/workerd/api/analytics-engine-impl.h

@@ -20,6 +20,7 @@ void setDoubles(Message msg, kj::ArrayPtr<double> arr, kj::StringPtr errorPrefix
 
   uint index = 1;
   for (auto& item: arr) {
+    // NOLINTNEXTLINE(bugprone-switch-missing-default-case)
     switch (index) {
       case 1:
         msg.setDouble1(item);
@@ -108,6 +109,7 @@ void setBlobs(Message msg,
       sizeSum += value.size();
       JSG_REQUIRE(sizeSum <= MAX_CUMULATIVE_BYTES_IN_BLOBS, TypeError, errorPrefix,
           "Cumulative size of blobs exceeds ", MAX_CUMULATIVE_BYTES_IN_BLOBS, " bytes).");
+      // NOLINTNEXTLINE(bugprone-switch-missing-default-case)
       switch (index) {
         case 1:
           msg.setBlob1(value);

src/workerd/api/crypto/aes.c++

@@ -475,8 +475,9 @@ class AesCtrKey final: public AesKeyBase {
         return *EVP_aes_192_ctr();
       case 32:
         return *EVP_aes_256_ctr();
+      default:
+        KJ_FAIL_ASSERT("CryptoKey has invalid data length");
     }
-    KJ_FAIL_ASSERT("CryptoKey has invalid data length");
   }
 
   jsg::BufferSource encryptOrDecrypt(jsg::Lock& js,

src/workerd/api/crypto/ec.c++

@@ -1120,9 +1120,9 @@ kj::OneOf<jsg::Ref<CryptoKey>, CryptoKeyPair> EdDsaKey::generateKey(jsg::Lock& j
     case NID_X25519:
       return generateKeyImpl<X25519_PUBLIC_VALUE_LEN, X25519_keypair>(js, normalizedName, nid,
           privateKeyUsages, publicKeyUsages, extractablePrivateKey, "X25519"_kj);
+    default:
+      KJ_FAIL_REQUIRE("ED ", normalizedName, " unimplemented", nid);
   }
-
-  KJ_FAIL_REQUIRE("ED ", normalizedName, " unimplemented", nid);
 }
 
 }  // namespace

src/workerd/api/crypto/impl.c++

@@ -137,6 +137,7 @@ kj::Vector<kj::OneOf<kj::StringPtr, OpensslUntranslatedError>> consumeAllOpenssl
           switch (ERR_GET_REASON(error)) {
             case RSA_R_DATA_LEN_NOT_EQUAL_TO_MOD_LEN:
               return "Invalid RSA signature."_kj;
+            default:
           }
           break;
         case ERR_LIB_EC:
@@ -149,8 +150,10 @@ kj::Vector<kj::OneOf<kj::StringPtr, OpensslUntranslatedError>> consumeAllOpenssl
               return "Point is not on curve."_kj;
             case EC_R_UNKNOWN_GROUP:
               return "Unsupported elliptic curve group."_kj;
+            default:
           }
           break;
+        default:
       }
 
       return OpensslUntranslatedError{

src/workerd/api/crypto/jwk.c++

@@ -283,14 +283,12 @@ JsonWebKey toJwk(const EVPKeyPointer& key, KeyType keyType) {
         return jwkFromRsaKey(key, keyType);
       case EVP_PKEY_DSA: {
         // DSA keys are not supported for JWK export.
-        break;
+        [[fallthrough]];
       }
+      default:
+        return JsonWebKey{.kty = kj::str("INVALID")};
     }
   }
-
-  return JsonWebKey{
-    .kty = kj::str("INVALID"),
-  };
 }
 
 EVPKeyPointer fromJwk(const JsonWebKey& jwk, KeyType keyType) {

src/workerd/api/crypto/x509.c++

@@ -820,6 +820,7 @@ jsg::JsObject X509Certificate::toLegacyObject(jsg::Lock& js) {
         }
         break;
       }
+      default:
     }
   }
 

src/workerd/api/form-data.c++

@@ -512,8 +512,7 @@ void FormData::forEach(jsg::Lock& js,
   // it up. Using the classic for (;;) syntax here allows for that. However, this does
   // mean that it's possible for a user to trigger an infinite loop here if new items
   // are added to the search params unconditionally on each iteration.
-  for (size_t i = 0; i < this->data.size(); i++) {
-    auto& [key, value] = this->data[i];
+  for (auto& [key, value]: this->data) {
     callback(js, clone(js, value), key, JSG_THIS);
   }
 }

src/workerd/api/url.c++

@@ -623,8 +623,7 @@ void URLSearchParams::forEach(jsg::Lock& js,
   // it up. Using the classic for (;;) syntax here allows for that. However, this does
   // mean that it's possible for a user to trigger an infinite loop here if new items
   // are added to the search params unconditionally on each iteration.
-  for (size_t i = 0; i < this->url->query.size(); i++) {
-    auto& [key, value] = this->url->query[i];
+  for (auto& [key, value]: this->url->query) {
     callback(js, value, key, JSG_THIS);
   }
 }

src/workerd/io/trace.c++

@@ -1156,8 +1156,8 @@ kj::Maybe<kj::Array<kj::String>> getScriptTagsFromReader(const rpc::Trace::Onset
   if (reader.hasScriptTags()) {
     auto tags = reader.getScriptTags();
     kj::Vector<kj::String> scriptTags(tags.size());
-    for (size_t i = 0; i < tags.size(); i++) {
-      scriptTags.add(kj::str(tags[i]));
+    for (auto&& tag: tags) {
+      scriptTags.add(kj::str(tag));
     }
     return kj::Maybe(scriptTags.releaseAsArray());
   }
@@ -1339,8 +1339,8 @@ TailEvent::Event readEventFromTailEvent(const rpc::Trace::TailEvent::Reader& rea
     case rpc::Trace::TailEvent::Event::ATTRIBUTE: {
       auto listReader = event.getAttribute();
       kj::Vector<Attribute> attrs(listReader.size());
-      for (size_t n = 0; n < listReader.size(); n++) {
-        attrs.add(Attribute(listReader[n]));
+      for (auto&& reader: listReader) {
+        attrs.add(Attribute(reader));
       }
       return attrs.releaseAsArray();
     }