Skip to content

Commit 012d505

Browse files
committed
add no-coverage tag to several tests
1 parent 4317109 commit 012d505

File tree

4 files changed

+27
-5
lines changed

4 files changed

+27
-5
lines changed

build/wd_ts_test.bzl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,14 @@ def wd_ts_test(src, tsconfig_json, deps = [], eslintrc_json = None, composite =
1717
composite = composite,
1818
)
1919

20+
# TODO(soon): Remove 'no-coverage' tag once
21+
# https://github.com/aspect-build/rules_js/pull/2653 lands.
22+
# This is a workaround for a bug in aspect_rules_js with the
23+
# --experimental_split_coverage_postprocessing flag.
2024
js_test(
2125
name = name,
2226
entry_point = js_name(src),
2327
data = deps + [name + "@compile"],
24-
tags = ["no-arm64", "js-test"],
28+
tags = ["no-arm64", "js-test", "no-coverage"],
2529
**kwargs
2630
)

src/workerd/server/tests/inspector/BUILD.bazel

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_test")
22

3+
# TODO(soon): Remove 'no-coverage' tag once
4+
# https://github.com/aspect-build/rules_js/pull/2653 lands.
5+
# This is a workaround for a bug in aspect_rules_js with the
6+
# --experimental_split_coverage_postprocessing flag.
37
js_test(
48
name = "inspector-test",
59
size = "large",
@@ -15,5 +19,8 @@ js_test(
1519
"WORKERD_BINARY": "$(rootpath //src/workerd/server:workerd)",
1620
"WORKERD_CONFIG": "$(rootpath :config.capnp)",
1721
},
18-
tags = ["js-test"],
22+
tags = [
23+
"js-test",
24+
"no-coverage",
25+
],
1926
)

src/workerd/server/tests/structured-logging/BUILD.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_test")
22

3+
# TODO(soon): Remove 'no-coverage' tag once
4+
# https://github.com/aspect-build/rules_js/pull/2653 lands.
5+
# This is a workaround for a bug in aspect_rules_js with the
6+
# --experimental_split_coverage_postprocessing flag.
37
js_test(
48
name = "structured-logging-test",
59
data = [
@@ -11,4 +15,5 @@ js_test(
1115
"WORKERD_BINARY": "$(rootpath //src/workerd/server:workerd)",
1216
"WD_TEST_CONFIG": "$(rootpath :structured-logging-json.wd-test)",
1317
},
18+
tags = ["no-coverage"],
1419
)

tools/BUILD.bazel

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,21 @@ js_library(
1818
],
1919
)
2020

21+
# TODO(soon): Remove 'no-coverage' tag once
22+
# https://github.com/aspect-build/rules_js/pull/2653 lands.
23+
# This is a workaround for a bug in aspect_rules_js with the
24+
# --experimental_split_coverage_postprocessing flag.
2125
js_test(
2226
name = "custom-eslint-rules-test",
2327
size = "small",
2428
data = [
25-
"custom-eslint-rules.mjs",
26-
"//:node_modules/eslint",
29+
":base-eslint",
2730
],
2831
entry_point = "custom-eslint-rules.test.mjs",
29-
tags = ["js-test"],
32+
tags = [
33+
"js-test",
34+
"no-coverage",
35+
],
3036
)
3137

3238
ts_config(

0 commit comments

Comments
 (0)