Merge pull request #138 from clj-commons/hls/20250613-tweaks

Adjust the default-frame-rules

Author: hlship

.github/workflows/clojure.yml

@@ -18,15 +18,15 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup Java
-        uses: actions/[email protected].0
+        uses: actions/[email protected].1
         with:
           java-version: '11'
           distribution: 'corretto'
 
       - name: Install clojure tools
-        uses: DeLaGuardo/setup-clojure@13.2
+        uses: DeLaGuardo/setup-clojure@13.4
         with:
-          cli: 1.12.0.1530
+          cli: 1.12.1.1550
 
       - name: Cache clojure dependencies
         uses: actions/cache@v4

CHANGES.md

@@ -10,6 +10,11 @@
     - New `miniminal-style` for table output that uses only spaces to separate columns
     - New :title-align and :align keys for columns to be used instead of :title-pad and :pad (support for which may be removed in the future)
     - Table styles now include a :divider? key which, if true, enables the divider between the title line and the first row of data (previously, the divider was not optional)
+- `clj-commons.format.exceptions`
+    - `default-frame-rules` was changed to add default rules (to further limit clutter in exceptions reports)
+      - omit `clojure.core/apply` and `clojure.core/with-bindings*`
+      - omit several functions in `clojure.test`
+      
 
 ## 3.3.2 - 28 Mar 2025
 

deps.edn

@@ -1,14 +1,14 @@
 {:paths ["src"]
- :deps {org.clojure/clojure {:mvn/version "1.12.0"}}
+ :deps {org.clojure/clojure {:mvn/version "1.12.1"}}
 
  :aliases
  {:test
   ;; clj -X:test
   {:extra-paths ["test"]
    :extra-deps {criterium/criterium {:mvn/version "0.4.6"}
-                org.clojure/core.async {:mvn/version "1.7.701"}
+                org.clojure/core.async {:mvn/version "1.8.741"}
                 nubank/matcher-combinators {:mvn/version "3.9.1"}
-                io.github.tonsky/clj-reload {:mvn/version "0.9.4"}
+                io.github.tonsky/clj-reload {:mvn/version "0.9.7"}
                 io.github.cognitect-labs/test-runner {:git/tag "v0.5.1"
                                                       :git/sha "dfb30dd"}}
    :jvm-opts ["-Dclj-commons.ansi.enabled=true"]
@@ -21,10 +21,10 @@
    :ns-default build}
 
   :1.11
-  {:override-deps {org.clojure/clojure {:mvn/version "1.11.4"}}}
+  {:override-deps {org.clojure/clojure {:mvn/version "1.12.1"}}}
 
   :1.10
-  {:override-deps {org.clojure/clojure {:mvn/version "1.10.3"}}}
+  {:override-deps {org.clojure/clojure {:mvn/version "1.12.1"}}}
 
   ;; clj -M:test:demo
   :demo
@@ -36,7 +36,7 @@
   ;; clj -M:lint
 
   :lint
-  {:deps {clj-kondo/clj-kondo {:mvn/version "2025.02.20"}}
+  {:deps {clj-kondo/clj-kondo {:mvn/version "2025.06.05"}}
    :main-opts ["-m" "clj-kondo.main" "--lint" "src"]}
 
   :nrepl

src/clj_commons/format/exceptions.clj

@@ -3,7 +3,7 @@
   (:require [clojure.pprint :as pp]
             [clojure.set :as set]
             [clojure.string :as str]
-            [clj-commons.ansi :refer [compose]]
+            [clj-commons.ansi :refer [compose perr]]
             [clj-commons.pretty-impl :refer [padding]])
   (:refer-clojure :exclude [*print-level* *print-length*])
   (:import (java.lang StringBuilder StackTraceElement)
@@ -115,18 +115,22 @@
 
  The default rules:
 
- * omit everything in `clojure.lang`, `java.lang.reflect`, and the function `clojure.core/apply`
+ * omit everything in `clojure.lang`, `java.lang.reflect`
+ * omit `clojure.core/with-bindings*` and `clojure.core/apply`
  * hide everything in `sun.reflect`
+ * omit a number of functions in `clojure.test`
  * terminate at `speclj.*`, `clojure.main/main*`, `clojure.main/repl/read-eval-print`, or `nrepl.middleware.interruptible-eval`
  "
   [[:package "clojure.lang" :omit]
+   [:name "clojure.core/with-bindings*" :omit]
    [:package #"sun\.reflect.*" :hide]
    [:package "java.lang.reflect" :omit]
    [:name #"speclj\..*" :terminate]
    [:name "clojure.core/apply" :omit]
    [:name #"nrepl\.middleware\.interruptible-eval/.*" :terminate]
    [:name #"clojure\.main/repl/read-eval-print.*" :terminate]
-   [:name #"clojure\.main/main.*" :terminate]])
+   [:name #"clojure\.main/main.*" :terminate]
+   [:name #"\Qclojure.test/\E(test-ns|test-all-vars|default-fixture).*" :omit]])
 
 (def ^{:added "0.1.18"
        :dynamic true}
@@ -312,12 +316,11 @@
 
 (def ^:private stack-trace-warning
   (delay
-    (binding [*out* *err*]
-      (println (compose
-                 [:bright-yellow "WARNING: "]
-                 "Stack trace of root exception is empty; this is likely due to a JVM optimization that can be disabled with "
-                 [:bold "-XX:-OmitStackTraceInFastThrow"] "."))
-      (flush))))
+    (perr
+      [:bright-yellow "WARNING: "]
+      "Stack trace of root exception is empty; this is likely due to a JVM optimization that can be disabled with "
+      [:bold "-XX:-OmitStackTraceInFastThrow"] ".")
+    (flush)))
 
 (defn transform-stack-trace
   "Transforms a seq of StackTraceElement objects into a seq of stack frame maps:

test/demo.clj

@@ -2,7 +2,7 @@
   (:require
     [clj-commons.pretty.repl :as repl]
     [clj-commons.format.exceptions :as e]
-    [clj-commons.ansi :refer [compose pcompose pout]]
+    [clj-commons.ansi :refer [compose pout]]
     [clj-commons.format.binary :as b]
     [clojure.java.io :as io]
     [clojure.repl :refer [pst]]
@@ -36,7 +36,7 @@
   "Creates a sample exception used to test the exception formatting logic."
   []
   (try
-    (update-row)
+    (apply update-row [])
     (catch Throwable e
       ;; Return it, not rethrow it.
       (RuntimeException. "Request handling exception" e))))
@@ -71,7 +71,7 @@
   (println "Clojure version: " *clojure-version*)
   (println "Installing pretty exceptions ...")
   (repl/install-pretty-exceptions)
-  (pcompose [:bold.green "ok"])
+  (pout [:bold.green "ok"])
   (pst (make-exception))
   (println "\nTesting reporting of repeats:")
   (try (countdown 20)