fix pop detection

Author: clarkzjw

cmd/lens/ping.go

@@ -14,6 +14,11 @@ import (
 )
 
 func ICMPPing(target string, interval float64) {
+	if PoP == "" {
+		log.Error().Msg("PoP is empty, skipping ICMP ping")
+		return
+	}
+
 	ctx, cancel := context.WithTimeout(context.Background(), sessionDuration)
 	defer cancel()
 
@@ -116,6 +121,11 @@ func ICMPPing(target string, interval float64) {
 }
 
 func IRTTPing() {
+	if PoP == "" {
+		log.Error().Msg("PoP is empty, skipping IRTT ping")
+		return
+	}
+
 	ctx, cancel := context.WithTimeout(context.Background(), sessionDuration+time.Minute*10)
 
 	today := checkDirectory()
@@ -127,7 +137,7 @@ func IRTTPing() {
 		defer cancel()
 
 		var local string
-		if IPVersion == 6 {
+		if IPVersion == 6 && len(externalIPv6) > 0 {
 			local = fmt.Sprintf("--local=[%s]", externalIPv6)
 		} else {
 			local = fmt.Sprintf("--local=%s", IRTTLocalIP)

cmd/lens/util.go

@@ -143,7 +143,12 @@ func getExternalIP(version int) string {
 		log.Error().Err(err).Msgf("get external IP%d addresses failed: %s", version, string(output))
 		return ""
 	}
-	return strings.Trim(string(output), "\n")
+	ip := strings.Trim(string(output), "\n")
+	if net.ParseIP(ip) == nil {
+		log.Error().Msgf("get external IP%d addresses failed: invalid IP %s", version, ip)
+		return ""
+	}
+	return ip
 }
 
 func getStarlinkPoP(ip string) string {
@@ -243,6 +248,7 @@ func getStarlinkIPv6ActiveGateway() string {
 func getGateway() string {
 	gatewayIP := ""
 	externalIP := ""
+	PoP = ""
 
 	if ManualSpecifiedGateway != "" {
 		if net.ParseIP(ManualSpecifiedGateway).To4() != nil {
@@ -326,8 +332,6 @@ func getGateway() string {
 
 	if externalIP != "" {
 		PoP = getStarlinkPoP(externalIP)
-	} else {
-		PoP = ""
 	}
 	StarlinkGateway = gatewayIP