[tests] Add tests for scancode_cli analyzer

Add tests for scancode_cli analyzer which also required updating tests
for in-place implementation of colic backend.

Signed-off-by: inishchith <[email protected]>

Author: inishchith

tests/test_colic.py

@@ -33,16 +33,18 @@
 from graal.backends.core.analyzers.scancode import ScanCode
 from graal.backends.core.colic import (CATEGORY_COLIC_NOMOS,
                                        CATEGORY_COLIC_SCANCODE,
+                                       CATEGORY_COLIC_SCANCODE_CLI,
                                        NOMOS,
                                        SCANCODE,
+                                       SCANCODE_CLI,
                                        CoLic,
                                        LicenseAnalyzer,
                                        CoLicCommand)
 from perceval.utils import DEFAULT_DATETIME
 from test_graal import TestCaseGraal
 from base_analyzer import (ANALYZER_TEST_FILE,
                            TestCaseAnalyzer)
-from utils import NOMOS_PATH, SCANCODE_PATH
+from utils import NOMOS_PATH, SCANCODE_PATH, SCANCODE_CLI_PATH
 
 
 class TestCoLicBackend(TestCaseGraal):
@@ -159,6 +161,27 @@ def test_fetch_scancode(self):
             self.assertFalse('parents' in commit['data'])
             self.assertFalse('refs' in commit['data'])
 
+    def test_fetch_scancode_cli(self):
+        """Test whether commits are properly processed"""
+
+        cl = CoLic('http://example.com', self.git_path, SCANCODE_CLI_PATH, self.worktree_path,
+                   in_paths=['perceval/backends/core/github.py'])
+        commits = [commit for commit in cl.fetch(category=CATEGORY_COLIC_SCANCODE_CLI)]
+
+        self.assertEqual(len(commits), 1)
+        self.assertFalse(os.path.exists(cl.worktreepath))
+
+        for commit in commits:
+            self.assertEqual(commit['backend_name'], 'CoLic')
+            self.assertEqual(commit['category'], CATEGORY_COLIC_SCANCODE_CLI)
+            self.assertEqual(commit['data']['analysis']['files'][0]['file_path'],
+                             'perceval/backends/core/github.py')
+            self.assertTrue('Author' in commit['data'])
+            self.assertTrue('Commit' in commit['data'])
+            self.assertFalse('files' in commit['data'])
+            self.assertFalse('parents' in commit['data'])
+            self.assertFalse('refs' in commit['data'])
+
     def test_metadata_category(self):
         """Test metadata_category"""
 
@@ -186,6 +209,18 @@ def test_metadata_category(self):
         }
         self.assertEqual(CoLic.metadata_category(item), CATEGORY_COLIC_NOMOS)
 
+        item = {
+            "Author": "Valerio Cosentino <[email protected]>",
+            "AuthorDate": "Fri May 18 18:26:48 2018 +0200",
+            "Commit": "Valerio Cosentino <[email protected]>",
+            "CommitDate": "Fri May 18 18:26:48 2018 +0200",
+            "analysis": [],
+            "analyzer": "scancode_cli",
+            "commit": "075f0c6161db5a3b1c8eca45e08b88469bb148b9",
+            "message": "[perceval] first commit"
+        }
+        self.assertEqual(CoLic.metadata_category(item), CATEGORY_COLIC_SCANCODE_CLI)
+
         item = {
             "Author": "Valerio Cosentino <[email protected]>",
             "AuthorDate": "Fri May 18 18:26:48 2018 +0200",
@@ -218,6 +253,10 @@ def test_init(self):
         self.assertIsInstance(license_analyzer, LicenseAnalyzer)
         self.assertIsInstance(license_analyzer.analyzer, ScanCode)
 
+        license_analyzer = LicenseAnalyzer(SCANCODE_CLI_PATH, SCANCODE_CLI)
+        self.assertIsInstance(license_analyzer, LicenseAnalyzer)
+        self.assertIsInstance(license_analyzer.analyzer, ScanCode)
+
         with self.assertRaises(GraalError):
             _ = LicenseAnalyzer("/tmp/analyzer", SCANCODE)
 
@@ -236,6 +275,12 @@ def test_analyze(self):
 
         self.assertIn('licenses', analysis)
 
+        file_paths = [os.path.join(self.tmp_data_path, ANALYZER_TEST_FILE)]
+        license_analyzer = LicenseAnalyzer(SCANCODE_CLI_PATH, kind=SCANCODE_CLI)
+        analysis = license_analyzer.analyze(file_paths)
+
+        self.assertIn('licenses', analysis)
+
 
 class TestCoLicCommand(unittest.TestCase):
     """CoLicCommand tests"""

tests/test_scancode.py

@@ -31,7 +31,7 @@
 
 from graal.backends.core.analyzers.scancode import ScanCode
 from graal.graal import GraalError
-from utils import SCANCODE_PATH
+from utils import SCANCODE_PATH, SCANCODE_CLI_PATH
 
 
 class TestScanCode(TestCaseAnalyzer):
@@ -43,18 +43,30 @@ def test_init(self):
         scancode = ScanCode(exec_path=SCANCODE_PATH)
         self.assertEqual(scancode.exec_path, SCANCODE_PATH)
 
+        scancode_cli = ScanCode(exec_path=SCANCODE_CLI_PATH)
+        self.assertEqual(scancode_cli.exec_path, SCANCODE_CLI_PATH)
+
         with self.assertRaises(GraalError):
             _ = ScanCode("/tmp/invalid")
 
-    def test_analyze(self):
-        """Test whether nomos returns the expected fields data"""
+    def test_analyze_scancode(self):
+        """Test whether scancode returns the expected fields data"""
 
         scancode = ScanCode(exec_path=SCANCODE_PATH)
         kwargs = {'file_path': os.path.join(self.tmp_data_path, ANALYZER_TEST_FILE)}
         result = scancode.analyze(**kwargs)
 
         self.assertIn('licenses', result)
 
+    def test_analyze_scancode_cli(self):
+        """Test whether scancode_cli returns the expected fields data"""
+
+        scancode_cli = ScanCode(exec_path=SCANCODE_CLI_PATH, cli=True)
+        kwargs = {'file_paths': [os.path.join(self.tmp_data_path, ANALYZER_TEST_FILE)]}
+        result = scancode_cli.analyze(**kwargs)
+
+        self.assertIn('licenses', result)
+
     @unittest.mock.patch('subprocess.check_output')
     def test_analyze_error(self, check_output_mock):
         """Test whether an exception is thrown in case of errors"""

tests/utils.py

@@ -22,4 +22,5 @@
 #
 
 NOMOS_PATH = "/home/travis/build/chaoss/grimoirelab-graal/exec/fossology/src/nomos/agent/nomossa"
-SCANCODE_PATH = "/home/travis/build/chaoss/grimoirelab-graal/exec/scancode-toolkit-3.0.0/scancode"
+SCANCODE_PATH = "/home/travis/build/chaoss/grimoirelab-graal/exec/scancode-toolkit/scancode"
+SCANCODE_CLI_PATH = "/home/travis/build/chaoss/grimoirelab-graal/exec/scancode-toolkit/etc/scripts/scancli.py"