Skip to content

Commit cc5b412

Browse files
committed
[MERGE #4815 @jackhorton] Add default version of ICU to download helper
Merge pull request #4815 from jackhorton:icu/default-version Since 61 isn't out yet, might as well make the latest possible version be the default. This is to support the [ChakraFull PR](https://devdiv.visualstudio.com/DevDiv/Chakra/_git/Chakra/pullrequest/110890?_a=overview) for creating a NuGet package containing the modified DLLs from ChakraICU=shared for running Full tests downlevel.
2 parents fa4afc8 + f023d68 commit cc5b412

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tools/configure_icu.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ def extract_icu(icuroot, archive_path):
203203
if os.path.isdir(icu_folder):
204204
shutil.rmtree(icu_folder)
205205

206+
print("Extraction successful, ICU will be located at %s" % icu_folder)
206207
shutil.move(os.path.join(tempdir, "icu"), icu_folder)
207208
shutil.rmtree(tempdir)
208209

@@ -211,7 +212,7 @@ def main():
211212

212213
argparser = ArgumentParser(description = "Download and set up ICU for use in ChakraCore")
213214
argparser.add_argument("-y", "--yes", action = "store_true", help = "Skip ICU License prompt text")
214-
argparser.add_argument("version", help = "ICU version to download. Not compatible with --archive")
215+
argparser.add_argument("version", help = "ICU version to download. Not compatible with --archive", default = "60.2", nargs = "?")
215216
argparser.add_argument("-i", "--icu-root",
216217
help = "Path to directory to extract ICU to. Resulting directory will contain a single subfolder, 'icu', which contains ICU's source tree",
217218
default = chakra_icu_root

0 commit comments

Comments
 (0)