Devtools Client - Extract IDevToolsClient interface for testability

Improve xml doc comments

Author: amaitland

CefSharp.Test/DevTools/DevToolsClientFacts.cs

@@ -65,5 +65,28 @@ public async Task CanGetDevToolsProtocolVersion()
                 }
             }
         }
+
+        [Fact]
+        public async Task CanGetDevToolsProtocolGetWindowForTarget()
+        {
+            using (var browser = new ChromiumWebBrowser("www.google.com"))
+            {
+                await browser.LoadPageAsync();
+
+                using (var devToolsClient = browser.GetDevToolsClient())
+                {
+                    var response = await devToolsClient.Browser.GetWindowForTargetAsync();
+                    var windowId = response.WindowId;
+                    var bounds = response.Bounds;
+
+                    Assert.NotEqual(0, windowId);
+                    Assert.NotNull(bounds);
+                    Assert.True(bounds.Height > 0);
+                    Assert.True(bounds.Width > 0);
+                    Assert.True(bounds.WindowState.HasValue);
+                }
+            }
+        }
+
     }
 }

CefSharp/CefSharp.csproj

@@ -330,6 +330,7 @@
     <Compile Include="DevTools\HeapProfiler\SamplingHeapProfileNode.cs" />
     <Compile Include="DevTools\HeapProfiler\SamplingHeapProfileSample.cs" />
     <Compile Include="DevTools\HeapProfiler\StopSamplingResponse.cs" />
+    <Compile Include="DevTools\IDevToolsClient.cs" />
     <Compile Include="DevTools\IndexedDB\DatabaseWithObjectStores.cs" />
     <Compile Include="DevTools\IndexedDB\DataEntry.cs" />
     <Compile Include="DevTools\IndexedDB\GetMetadataResponse.cs" />

CefSharp/DevTools/Accessibility/Accessibility.cs

@@ -10,12 +10,12 @@ namespace CefSharp.DevTools.Accessibility
     /// </summary>
     public partial class Accessibility : DevToolsDomainBase
     {
-        public Accessibility(CefSharp.DevTools.DevToolsClient client)
+        public Accessibility(CefSharp.DevTools.IDevToolsClient client)
         {
             _client = (client);
         }
 
-        private CefSharp.DevTools.DevToolsClient _client;
+        private CefSharp.DevTools.IDevToolsClient _client;
         /// <summary>
         /// Disables the accessibility domain.
         /// </summary>
@@ -28,6 +28,8 @@ public async System.Threading.Tasks.Task<DevToolsMethodResponse> DisableAsync()
 
         /// <summary>
         /// Enables the accessibility domain which causes `AXNodeId`s to remain consistent between method calls.
+        /// This turns on accessibility for the page, which can impact performance until accessibility is disabled.
+        /// </summary>
         public async System.Threading.Tasks.Task<DevToolsMethodResponse> EnableAsync()
         {
             System.Collections.Generic.Dictionary<string, object> dict = null;

CefSharp/DevTools/Accessibility/Enums/AXPropertyName.cs

@@ -5,6 +5,12 @@ namespace CefSharp.DevTools.Accessibility
 {
     /// <summary>
     /// Values of AXProperty name:
+    /// - from 'busy' to 'roledescription': states which apply to every AX node
+    /// - from 'live' to 'root': attributes which apply to nodes in live regions
+    /// - from 'autocomplete' to 'valuetext': attributes which apply to widgets
+    /// - from 'checked' to 'selected': states which apply to widgets
+    /// - from 'activedescendant' to 'owns' - relationships between elements other than parent/child/sibling.
+    /// </summary>
     public enum AXPropertyName
     {
         /// <summary>

CefSharp/DevTools/Accessibility/GetPartialAXTreeResponse.cs

@@ -17,7 +17,8 @@ internal System.Collections.Generic.IList<CefSharp.DevTools.Accessibility.AXNode
         }
 
         /// <summary>
-        /// The `Accessibility.AXNode` for this DOM node, if it exists, plus its ancestors, siblings and
+        /// nodes
+        /// </summary>
         public System.Collections.Generic.IList<CefSharp.DevTools.Accessibility.AXNode> Nodes
         {
             get

CefSharp/DevTools/Animation/Animation.cs

@@ -10,12 +10,12 @@ namespace CefSharp.DevTools.Animation
     /// </summary>
     public partial class Animation : DevToolsDomainBase
     {
-        public Animation(CefSharp.DevTools.DevToolsClient client)
+        public Animation(CefSharp.DevTools.IDevToolsClient client)
         {
             _client = (client);
         }
 
-        private CefSharp.DevTools.DevToolsClient _client;
+        private CefSharp.DevTools.IDevToolsClient _client;
         /// <summary>
         /// Disables animation domain notifications.
         /// </summary>

CefSharp/DevTools/Animation/GetCurrentTimeResponse.cs

@@ -17,7 +17,7 @@ internal long currentTime
         }
 
         /// <summary>
-        /// Current time of the page.
+        /// currentTime
         /// </summary>
         public long CurrentTime
         {

CefSharp/DevTools/Animation/GetPlaybackRateResponse.cs

@@ -17,7 +17,7 @@ internal long playbackRate
         }
 
         /// <summary>
-        /// Playback rate for animations on page.
+        /// playbackRate
         /// </summary>
         public long PlaybackRate
         {

CefSharp/DevTools/Animation/ResolveAnimationResponse.cs

@@ -17,7 +17,7 @@ internal CefSharp.DevTools.Runtime.RemoteObject remoteObject
         }
 
         /// <summary>
-        /// Corresponding remote object.
+        /// remoteObject
         /// </summary>
         public CefSharp.DevTools.Runtime.RemoteObject RemoteObject
         {

CefSharp/DevTools/ApplicationCache/ApplicationCache.cs

@@ -10,12 +10,12 @@ namespace CefSharp.DevTools.ApplicationCache
     /// </summary>
     public partial class ApplicationCache : DevToolsDomainBase
     {
-        public ApplicationCache(CefSharp.DevTools.DevToolsClient client)
+        public ApplicationCache(CefSharp.DevTools.IDevToolsClient client)
         {
             _client = (client);
         }
 
-        private CefSharp.DevTools.DevToolsClient _client;
+        private CefSharp.DevTools.IDevToolsClient _client;
         /// <summary>
         /// Enables application cache domain notifications.
         /// </summary>
@@ -39,6 +39,8 @@ public async System.Threading.Tasks.Task<GetApplicationCacheForFrameResponse> Ge
 
         /// <summary>
         /// Returns array of frame identifiers with manifest urls for each frame containing a document
+        /// associated with some application cache.
+        /// </summary>
         public async System.Threading.Tasks.Task<GetFramesWithManifestsResponse> GetFramesWithManifestsAsync()
         {
             System.Collections.Generic.Dictionary<string, object> dict = null;