fix(menu): don't prevent setting the text color of an item - #513
Merged
ceccopierangiolieugenio merged 1 commit intoNov 8, 2025
Merged
Conversation
Owner
|
This is a tricky thing, Thanks |
ceccopierangiolieugenio
merged commit Nov 8, 2025
370684e
into
ceccopierangiolieugenio:main
11 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TTkStringif it contained differenttextbut not only a differentcolor. This check is not required sincesetText()has to be called explicitly so setting a newtextvalue is always wanted in any case.For instance, you might want to make the existing text of a menu item bold or colored or blinking or whatever without actually changing what the string says, but the comparison check was done on the only the raw
strvalue such as is returned by the TTkString constructor preventing such formatting changes from being made to the property.