CI: update Go SDK versions and use Go 1.24 for tests of Go coverage support (pantsbuild#22810)

Update the Go SDK versions available in CI to v1.25.3 and v1.24.9 from
v1.19.x.

Since Pants does not support the Go "coverage redesign" which became the
only coverage implementation in Go 1.25, the coverage tests in
`src/python/pants/backend/go/util_rules/coverage_test.py` are now
conditioned on Go 1.24 being available on the system. (Those tests are
skipped otherwise.)

There are some other test fixes as well due to the upgrade from Go 1.19
to Go 1.25.

Author: tdyas

.github/workflows/public_repos.yaml

@@ -1073,7 +1073,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - name: Pants on
       run: |2
 

.github/workflows/release.yaml

@@ -165,7 +165,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - env:
         HONEYCOMB_API_KEY: ${{ secrets.HONEYCOMB_API_KEY || '--DISABLED--' }}
         PANTS_PROCESS_EXECUTION_LOCAL_PARALLELISM: '1'
@@ -290,7 +294,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - env:
         ARCHFLAGS: -arch x86_64
         HONEYCOMB_API_KEY: ${{ secrets.HONEYCOMB_API_KEY || '--DISABLED--' }}
@@ -410,7 +418,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - env:
         ARCHFLAGS: -arch arm64
         HONEYCOMB_API_KEY: ${{ secrets.HONEYCOMB_API_KEY || '--DISABLED--' }}

.github/workflows/test.yaml

@@ -519,7 +519,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - env:
         HONEYCOMB_API_KEY: ${{ secrets.HONEYCOMB_API_KEY || '--DISABLED--' }}
         PANTS_PROCESS_EXECUTION_LOCAL_PARALLELISM: '1'
@@ -592,7 +596,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - env:
         ARCHFLAGS: -arch x86_64
         HONEYCOMB_API_KEY: ${{ secrets.HONEYCOMB_API_KEY || '--DISABLED--' }}
@@ -675,7 +683,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - env:
         ARCHFLAGS: -arch arm64
         HONEYCOMB_API_KEY: ${{ secrets.HONEYCOMB_API_KEY || '--DISABLED--' }}
@@ -977,7 +989,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - name: Download native binaries
       uses: actions/download-artifact@v4
       with:
@@ -1071,7 +1087,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1183,7 +1203,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1295,7 +1319,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1407,7 +1435,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1519,7 +1551,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1631,7 +1667,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1743,7 +1783,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1855,7 +1899,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -1967,7 +2015,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -2079,7 +2131,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - if: runner.os == 'Linux'
       name: Download Apache `thrift` binary (Linux)
       run: |
@@ -2168,7 +2224,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - name: Download native binaries
       uses: actions/download-artifact@v4
       with:
@@ -2238,7 +2298,11 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: 1.19.5
+        go-version: 1.25.3
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24.9
     - name: Set up Python 3.9, 3.10, 3.12, 3.13, 3.11
       uses: actions/setup-python@v5
       with:

src/python/pants/backend/go/conftest.py

@@ -19,6 +19,122 @@ def _go_present() -> bool:
     return True
 
 
+def _parse_go_version(version_string: str) -> tuple[int, int] | None:
+    """Parse 'go1.24.3' output to (1, 24)."""
+    if not version_string.startswith("go"):
+        return None
+
+    # Strip "go" prefix and split on "."
+    version_parts = version_string[2:].split(".")
+
+    if len(version_parts) < 2:
+        return None
+
+    try:
+        major = int(version_parts[0])
+        minor = int(version_parts[1])
+        return (major, minor)
+    except (ValueError, IndexError):
+        return None
+
+
+@lru_cache(None)
+def _discover_go_binaries() -> list[tuple[str, tuple[int, int]]]:
+    """Discover all Go binaries in PATH and return sorted by version (newest first)."""
+    path_env = os.getenv("PATH", "")
+    if not path_env:
+        return []
+
+    go_binaries = []
+    seen_paths = set()
+
+    for path_dir in path_env.split(os.pathsep):
+        if not path_dir or not os.path.isdir(path_dir):
+            continue
+
+        go_binary = os.path.join(path_dir, "go")
+        if os.path.isfile(go_binary) and os.access(go_binary, os.X_OK):
+            # Resolve symlinks to avoid duplicates.
+            real_path = os.path.realpath(go_binary)
+            if real_path in seen_paths:
+                continue
+            seen_paths.add(real_path)
+
+            try:
+                result = subprocess.run(
+                    [go_binary, "env", "GOVERSION"],
+                    capture_output=True,
+                    text=True,
+                    timeout=5,
+                    check=False,
+                )
+                if result.returncode == 0:
+                    version = _parse_go_version(result.stdout.strip())
+                    if version:
+                        go_binaries.append((go_binary, version))
+            except (subprocess.TimeoutExpired, FileNotFoundError, PermissionError):
+                continue
+
+    # Sort by version (newest first).
+    go_binaries.sort(key=lambda x: x[1], reverse=True)
+    return go_binaries
+
+
+def pytest_generate_tests(metafunc):
+    """Parametrize tests that require specific Go versions."""
+    # Check if the test has the require_go_version_max marker.
+    marker = metafunc.definition.get_closest_marker("require_go_version_max")
+    if not marker:
+        return
+
+    # Extract the maximum version from the marker.
+    if len(marker.args) < 2:
+        pytest.fail(
+            f"require_go_version_max marker requires 2 args (major, minor), got {marker.args}"
+        )
+        return
+
+    max_major, max_minor = marker.args[0], marker.args[1]
+    max_version = (max_major, max_minor)
+
+    # Discover available Go binaries
+    available_go = _discover_go_binaries()
+
+    # Filter for compatible versions (<= max_version)
+    compatible_go = [(path, version) for path, version in available_go if version <= max_version]
+
+    # Parametrize the test if it accepts a `go_binary_path` fixture.
+    if "go_binary_path" in metafunc.fixturenames:
+        if compatible_go:
+            # Use the newest compatible version.
+            best_go_path, best_version = compatible_go[0]
+            metafunc.parametrize(
+                "go_binary_path",
+                [best_go_path],
+                ids=[f"go{best_version[0]}.{best_version[1]}"],
+            )
+        else:
+            # Parametrize with None and mark to skip, so the test shows as skipped rather than uncollected.
+            available_versions = [f"{v[0]}.{v[1]}" for _, v in available_go]
+            skip_msg = (
+                f"Test requires Go <= {max_major}.{max_minor}, but only found: "
+                f"{', '.join(available_versions) if available_versions else 'none'}"
+            )
+            metafunc.parametrize(
+                "go_binary_path",
+                [pytest.param(None, marks=pytest.mark.skip(reason=skip_msg))],
+                ids=["no-compatible-go"],
+            )
+
+
+def pytest_configure(config):
+    """Register custom markers."""
+    config.addinivalue_line(
+        "markers",
+        "require_go_version_max(major, minor): mark test to require Go version <= specified",
+    )
+
+
 def pytest_runtest_setup(item: pytest.Item) -> None:
     if not _go_present():
         pytest.skip(reason="`go` not present on PATH")

src/python/pants/backend/go/lint/vet/rules_integration_test.py

@@ -133,8 +133,8 @@ def _check_err_msg(result_stderr: str) -> None:
     # Note: `go vet` sometimes emits "fmt.Printf" and sometimes just "Printf", depending on conditions
     # which are unclear so let the `fmt.` part be optional.
     assert re.search(
-        r"./f.go:4:5: (fmt\.)?Printf format %s reads arg #1, but call has 0 args", result_stderr
-    )
+        r"./f.go.*Printf format %s reads arg #1, but call has 0 args", result_stderr
+    ), f"Expected vet to find an issue:\n\nstderr:\n{result_stderr}"
 
 
 def test_failing(rule_runner: RuleRunner) -> None: