[TO-245] Handle Juju Crashdump Artifact in Spread (#491)

* Create crashdump on errors

* Deliberately break integration task

* Sanitize artifact paths

* Run path sanitization on failure

* Move charmcraft log upload to charm job

* Revert deliberately breaking integration test

Author: wctaylor

.github/workflows/charm_integration_test.yml

@@ -76,6 +76,13 @@ jobs:
           name: ${{ matrix.charm }}-charm
           path: "${{ matrix.charm }}/charm/*.charm"
 
+      - name: Upload charmcraft logs
+        if: failure()
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
+        with:
+          name: charmcraft-logs-spread-integration
+          path: /home/ubuntu/.local/state/charmcraft/log/*
+
   integration-test:
     name: Spread Integration Test
     runs-on: ubuntu-24.04
@@ -111,21 +118,25 @@ jobs:
       - name: Install spread
         run: |
           go install github.com/snapcore/spread/cmd/spread@latest
-  
+
       - name: Run integration tests
         run: |
           spread -v -artifacts=./artifacts localhost
 
-      - name: Upload charmcraft logs
+      - name: Sanitize Artifacts Paths
         if: failure()
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
-        with:
-          name: charmcraft-logs-spread-integration
-          path: /home/ubuntu/.local/state/charmcraft/log/*
+        run: |
+          # When using spread -artifacts=<path/to/artifacts>,
+          # artifacts are generated with paths in the form <backend>:<system>:<suite>/task/artifact
+          # The upload-artifact action does not allow ':' in paths, so we need to sanitize them
+          for ARTIFACT_PATH in $(ls -1 ./artifacts/); do
+            SANITIZED_PATH=$(echo "${ARTIFACT_PATH}" | tr ':' '-')
+            mv "artifacts/${ARTIFACT_PATH}" "artifacts/${SANITIZED_PATH}"
+          done
       
       - name: Upload spread artifacts
         if: failure()
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
         with:
           name: spread-artifacts
-          path: ./artifacts
+          path: ./artifacts/

spread.yaml

@@ -119,6 +119,7 @@ exclude:
   - .venv
 
 environment:
+  CI: "$(HOST: echo $CI)"
   CONCIERGE_JUJU_CHANNEL: 3.6/stable
 
 prepare: |

spread/integration/task.yaml

@@ -22,11 +22,19 @@ execute: |
     --resource frontend-image="${frontend_oci_image}"
   juju relate backend frontend
 
-  juju wait-for application backend --timeout=5m
-  juju show-status-log backend/0
+  if ! juju wait-for application backend --timeout=5m; then
+    microk8s config > kube-config
+    pipx run --spec git+https://github.com/canonical/juju-k8s-crashdump.git juju-k8s-crashdump \
+      ./kube-config concierge-microk8s -o juju-k8s-crashdump.tar.gz
+    exit 1
+  fi
 
-  juju wait-for application frontend --timeout=5m
-  juju show-status-log frontend/0
+  if ! juju wait-for application frontend --timeout=5m; then
+    microk8s config > kube-config
+    pipx run --spec git+https://github.com/canonical/juju-k8s-crashdump.git juju-k8s-crashdump \
+      ./kube-config concierge-microk8s -o juju-k8s-crashdump.tar.gz
+    exit 1
+  fi
 
   juju run backend/leader add-user launchpad-email=solutions-qa@lists.canonical.com
 
@@ -38,11 +46,8 @@ execute: |
     "PGPASSWORD=$PGPASSWORD PGHOST=$PGHOST PGUSER=$PGUSER PGDATABASE=$PGDATABASE psql -c \"select launchpad_handle from app_user where email='solutions-qa@lists.canonical.com'\"" \
     | grep oil-ci-bot
 
-  microk8s config > kube-config
-  pipx run --spec git+https://github.com/canonical/juju-k8s-crashdump.git juju-k8s-crashdump ./kube-config concierge-microk8s -o integration-juju-k8s-crashdump.tar.gz
-
 artifacts:
-  - integration-juju-k8s-crashdump.tar.gz
+  - juju-k8s-crashdump.tar.gz
 
 restore: |
   if [[ -z "${CI:-}" ]]; then