Commit ae3bbaa
committed
clippy: tracing: allow needless_borrow on
tracing-attributes 0.1.23 ships with a smarter `Span::record` that
allows owned values [^1], which makes
This means that previously invalid code such as:
span.record("num_updates", num_items);
Is now valid, which makes clippy throw a warning for needless_borrow
Fixing the lint, however, means that foca would require a strict version
check for tracing-attributes (otherwise anything pulling 0.1.22 or
bellow would not compile anymore).
I don't want a strict dependency on tracing: it's tangential do foca and
I'd like users to benefit from the improvements that might be shipped
along, so I fix the lint warning by ignoring it instead.
Once we get a (at least minor) version bump on `tracing`, this can be
removed and updated to skip the borrow.
[^1]: tokio-rs/tracing#2212record
1 parent 202c8c6 commit ae3bbaa
1 file changed
+3
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1152 | 1152 | | |
1153 | 1153 | | |
1154 | 1154 | | |
| 1155 | + | |
1155 | 1156 | | |
1156 | 1157 | | |
1157 | 1158 | | |
| |||
1168 | 1169 | | |
1169 | 1170 | | |
1170 | 1171 | | |
| 1172 | + | |
1171 | 1173 | | |
1172 | 1174 | | |
1173 | 1175 | | |
1174 | 1176 | | |
1175 | 1177 | | |
| 1178 | + | |
1176 | 1179 | | |
1177 | 1180 | | |
1178 | 1181 | | |
| |||
0 commit comments