Remove unused config variable

Author: bubelov

app/src/main/kotlin/org/vestifeed/db/table/ConfTable.kt

@@ -21,8 +21,7 @@ class ConfTable(private val conn: SQLiteConnection) {
                 sync_in_background INTEGER NOT NULL,
                 background_sync_interval_millis INTEGER NOT NULL,
                 use_built_in_browser INTEGER NOT NULL,
-                show_preview_text INTEGER NOT NULL,
-                synced_on_startup INTEGER NOT NULL
+                show_preview_text INTEGER NOT NULL
             ) STRICT;
         """
 
@@ -38,7 +37,6 @@ class ConfTable(private val conn: SQLiteConnection) {
             backgroundSyncIntervalMillis = 10800000L,
             useBuiltInBrowser = true,
             showPreviewText = true,
-            syncedOnStartup = false,
         )
     }
 
@@ -64,7 +62,6 @@ class ConfTable(private val conn: SQLiteConnection) {
         val backgroundSyncIntervalMillis: Long,
         val useBuiltInBrowser: Boolean,
         val showPreviewText: Boolean,
-        val syncedOnStartup: Boolean,
     )
 
     fun SQLiteStatement.toConf(): Conf = Conf(
@@ -79,14 +76,13 @@ class ConfTable(private val conn: SQLiteConnection) {
         backgroundSyncIntervalMillis = getLong(8),
         useBuiltInBrowser = getInt(9) == 1,
         showPreviewText = getInt(10) == 1,
-        syncedOnStartup = getInt(11) == 1,
     )
 
     fun insert(conf: Conf) {
         conn.prepare(
             """
-            INSERT OR REPLACE INTO conf (backend, miniflux_url, miniflux_token, minifluxIncrementalSyncTimestamp, show_preview_images, crop_preview_images, sync_on_startup, sync_in_background, background_sync_interval_millis, use_built_in_browser, show_preview_text, synced_on_startup)
-            VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);
+            INSERT OR REPLACE INTO conf (backend, miniflux_url, miniflux_token, minifluxIncrementalSyncTimestamp, show_preview_images, crop_preview_images, sync_on_startup, sync_in_background, background_sync_interval_millis, use_built_in_browser, show_preview_text)
+            VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);
             """
         ).use { stmt ->
             stmt.bindTextOrNull(1, conf.backend?.name?.lowercase())
@@ -100,15 +96,14 @@ class ConfTable(private val conn: SQLiteConnection) {
             stmt.bindLong(9, conf.backgroundSyncIntervalMillis)
             stmt.bindInt(10, if (conf.useBuiltInBrowser) 1 else 0)
             stmt.bindInt(11, if (conf.showPreviewText) 1 else 0)
-            stmt.bindInt(12, if (conf.syncedOnStartup) 1 else 0)
             stmt.step()
         }
     }
 
     fun select(): Conf {
         conn.prepare(
             """
-            SELECT backend, miniflux_url, miniflux_token, minifluxIncrementalSyncTimestamp, show_preview_images, crop_preview_images, sync_on_startup, sync_in_background, background_sync_interval_millis, use_built_in_browser, show_preview_text, synced_on_startup
+            SELECT backend, miniflux_url, miniflux_token, minifluxIncrementalSyncTimestamp, show_preview_images, crop_preview_images, sync_on_startup, sync_in_background, background_sync_interval_millis, use_built_in_browser, show_preview_text
             FROM conf
             """
         ).use { stmt ->

app/src/main/kotlin/org/vestifeed/navigation/Activity.kt

@@ -46,8 +46,6 @@ class Activity : AppCompatActivity() {
             insets
         }
 
-        db().conf.update { it.copy(syncedOnStartup = false) }
-
         lifecycleScope.launch {
             val conf = db().conf.select()
 

app/src/test/kotlin/org/vestifeed/db/table/ConfTest.kt

@@ -46,7 +46,6 @@ class ConfTest {
         assertEquals(10800000L, defaultConf.backgroundSyncIntervalMillis)
         assertTrue(defaultConf.useBuiltInBrowser)
         assertTrue(defaultConf.showPreviewText)
-        assertFalse(defaultConf.syncedOnStartup)
     }
 
     @Test
@@ -74,7 +73,6 @@ class ConfTest {
         assertEquals(conf.backgroundSyncIntervalMillis, result.backgroundSyncIntervalMillis)
         assertEquals(conf.useBuiltInBrowser, result.useBuiltInBrowser)
         assertEquals(conf.showPreviewText, result.showPreviewText)
-        assertEquals(conf.syncedOnStartup, result.syncedOnStartup)
     }
 
     @Test
@@ -138,7 +136,6 @@ class ConfTest {
         backgroundSyncIntervalMillis: Long = 3600000L,
         useBuiltInBrowser: Boolean = false,
         showPreviewText: Boolean = false,
-        syncedOnStartup: Boolean = true,
     ) = ConfTable.Conf(
         backend = backend,
         minifluxUrl = minifluxUrl,
@@ -151,6 +148,5 @@ class ConfTest {
         backgroundSyncIntervalMillis = backgroundSyncIntervalMillis,
         useBuiltInBrowser = useBuiltInBrowser,
         showPreviewText = showPreviewText,
-        syncedOnStartup = syncedOnStartup,
     )
 }