Skip to content

Commit 7c2f48f

Browse files
authored
mkfifo: factor get_mode() (#681)
* Function can be written with a single return statement * test1: symbolic mode: perl mkfifo -m a=rw fifo1 * test2: numeric mode: perl mkfifo -m 704 fifo2
1 parent 4fcd7ed commit 7c2f48f

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

bin/mkfifo

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,15 @@ sub get_mode {
7272
my $real_mode;
7373

7474
if ($mode =~ /^0?[0-7]{1,3}$/) {
75-
return $real_mode = oct($mode);
75+
$real_mode = oct $mode;
76+
} else {
77+
$real_mode = sym_perms($mode);
7678
}
77-
$real_mode = sym_perms $mode;
78-
return $real_mode unless $real_mode < 0;
79-
warn "$Program: bad file mode: '$mode'\n";
80-
exit EX_FAILURE;
79+
if ($real_mode < 0) {
80+
warn "$Program: bad file mode: '$mode'\n";
81+
exit EX_FAILURE;
82+
}
83+
return $real_mode;
8184
}
8285

8386
my $mode = defined $opt_m ? get_mode($opt_m) : $default_mode;

0 commit comments

Comments
 (0)