fix: remove unnecessary conversion to string (#911)

wolf31o2 · web-flow · commit f4d340d7ffb7 · 2025-02-27T09:31:27.000-05:00
Signed-off-by: Chris Gianelloni &lt;wolf31o2@blinklabs.io&gt;
diff --git a/cbor/value.go b/cbor/value.go
@@ -238,7 +238,7 @@ func generateAstJsonMap[T map[any]any | Map](v T) ([]byte, error) {
 			keyAstJson,
 			valAstJson,
 		)
-		tmpItems = append(tmpItems, string(tmpJson))
+		tmpItems = append(tmpItems, tmpJson)
 	}
 	// We naively sort the rendered map items to give consistent ordering
 	sort.Strings(tmpItems)

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ func generateAstJsonMap[T map[any]any \| Map](v T) ([]byte, error) {`
`238`	`238`	`keyAstJson,`
`239`	`239`	`valAstJson,`
`240`	`240`	`)`
`241`		`- tmpItems = append(tmpItems, string(tmpJson))`
	`241`	`+ tmpItems = append(tmpItems, tmpJson)`
`242`	`242`	`}`
`243`	`243`	`// We naively sort the rendered map items to give consistent ordering`
`244`	`244`	`sort.Strings(tmpItems)`