feat(components/modals): make dynamicComponentService required in SkyModalService constructor#674
Merged
Blackbaud-ErikaMcVey merged 1 commit intomainfrom Oct 17, 2022
Conversation
Contributor
Author
Collaborator
|
Component Storybooks: Apps: |
…SkyModalService` constructor BREAKING CHANGE: `dynamicComponentService` is now a required parameter of `SkyModalService`. To address this change, provide the `dynamicComponentService` wherever you are constructing the `SkyModalService` or any mocks extending it for unit testing.
Blackbaud-ErikaMcVey
force-pushed
the
require-dynamic-component-service
branch
from
cf1b812 to
27c9daf
Compare
Blackbaud-TrevorBurch
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
dynamicComponentServiceis now a required parameter ofSkyModalService. To address this change, provide thedynamicComponentServicewherever you are constructing theSkyModalServicefor unit testing.