Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bafa3e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 10 targets
Sent with 💌 from NxCloud. |
added 2 commits
September 21, 2022 10:26
…d the aria-expanded property to the combobox role
…ckbaud/skyux into lookup-missing-aria-expanded
Collaborator
|
Component Storybooks: Apps: |
…-missing-aria-expanded
bradenbiz
changed the title
aria-expanded property to the combobox role
…-missing-aria-expanded
bradenbiz
changed the title
aria-expanded property to the combobox rolearia-expanded to true on the combobox role of the sky-autocomplete component
bradenbiz
changed the title
aria-expanded to true on the combobox role of the sky-autocomplete componentaria-expanded to true on the combobox role of the sky-autocomplete component when the dropdown is present
bradenbiz
changed the title
aria-expanded to true on the combobox role of the sky-autocomplete component when the dropdown is presentaria-expanded to true on the autocomplete component when the dropdown is open
Blackbaud-TrevorBurch
requested changes
Sep 22, 2022
libs/components/lookup/src/lib/modules/autocomplete/autocomplete.component.html
Outdated
Show resolved
Hide resolved
added 2 commits
September 22, 2022 14:59
Blackbaud-TrevorBurch
approved these changes
Sep 22, 2022
bradenbiz
added a commit
that referenced
this pull request
Oct 17, 2022
…te component when the dropdown is open (#544) * fix aria-expanded value addition * fix(components/lookup): fix the autocomplete component to properly add the aria-expanded property to the combobox role * remove unnecessary qualifier for aria-expanded Co-authored-by: Braden Bisping <bradennbisping@gmail.com>
bradenbiz
added a commit
that referenced
this pull request
Oct 17, 2022
…te component when the dropdown is open (#544) (#702) * fix aria-expanded value addition * fix(components/lookup): fix the autocomplete component to properly add the aria-expanded property to the combobox role * remove unnecessary qualifier for aria-expanded Co-authored-by: Braden Bisping <bradennbisping@gmail.com> Co-authored-by: Braden Bisping <bradennbisping@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.