Skip to content

fix(components/lists): remove dead-code css around disabled sort items#4341

Merged
Blackbaud-SandhyaRajasabeson merged 1 commit intomainfrom
cleanup-dead-disabled-code
Mar 26, 2026
Merged

fix(components/lists): remove dead-code css around disabled sort items#4341
Blackbaud-SandhyaRajasabeson merged 1 commit intomainfrom
cleanup-dead-disabled-code

Conversation

@Blackbaud-SandhyaRajasabeson
Copy link
Copy Markdown
Contributor

@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson commented Mar 26, 2026

AB#3595137

Summary by CodeRabbit

  • Style
    • Updated disabled state styling for sort items, removing specific visual treatments previously applied to disabled sort components.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fae1c210-f5e1-4671-8c35-cd94dbd5f119

📥 Commits

Reviewing files that changed from the base of the PR and between d60bfeb and f29e7e5.

📒 Files selected for processing (1)
  • libs/components/lists/src/lib/modules/sort/sort-item.component.scss
💤 Files with no reviewable changes (1)
  • libs/components/lists/src/lib/modules/sort/sort-item.component.scss

📝 Walkthrough

Walkthrough

Removed disabled state styling from the sort item component's SCSS file. The deletion eliminates visual overrides for the disabled state, including cursor and appearance modifications, while leaving active and focus styling intact.

Changes

Cohort / File(s) Summary
Disabled State Styling Removal
libs/components/lists/src/lib/modules/sort/sort-item.component.scss
Removed 23 lines of SCSS rules that styled the disabled state of .sky-sort-item, including cursor, background-color, box-shadow, and text-color overrides. Hover, focus, and active state styling for the nested button remains in place.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop and a skip through the style cascade,
Disabled states vanish, the clutter will fade,
Simpler now shines where complexity lay,
One file, one deletion—a cleaner way! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing dead CSS code related to disabled sort items, which matches the changeset that removes 23 lines of disabled styling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup-dead-disabled-code

Comment @coderabbitai help to get the list of available commands and usage tips.

@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson added the risk level (author): 2 This change has a slight chance of introducing a bug label Mar 26, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 26, 2026

View your CI Pipeline Execution ↗ for commit f29e7e5

Command Status Duration Result
nx build code-examples-playground --baseHref=ht... ✅ Succeeded 2m 39s View ↗
nx build playground --baseHref=https://blackbau... ✅ Succeeded 2m 23s View ↗
nx build integration --baseHref=https://blackba... ✅ Succeeded 56s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-26 14:00:49 UTC

@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson merged commit ff9d7f1 into main Mar 26, 2026
79 of 82 checks passed
@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson deleted the cleanup-dead-disabled-code branch March 26, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk level (author): 2 This change has a slight chance of introducing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants