feat(components/filter-bar): extend generics for filter types in filter items

[Blackbaud-CoreyArcher]

No description provided.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit e573b9f

Command	Status	Duration	Result
nx build code-examples-playground --baseHref=ht...	✅ Succeeded	4m 7s	View ↗
nx build playground --baseHref=https://blackbau...	✅ Succeeded	1m 45s	View ↗
nx build integration --baseHref=https://blackba...	✅ Succeeded	12s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-02-02 17:02:24 UTC

[Copilot]

Pull request overview

Extends the filter-bar type model to support strongly-typed filter values by introducing generics across filter item interfaces, modal context/instance types, and lookup async search types.

Changes:

• Added TValue generics (defaulting to unknown) across filter item, modal, and filter value models to preserve backward compatibility while improving type safety.
• Updated filter-item modal and lookup components to propagate typed filter values through the service and modal/selection flows.
• Extended SkyFilterBarService.getFilterValueUpdates to return typed filter-value streams.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-item.ts	Makes SkyFilterItem generic so each filter item can carry a typed filter value.
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-item-modal.ts	Adds TValue to the modal marker interface and wires it into the modal instance type.
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-item-modal-saved-args.ts	Makes saved modal args generic so filterValue is typed.
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-item-modal-instance.ts	Adds TValue to modal instance API and updates save args typing (but currently misses updating context typing).
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-item-modal-context.ts	Adds TValue to modal context so filterValue is strongly typed.
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-item-lookup-search-async-result.ts	Makes lookup async results generic so items are typed.
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-item-lookup-search-async-args.ts	Makes lookup async args generic and types result accordingly.
libs/components/filter-bar/src/lib/modules/filter-bar/models/filter-bar-item.ts	Makes internal filter-bar item representation generic for typed filter values.
libs/components/filter-bar/src/lib/modules/filter-bar/filter-items/filter-item-modal.component.ts	Propagates TValue through modal component typing and service calls (but currently injects modal context with incorrect generic args).
libs/components/filter-bar/src/lib/modules/filter-bar/filter-items/filter-item-lookup.component.ts	Makes lookup component generic and propagates typed value updates (but output typing doesn’t yet preserve TValue, and there’s a remaining cast that can be avoided).
libs/components/filter-bar/src/lib/modules/filter-bar/filter-bar.service.ts	Adds generic getFilterValueUpdates<TValue>() returning typed filter values (uses a cast due to storage typing).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[blackbaud-sky-build-user]

Storybook preview

Component Storybooks:

• data-manager-storybook
• filter-bar-storybook

Apps:

• code-examples-playground
• integration
• playground

[blackbaud-sky-build-user]

Cherry-pick successful! 🍒 🎉 See #4182