Skip to content

Commit 4fc23b1

Browse files
use defaults for roles
1 parent 2d4ad48 commit 4fc23b1

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

libs/components/tabs/src/lib/modules/tabs/tab-button.component.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ import { SkyTabIndex } from './tab-index';
1919
import { SkyTabsetStyle } from './tabset-style';
2020
import { SkyTabsetService } from './tabset.service';
2121

22+
const DEFAULT_ELEMENT_ROLE = 'tab';
23+
2224
/**
2325
* @internal
2426
*/
@@ -63,9 +65,9 @@ export class SkyTabButtonComponent implements AfterViewInit, OnDestroy {
6365
return this.#_tabStyle;
6466
}
6567

66-
public set tabStyle(style: SkyTabsetStyle) {
68+
public set tabStyle(style: SkyTabsetStyle | undefined) {
6769
this.#_tabStyle = style;
68-
this.elementRole = style === 'tabs' ? 'tab' : undefined;
70+
this.elementRole = style === 'tabs' ? DEFAULT_ELEMENT_ROLE : undefined;
6971
}
7072

7173
@Output()
@@ -86,7 +88,7 @@ export class SkyTabButtonComponent implements AfterViewInit, OnDestroy {
8688
this.#tabsetService = tabsetService;
8789
}
8890

89-
public elementRole: string | undefined = 'tab';
91+
public elementRole: string | undefined = DEFAULT_ELEMENT_ROLE;
9092
public closeBtnTabIndex = '-1';
9193

9294
#_tabStyle: SkyTabsetStyle;

libs/components/tabs/src/lib/modules/tabs/tabset.component.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ import { SkyTabsetStyle } from './tabset-style';
2626
import { SkyTabsetTabIndexesChange } from './tabset-tab-indexes-change';
2727
import { SkyTabsetService } from './tabset.service';
2828

29+
const DEFAULT_ELEMENT_ROLE = 'tablist';
30+
2931
@Component({
3032
selector: 'sky-tabset',
3133
styleUrls: ['./tabset.component.scss'],
@@ -120,7 +122,7 @@ export class SkyTabsetComponent implements AfterViewInit, OnDestroy {
120122
@Input()
121123
public set tabStyle(value: SkyTabsetStyle) {
122124
this._tabStyle = value;
123-
this.elementRole = value === 'tabs' ? 'tablist' : undefined;
125+
this.elementRole = value === 'tabs' ? DEFAULT_ELEMENT_ROLE : undefined;
124126
}
125127

126128
public get tabStyle(): SkyTabsetStyle {
@@ -186,7 +188,7 @@ export class SkyTabsetComponent implements AfterViewInit, OnDestroy {
186188

187189
public tabButtons: TabButtonViewModel[] = [];
188190

189-
public elementRole: string | undefined = 'tablist';
191+
public elementRole: string | undefined = DEFAULT_ELEMENT_ROLE;
190192

191193
private ngUnsubscribe = new Subject<void>();
192194

0 commit comments

Comments
 (0)