Skip to content

Commit 90fd68d

Browse files
David Herrmannairlied
authored andcommitted
drm/udl: fix line iterator in damage handling
The udl damage handler is supposed to render 'height' lines, but its iterator has an obvious typo that makes it miss most lines if the rectangle does not cover 0/0. Fix the damage handler to correctly render all lines. This is a fallout from: commit e375882 Author: Noralf Trønnes <[email protected]> Date: Thu Apr 28 17:18:37 2016 +0200 drm/udl: Use drm_fb_helper deferred_io support Tested-by: poma <[email protected]> Cc: [email protected] # 4.7+ Reviewed-by: Daniel Vetter <[email protected]> Signed-off-by: David Herrmann <[email protected]> Reviewed-by: Eric Engestrom <[email protected]> Signed-off-by: Dave Airlie <[email protected]>
1 parent aaee1d1 commit 90fd68d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/udl/udl_fb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y,
122122
return 0;
123123
cmd = urb->transfer_buffer;
124124

125-
for (i = y; i < height ; i++) {
125+
for (i = y; i < y + height ; i++) {
126126
const int line_offset = fb->base.pitches[0] * i;
127127
const int byte_offset = line_offset + (x * bpp);
128128
const int dev_byte_offset = (fb->base.width * bpp * i) + (x * bpp);

0 commit comments

Comments
 (0)