[PM-13789] add credential manager provider for passwords #4110

Nailik · 2024-10-17T16:16:00Z

🎟️ Tracking

📔 Objective

Currently there is only an implementation to provide or save Fido2 credentials via the CredentialManager.
The objective is to add the possibility to save and create Passwords.

Credential Manager usage: https://developer.android.com/identity/sign-in/credential-manager
Credential Provider to provide Credential Manager: https://developer.android.com/identity/sign-in/credential-provider
Example Project: https://github.com/android/identity-samples/tree/main/CredentialManager

Status

new BitwardenCredentialProviderService to handle incoming credential requests
new CredentialCompletionManager (from Fido2CompletionManager) to handle both passkeys and passwords
Overwrite Password/Username combination confirmation dialogs.

Working on:

Cleanup (formatting, comments etc)
fixing tests / adding tests

Found issues:

showFido2ErrorDialog doesn't always show the correct reason, however to stay consistent the showPaswordErrorDialog also shows always the same issue

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

CLAassistant · 2024-10-17T16:16:06Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Nailik
✅ SaintPatrck
❌ kilian.eller

kilian.eller seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

bitwarden-bot · 2024-10-17T16:16:56Z

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13789

Nailik · 2024-10-21T20:53:46Z

I would like a check/pre-review from the code owners before starting to work on the tests.

Maybe this could be split into multiple smaller PRs as it got already a lot bigger than i thought it would be - and it's also a lot to review

Nailik · 2025-01-17T16:34:00Z

due to a lot of changes in the types it's currently not compiling

however i am not sure if i just waste my time here since i get no response or any info if this feature is planned ...

SaintPatrck · 2025-01-21T15:05:38Z

Hi @Nailik

Apologies for the late response. We've been busy shoring up our native releases. We are interested in consuming these changes and do appreciate you taking the time to submit them.

As you stated, there has been refactoring that conflicts with the changes you submitted. There's potential for more refactoring once Google releases the next version of Credential Manager (1.5.0). I suggest holding this PR until the new CredMan library is available. As soon as time permits we will review and provide feedback.

Nailik · 2025-01-21T15:06:55Z

@SaintPatrck perfect thank you.

Nailik · 2025-03-25T16:50:43Z

androidx.credentials:credentials:1.5.0 was released on 15. Mar so i will resume working on this PR now.
Will take some time

SaintPatrck · 2025-03-26T16:35:25Z

androidx.credentials:1.5.0 introduces breaking changes. I suggest holding off until we have properly refactored to accommodate the changes (see WIP #4919).

Nailik · 2025-03-26T16:42:30Z

thx for letting me know

Nailik · 2025-05-12T16:41:41Z

I am currently rewriting the whole PR.

Currently i am blocked because of an issue with #5101.

SaintPatrck · 2025-05-12T21:10:36Z

Hi @Nailik

I'm glad to see you're still willing to pick this back up! It's very much appreciated. 🫶

You may want to build on #5177 since it includes changes that will make implementing password credentials a little cleaner.

…universal Credential intent and functions

…le password requests

… intent

…nager-provider

Nailik · 2025-06-21T14:34:01Z

Hi @SaintPatrck
i think i added all required UnitTests, i'll start on creating password entries in a separate PR now.

…ider # Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt

…nager-provider

…ider # Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilderImpl.kt # app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/util/CredentialProviderIntentUtils.kt

…ider

SaintPatrck · 2025-07-02T18:42:45Z

Hey @Nailik!

These updates look great. Everything is working as expected. I'm going to push a small commit to fix the build error and make a few formatting tweaks. Once the build checks complete I'll have another team member review the changes for anything I may have overlooked.

Thank you for your patience while we review, and your amazing contributions. 🫶

github-actions · 2025-07-02T18:55:16Z

Checkmarx One – Scan Summary & Details – a3291f8c-701a-4467-a78d-7292c6cb4738

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt: 113	details Method createMockLoginView at line 113 of /app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt sends user in... `ID: MrQdqzaL5PNjNc2DM2qdYgfkqSk%3D` Attack Vector

app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt

- BitwardenCredentialManagerImpl.kt: formatting. - CredentialEntryBuilderExtensions.kt: fix compile error. - CredentialEntryBuilderImpl.kt: use generic login icon for password credntial entry icon to match autofill items and better distinguish from passkeys. - CredentialProviderIntentUtils.kt: invert build version check. - provider.xml: Add public key credential capability so debug builds still handle passkeys. - VaultItemListingViewModel.kt: formatting.

codecov · 2025-07-02T19:55:06Z

Codecov Report

Attention: Patch coverage is 90.94650% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (6454dc1) to head (4e2634b).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...t/feature/itemlisting/VaultItemListingViewModel.kt	86.81%	7 Missing and 5 partials ⚠️
...dentials/manager/BitwardenCredentialManagerImpl.kt	83.87%	0 Missing and 5 partials ⚠️
.../credentials/builder/CredentialEntryBuilderImpl.kt	94.28%	0 Missing and 2 partials ⚠️
...manager/CredentialProviderCompletionManagerImpl.kt	92.00%	0 Missing and 2 partials ⚠️
...en/ui/platform/feature/rootnav/RootNavViewModel.kt	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
+ Coverage   84.02%   84.06%   +0.03%     
==========================================
  Files         698      698              
  Lines       52872    53076     +204     
  Branches     7198     7241      +43     
==========================================
+ Hits        44428    44617     +189     
- Misses       5970     5973       +3     
- Partials     2474     2486      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilderImpl.kt

...c/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt

david-livefront · 2025-07-02T20:48:49Z

...rc/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt

@@ -1450,6 +1466,10 @@ class VaultItemListingViewModel @Inject constructor(
                handleFido2AssertionResultReceive(action)
            }

+            is VaultItemListingsAction.Internal.ProviderGetPasswordCredentialRequestReceive -> {
+                handleProviderGetPasswordCredentialRequestReceive(action)
+            }


Can we get some test coverage on this file.

good point, while writing the tests i found some issues regarding authentication if a credential has reprompt set. i also renamed some functions to show that it is regarding credentials and not only fido2 and updted some texts for the same reason (passkey ... -> credential ..)

...c/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt

…ider

…nager-provider

…tication

Nailik requested review from brian-livefront, david-livefront, dseverns-livefront, ahaisting-livefront and a team as code owners October 17, 2024 16:16

bitwarden-bot changed the title ~~[DRAFT] add credential manager provider for passwords~~ [PM-13789] [DRAFT] add credential manager provider for passwords Oct 17, 2024

bitwarden-bot added the community-pr label Oct 17, 2024

Nailik force-pushed the feature/add-password-credential-manager-provider branch 3 times, most recently from 4aa9f5a to 5a6e528 Compare October 20, 2024 01:03

Nailik changed the title ~~[PM-13789] [DRAFT] add credential manager provider for passwords~~ [PM-13789] add credential manager provider for passwords Oct 22, 2024

djsmith85 linked an issue Nov 11, 2024 that may be closed by this pull request

No Credential Manager Password Prompt #4100

Open

2 tasks

Nailik requested a review from phil-livefront as a code owner January 17, 2025 16:32

kilian.eller added 6 commits May 27, 2025 15:36

add capability TYPE_PASSWORD_CREDENTIAL

c461136

handle BeginCreatePasswordCredentialRequest in CredentialProvider

2b54d9d

rename CredentialProvider Passkey/Fido2 intent and functions to more …

e45a839

…universal Credential intent and functions

remove filter BeginGetPublicKeyCredentialOption in order to also hand…

22b9a59

…le password requests

add feature flag SingleTapPasswordAuthentication

efb4ef7

split intent manager between fido2 credential and password credential…

b1e86cd

… intent

Nailik added 3 commits June 21, 2025 16:12

fix tests

03bf6d1

formatting

2095802

Merge branch 'bitwarden:main' into feature/add-password-credential-ma…

e677568

…nager-provider

Nailik requested a review from SaintPatrck June 21, 2025 14:23

Nailik added 4 commits June 24, 2025 10:20

Merge branch 'main' into feature/add-password-credential-manager-prov…

fd9324e

…ider # Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt

Merge branch 'bitwarden:main' into feature/add-password-credential-ma…

0489fc0

…nager-provider

Merge branch 'main' into feature/add-password-credential-manager-prov…

c27639c

…ider

github-advanced-security bot found potential problems Jul 2, 2025

View reviewed changes

app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt Dismissed Show dismissed Hide dismissed

SaintPatrck force-pushed the feature/add-password-credential-manager-provider branch from e1b13e7 to 02cde31 Compare July 2, 2025 19:27

david-livefront reviewed Jul 2, 2025

View reviewed changes

app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilderImpl.kt Outdated Show resolved Hide resolved

david-livefront reviewed Jul 2, 2025

View reviewed changes

...c/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt Outdated Show resolved Hide resolved

david-livefront reviewed Jul 2, 2025

View reviewed changes

Nailik added 2 commits July 3, 2025 10:32

review changes

2272dcf

review changes

981aa97

david-livefront reviewed Jul 3, 2025

View reviewed changes

...c/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt Outdated Show resolved Hide resolved

SaintPatrck and others added 9 commits July 15, 2025 10:07

Formatting

91ec07f

Merge branch 'main' into feature/add-password-credential-manager-prov…

22bd9cd

…ider

Merge branch 'main' into feature/add-password-credential-manager-prov…

4dfe0b2

…ider

Merge branch 'bitwarden:main' into feature/add-password-credential-ma…

31a44a0

…nager-provider

rename fido 2 verification functions to credential verification

21d8ebc

fix master password prompt and pin prompt for password request authen…

afc8b63

…tication

add new texts

adf599b

fix

ab6b06a

formatting

4e2634b

[PM-13789] add credential manager provider for passwords #4110

Are you sure you want to change the base?

[PM-13789] add credential manager provider for passwords #4110

Conversation

Nailik commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

Status

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

Uh oh!

CLAassistant commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bitwarden-bot commented Oct 17, 2024

Uh oh!

Nailik commented Oct 21, 2024

Uh oh!

Nailik commented Jan 17, 2025

Uh oh!

SaintPatrck commented Jan 21, 2025

Uh oh!

Nailik commented Jan 21, 2025

Uh oh!

Nailik commented Mar 25, 2025

Uh oh!

SaintPatrck commented Mar 26, 2025

Uh oh!

Nailik commented Mar 26, 2025

Uh oh!

Nailik commented May 12, 2025

Uh oh!

SaintPatrck commented May 12, 2025

Uh oh!

Nailik commented Jun 21, 2025

Uh oh!

SaintPatrck commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

david-livefront Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Nailik Jul 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Nailik commented Oct 17, 2024 •

edited

Loading

CLAassistant commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2025 •

edited

Loading

codecov bot commented Jul 2, 2025 •

edited

Loading