From 756f4cdde704cca5193baa8473443186b4ab24cd Mon Sep 17 00:00:00 2001 From: GarmashAlex Date: Thu, 24 Apr 2025 21:07:53 +0300 Subject: [PATCH] Replace network_magic with BIP44 coin_type in ProofOfReserves message --- bip-0127.mediawiki | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/bip-0127.mediawiki b/bip-0127.mediawiki index 87071d8eaf..5f6f2b0198 100644 --- a/bip-0127.mediawiki +++ b/bip-0127.mediawiki @@ -133,11 +133,10 @@ message ProofOfReserves { // additional fields. uint32 version = 1; - // The network magic for the network in which the proofs are valid. - // 0xD9B4BEF9 for mainnet, 0x0709110B for testnet - //TODO consider BIP44 coin type ids instead: - // https://github.com/satoshilabs/slips/blob/master/slip-0044.md - uint32 network_magic = 2; + // The coin type id from SLIP-0044 for the network in which the proofs are valid. + // 0 (0x80000000) for Bitcoin mainnet, 1 (0x80000001) for Testnet (all coins) + // See SLIP-0044 for the full registry: https://github.com/satoshilabs/slips/blob/master/slip-0044.md + uint32 coin_type = 2; // The commitment message for this proof-of-reserves. // This message is global for all the proofs.