fix(grit): correct JSX element slot indices for GritQL patterns

The attributes slot for JSX_SELF_CLOSING_ELEMENT and JSX_OPENING_ELEMENT
was incorrectly mapped to index 2, but should be index 3 (accounting for
the type_arguments slot at index 2).

Changes:
- Fix attributes slot index from 2 to 3 for JSX_SELF_CLOSING_ELEMENT
- Fix attributes slot index from 2 to 3 for JSX_OPENING_ELEMENT
- Add type_arguments slot (index 2) for both element types
- Add name and initializer slots for JSX_ATTRIBUTE

This enables patterns like jsx_self_closing_element(name = "div") to
correctly match JSX elements by their element name.

Author: rriski

.changeset/fix-jsx-slot-indices.md

@@ -0,0 +1,11 @@
+---
+"biome_grit_patterns": patch
+---
+
+Fix incorrect slot indices for JSX elements in GritQL patterns.
+
+The `attributes` slot for `JSX_SELF_CLOSING_ELEMENT` and `JSX_OPENING_ELEMENT` was incorrectly mapped to index 2, but should be index 3 (after `type_arguments` at index 2).
+
+Also adds the missing `type_arguments` slot and adds slots for `JSX_ATTRIBUTE` (`name` and `initializer`).
+
+This enables patterns like `jsx_self_closing_element(name = "div")` to correctly match JSX elements by their name.

crates/biome_grit_patterns/src/grit_target_language/js_target_language.rs

@@ -112,10 +112,10 @@ impl GritTargetLanguageImpl for JsTargetLanguage {
                 ("children", 1),
                 ("closing_element", 2),
             ],
-            JSX_SELF_CLOSING_ELEMENT => &[("name", 1), ("attributes", 2)],
-            JSX_OPENING_ELEMENT => &[("name", 1), ("attributes", 2)],
+            JSX_SELF_CLOSING_ELEMENT => &[("name", 1), ("type_arguments", 2), ("attributes", 3)],
+            JSX_OPENING_ELEMENT => &[("name", 1), ("type_arguments", 2), ("attributes", 3)],
             JSX_CLOSING_ELEMENT => &[("name", 2)],
-            JSX_ATTRIBUTE => &[],
+            JSX_ATTRIBUTE => &[("name", 0), ("initializer", 1)],
             JSX_EXPRESSION_CHILD => &[("expression", 1)],
             JSX_TEXT => &[],
             JSX_NAMESPACE_NAME => &[("namespace", 0), ("name", 2)],

crates/biome_grit_patterns/tests/specs/tsx/jsx_slots.grit

@@ -0,0 +1,9 @@
+engine biome(1.0)
+language js(jsx)
+
+// Test that JSX element slots work correctly
+// Match self-closing and opening elements with name "div"
+or {
+  jsx_self_closing_element(name = "div"),
+  jsx_opening_element(name = "div")
+}

crates/biome_grit_patterns/tests/specs/tsx/jsx_slots.snap

@@ -0,0 +1,14 @@
+---
+source: crates/biome_grit_patterns/tests/spec_tests.rs
+assertion_line: 94
+expression: jsx_slots
+---
+SnapshotResult {
+    messages: [],
+    matched_ranges: [
+        "3:3-3:8",
+        "4:5-4:12",
+    ],
+    rewritten_files: [],
+    created_files: [],
+}

crates/biome_grit_patterns/tests/specs/tsx/jsx_slots.tsx

@@ -0,0 +1,9 @@
+// Test file for JSX slot matching
+const App = () => (
+  <div>
+    <div />
+    <span />
+    <img src="test.png" />
+    <button onClick={() => {}}>Click</button>
+  </div>
+);