fix(formatter): don't insert an empty line before semicolon with leading comments (#6388)

Co-authored-by: Emanuele Stoppa <[email protected]>

Author: siketyan

.changeset/yellow-hornets-lose.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#6375](https://github.com/biomejs/biome/issues/6375): the formatter no longer inserts an extra empty line before a semicolon when it has leading comments.

crates/biome_js_formatter/src/js/statements/expression_statement.rs

@@ -30,7 +30,10 @@ impl FormatNodeRule<JsExpressionStatement> for FormatJsExpressionStatement {
             .prev_sibling()
             .and_then(|sibling| sibling.last_token())
         {
-            if token.kind() == T![;] && get_lines_before_token(&token) > 1 {
+            if token.kind() == T![;]
+                && !token.has_leading_comments()
+                && get_lines_before_token(&token) > 1
+            {
                 write!(f, [empty_line()])?;
             }
         }

crates/biome_js_formatter/tests/specs/js/module/no-semi/issue6375.js

@@ -0,0 +1,7 @@
+const Transport = {}
+const newRequest = {}
+
+/**
+ * SAFETY: monkey patching and getting around the provided type definitions.
+ */
+;(Transport.prototype as any).request = newRequest

crates/biome_js_formatter/tests/specs/js/module/no-semi/issue6375.js.snap

@@ -0,0 +1,79 @@
+---
+source: crates/biome_formatter_test/src/snapshot_builder.rs
+info: js/module/no-semi/issue6375.js
+---
+# Input
+
+```js
+const Transport = {}
+const newRequest = {}
+
+/**
+ * SAFETY: monkey patching and getting around the provided type definitions.
+ */
+;(Transport.prototype as any).request = newRequest
+
+```
+
+
+=============================
+
+# Outputs
+
+## Output 1
+
+-----
+Indent style: Tab
+Indent width: 2
+Line ending: LF
+Line width: 80
+Quote style: Double Quotes
+JSX quote style: Double Quotes
+Quote properties: As needed
+Trailing commas: All
+Semicolons: Always
+Arrow parentheses: Always
+Bracket spacing: true
+Bracket same line: false
+Attribute Position: Auto
+Expand lists: Auto
+-----
+
+```js
+const Transport = {};
+const newRequest = {};
+
+/**
+ * SAFETY: monkey patching and getting around the provided type definitions.
+ */
+(Transport.prototype as any).request = newRequest;
+```
+
+## Output 1
+
+-----
+Indent style: Tab
+Indent width: 2
+Line ending: LF
+Line width: 80
+Quote style: Double Quotes
+JSX quote style: Double Quotes
+Quote properties: As needed
+Trailing commas: All
+Semicolons: As needed
+Arrow parentheses: Always
+Bracket spacing: true
+Bracket same line: false
+Attribute Position: Auto
+Expand lists: Auto
+-----
+
+```js
+const Transport = {}
+const newRequest = {}
+
+/**
+ * SAFETY: monkey patching and getting around the provided type definitions.
+ */
+;(Transport.prototype as any).request = newRequest
+```