refactor(core): use boxcar (#8352)

Author: ematipico

Cargo.lock

@@ -203,6 +203,7 @@ xtask_glue           = { path = "xtask/glue" }
 # Crates needed in the workspace
 anyhow               = "1.0.100"
 boa_engine           = "0.21.0"
+boxcar               = "0.2.14"
 bpaf                 = { version = "0.9.20", features = ["derive"] }
 camino               = "1.2.1"
 cfg-if               = "1.0.4"

Cargo.toml

@@ -14,7 +14,6 @@ version              = "0.0.0"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-append-only-vec         = "0.1.8"
 biome_analyze           = { workspace = true, features = ["serde"] }
 biome_configuration     = { workspace = true }
 biome_console           = { workspace = true }
@@ -61,6 +60,7 @@ biome_resolver          = { workspace = true }
 biome_rowan             = { workspace = true, features = ["serde"] }
 biome_string_case       = { workspace = true }
 biome_text_edit         = { workspace = true }
+boxcar                  = { workspace = true }
 camino                  = { workspace = true }
 crossbeam               = { workspace = true }
 either                  = { workspace = true }

crates/biome_service/Cargo.toml

@@ -16,7 +16,6 @@ use crate::scanner::{
     WorkspaceScannerBridge,
 };
 use crate::workspace::document::{AnyEmbeddedSnippet, DocumentServices};
-use append_only_vec::AppendOnlyVec;
 use biome_analyze::{AnalyzerPluginVec, RuleCategory};
 use biome_configuration::bool::Bool;
 use biome_configuration::max_size::MaxSize;
@@ -72,7 +71,7 @@ pub struct WorkspaceServer {
     documents: HashMap<Utf8PathBuf, Document, FxBuildHasher>,
 
     /// Stores the document sources used across the workspace
-    file_sources: AppendOnlyVec<DocumentFileSource>,
+    file_sources: boxcar::Vec<DocumentFileSource>,
 
     /// Stores patterns to search for.
     patterns: HashMap<PatternId, GritQuery, FxBuildHasher>,
@@ -132,7 +131,7 @@ impl WorkspaceServer {
             module_graph: Default::default(),
             plugin_caches: Default::default(),
             documents: Default::default(),
-            file_sources: AppendOnlyVec::default(),
+            file_sources: boxcar::Vec::default(),
             patterns: Default::default(),
             node_cache: Default::default(),
             scanner: Scanner::new(watcher_tx),
@@ -260,11 +259,7 @@ impl WorkspaceServer {
     ///
     /// File sources can be inserted using `insert_source()`.
     fn get_source(&self, index: usize) -> Option<DocumentFileSource> {
-        if index < self.file_sources.len() {
-            Some(self.file_sources[index])
-        } else {
-            None
-        }
+        self.file_sources.get(index).copied()
     }
 
     /// Inserts a file source so that it can be retrieved by index later.
@@ -274,7 +269,7 @@ impl WorkspaceServer {
     fn insert_source(&self, document_file_source: DocumentFileSource) -> usize {
         self.file_sources
             .iter()
-            .position(|file_source| *file_source == document_file_source)
+            .position(|(_, file_source)| *file_source == document_file_source)
             .unwrap_or_else(|| self.file_sources.push(document_file_source))
     }