feedback

Author: ematipico

crates/biome_html_parser/src/lexer/mod.rs

@@ -428,7 +428,7 @@ impl<'src> HtmlLexer<'src> {
             b"doctype" | b"DOCTYPE" if !context.is_svelte() => DOCTYPE_KW,
             b"html" | b"HTML" if context.is_doctype() => HTML_KW,
             buffer if context.is_svelte() => match buffer {
-                b"debug" => DEBUG_KW,
+                b"debug" if self.current_kind == T!["{@"] => DEBUG_KW,
                 _ => SVELTE_IDENT,
             },
             _ => HTML_LITERAL,

crates/biome_html_parser/src/lexer/tests.rs

@@ -367,9 +367,26 @@ fn svelte_openings() {
 fn svelte_keywords() {
     assert_lex!(
         HtmlLexContext::Svelte,
-        "  debug  ",
+        "{@debug  ",
+        SV_CURLY_AT: 2,
+        DEBUG_KW: 5,
         WHITESPACE: 2,
+    );
+
+    assert_lex!(
+        HtmlLexContext::Svelte,
+        "{@debug debug",
+        SV_CURLY_AT: 2,
         DEBUG_KW: 5,
+        WHITESPACE: 1,
+        SVELTE_IDENT: 5,
+    );
+
+    assert_lex!(
+        HtmlLexContext::Svelte,
+        "  debug  ",
+        WHITESPACE: 2,
+        SVELTE_IDENT: 5,
         WHITESPACE: 2,
     )
 }

crates/biome_html_parser/src/syntax/svelte.rs

@@ -20,7 +20,10 @@ pub(crate) fn parse_svelte_at_block(p: &mut HtmlParser) -> ParsedSyntax {
 
     match p.cur() {
         T![debug] => parse_debug_block(p, m),
-        _ => Absent,
+        _ => {
+            m.abandon(p);
+            Absent
+        }
     }
 }
 pub(crate) fn parse_debug_block(p: &mut HtmlParser, marker: Marker) -> ParsedSyntax {

crates/biome_html_parser/tests/html_specs/error/svelte/debug.svelte

@@ -1,2 +1,3 @@
 {@debug
 {@debug something}
+{@debug debug}

crates/biome_html_parser/tests/html_specs/error/svelte/debug.svelte.snap

@@ -7,6 +7,7 @@ expression: snapshot
 ```svelte
 {@debug
 {@debug something}
+{@debug debug}
 
 ```
 
@@ -35,19 +36,29 @@ HtmlRoot {
             ],
             r_curly_token: R_CURLY@25..26 "}" [] [],
         },
+        SvelteDebugBlock {
+            sv_curly_at_token: SV_CURLY_AT@26..29 "{@" [Newline("\n")] [],
+            debug_token: DEBUG_KW@29..35 "debug" [] [Whitespace(" ")],
+            bindings: SvelteBindingList [
+                SvelteName {
+                    svelte_ident_token: SVELTE_IDENT@35..40 "debug" [] [],
+                },
+            ],
+            r_curly_token: R_CURLY@40..41 "}" [] [],
+        },
     ],
-    eof_token: EOF@26..27 "" [Newline("\n")] [],
+    eof_token: EOF@41..42 "" [Newline("\n")] [],
 }
 ```
 
 ## CST
 
 ```
-0: HTML_ROOT@0..27
+0: HTML_ROOT@0..42
   0: (empty)
   1: (empty)
   2: (empty)
-  3: HTML_ELEMENT_LIST@0..26
+  3: HTML_ELEMENT_LIST@0..41
     0: SVELTE_DEBUG_BLOCK@0..7
       0: SV_CURLY_AT@0..2 "{@" [] []
       1: DEBUG_KW@2..7 "debug" [] []
@@ -60,7 +71,14 @@ HtmlRoot {
         0: SVELTE_NAME@16..25
           0: SVELTE_IDENT@16..25 "something" [] []
       3: R_CURLY@25..26 "}" [] []
-  4: EOF@26..27 "" [Newline("\n")] []
+    2: SVELTE_DEBUG_BLOCK@26..41
+      0: SV_CURLY_AT@26..29 "{@" [Newline("\n")] []
+      1: DEBUG_KW@29..35 "debug" [] [Whitespace(" ")]
+      2: SVELTE_BINDING_LIST@35..40
+        0: SVELTE_NAME@35..40
+          0: SVELTE_IDENT@35..40 "debug" [] []
+      3: R_CURLY@40..41 "}" [] []
+  4: EOF@41..42 "" [Newline("\n")] []
 
 ```
 
@@ -74,6 +92,7 @@ debug.svelte:2:1 parse ━━━━━━━━━━━━━━━━━━━
     1 │ {@debug
   > 2 │ {@debug something}
       │ ^^
-    3 │ 
+    3 │ {@debug debug}
+    4 │ 
   
 ```