feat: added an option to files - maxSize see [#5295](#5295)

Author: vladimir-ivanov

.changeset/open-oranges-sell.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": minor
+---
+
+Addressed [#5295](https://github.com/biomejs/biome/issues/5295): option to allow overrides of files.maxSize

crates/biome_cli/tests/cases/mod.rs

@@ -19,6 +19,7 @@ mod linter_groups_plain;
 mod migrate_v2;
 mod overrides_formatter;
 mod overrides_linter;
+mod overrides_max_file_size;
 mod overrides_organize_imports;
 mod protected_files;
 mod reporter_github;

crates/biome_cli/tests/cases/overrides_max_file_size.rs

@@ -0,0 +1,127 @@
+use crate::run_cli;
+use crate::snap_test::{SnapshotPayload, assert_cli_snapshot};
+use biome_cli::CliDiagnostic;
+use biome_console::BufferConsole;
+use biome_fs::MemoryFileSystem;
+use bpaf::Args;
+use camino::Utf8Path;
+
+const FORMATTED: &str = "statement();\n";
+const TEST_FILE: &str = "test.js";
+const CLI_COMMANDS: [&str; 2] = ["check", "format"];
+
+fn setup_test(
+    includes: &str,
+    max_size: u64,
+    cli_command: &str,
+) -> (MemoryFileSystem, BufferConsole, Result<(), CliDiagnostic>) {
+    assert!(
+        CLI_COMMANDS.contains(&cli_command),
+        "Command must be one of {:?}",
+        CLI_COMMANDS.join(", ")
+    );
+
+    let mut console = BufferConsole::default();
+    let mut fs = MemoryFileSystem::default();
+    let file_path = Utf8Path::new("biome.json");
+
+    fs.insert(
+        file_path.into(),
+        format!(
+            r#"{{
+                "files": {{
+                    "maxSize": 1024
+                 }},
+                "overrides": [
+                    {{
+                        "includes": [
+                            "{}"
+                        ],
+                        "files": {{ "maxSize": {} }}
+                    }}
+                ]
+            }}"#,
+            includes, max_size
+        )
+        .as_bytes(),
+    );
+
+    let test_file = Utf8Path::new(TEST_FILE);
+    fs.insert(test_file.into(), FORMATTED.as_bytes());
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from([cli_command, test_file.as_str()].as_slice()),
+    );
+
+    (fs, console, result)
+}
+
+#[test]
+fn overrides_files_max_size_option_pass() {
+    for cli_command in CLI_COMMANDS {
+        let (fs, console, result) = setup_test(TEST_FILE, 1024, cli_command);
+
+        assert!(result.is_ok(), "run_cli returned {result:?}");
+
+        assert_cli_snapshot(SnapshotPayload::new(
+            module_path!(),
+            "overrides_files_max_size_option_pass",
+            fs,
+            console,
+            result,
+        ));
+    }
+}
+
+#[test]
+fn overrides_files_max_size_option_invalid_value() {
+    for cli_command in CLI_COMMANDS {
+        let (fs, console, result) = setup_test(TEST_FILE, 0, cli_command);
+
+        assert!(result.is_err(), "run_cli returned {result:?}");
+
+        assert_cli_snapshot(SnapshotPayload::new(
+            module_path!(),
+            "overrides_files_max_size_option_invalid_value",
+            fs,
+            console,
+            result,
+        ));
+    }
+}
+
+#[test]
+fn overrides_files_max_size_too_large_limit() {
+    for cli_command in CLI_COMMANDS {
+        let (fs, console, result) = setup_test(TEST_FILE, 1, cli_command);
+
+        assert!(result.is_err(), "run_cli returned {result:?}");
+
+        assert_cli_snapshot(SnapshotPayload::new(
+            module_path!(),
+            format!("overrides_files_max_size_too_large_limit_{}", cli_command).as_str(),
+            fs,
+            console,
+            result,
+        ));
+    }
+}
+
+#[test]
+fn overrides_files_max_size_ignored_includes_does_not_match_filename() {
+    for cli_command in CLI_COMMANDS {
+        let (fs, console, result) = setup_test("invalidFile.js", 1, cli_command);
+
+        assert!(result.is_ok(), "run_cli returned {result:?}");
+
+        assert_cli_snapshot(SnapshotPayload::new(
+            module_path!(),
+            "overrides_files_max_size_ignored_includes_does_not_match_filename",
+            fs,
+            console,
+            result,
+        ));
+    }
+}

crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_ignored_includes_does_not_match_filename.snap

@@ -0,0 +1,33 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+assertion_line: 432
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "files": {
+    "maxSize": 1024
+  },
+  "overrides": [
+    {
+      "includes": ["invalidFile.js"],
+      "files": { "maxSize": 1 }
+    }
+  ]
+}
+```
+
+## `test.js`
+
+```js
+statement();
+
+```
+
+# Emitted Messages
+
+```block
+Checked 1 file in <TIME>. No fixes applied.
+```

crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_option_invalid_value.snap

@@ -0,0 +1,55 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+assertion_line: 432
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "files": {
+    "maxSize": 1024
+  },
+  "overrides": [
+    {
+      "includes": ["test.js"],
+      "files": { "maxSize": 0 }
+    }
+  ]
+}
+```
+
+## `test.js`
+
+```js
+statement();
+
+```
+
+# Termination Message
+
+```block
+configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × Biome exited because the configuration resulted in errors. Please fix them.
+  
+
+
+```
+
+# Emitted Messages
+
+```block
+biome.json:10:47 deserialize ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × The number should be an integer between 1 and 18446744073709551615.
+  
+     8 │                             "test.js"
+     9 │                         ],
+  > 10 │                         "files": { "maxSize": 0 }
+       │                                               ^
+    11 │                     }
+    12 │                 ]
+  
+
+```

crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_option_pass.snap

@@ -0,0 +1,33 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+assertion_line: 432
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "files": {
+    "maxSize": 1024
+  },
+  "overrides": [
+    {
+      "includes": ["test.js"],
+      "files": { "maxSize": 1024 }
+    }
+  ]
+}
+```
+
+## `test.js`
+
+```js
+statement();
+
+```
+
+# Emitted Messages
+
+```block
+Checked 1 file in <TIME>. No fixes applied.
+```

crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_too_large_limit_check.snap

@@ -0,0 +1,59 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+assertion_line: 432
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "files": {
+    "maxSize": 1024
+  },
+  "overrides": [
+    {
+      "includes": ["test.js"],
+      "files": { "maxSize": 1 }
+    }
+  ]
+}
+```
+
+## `test.js`
+
+```js
+statement();
+
+```
+
+# Termination Message
+
+```block
+check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × No files were processed in the specified paths.
+  
+  i Check your biome.json or biome.jsonc to ensure the paths are not ignored by the configuration.
+  
+  i These paths were provided but ignored:
+  
+  - test.js
+  
+
+
+```
+
+# Emitted Messages
+
+```block
+test.js check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i The size of the file is 13 B, which exceeds the configured maximum of 1 B for this project.
+    Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.ignore` to ignore the file.
+  
+
+```
+
+```block
+Checked 0 files in <TIME>. No fixes applied.
+```

crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_too_large_limit_format.snap

@@ -0,0 +1,59 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+assertion_line: 432
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "files": {
+    "maxSize": 1024
+  },
+  "overrides": [
+    {
+      "includes": ["test.js"],
+      "files": { "maxSize": 1 }
+    }
+  ]
+}
+```
+
+## `test.js`
+
+```js
+statement();
+
+```
+
+# Termination Message
+
+```block
+format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × No files were processed in the specified paths.
+  
+  i Check your biome.json or biome.jsonc to ensure the paths are not ignored by the configuration.
+  
+  i These paths were provided but ignored:
+  
+  - test.js
+  
+
+
+```
+
+# Emitted Messages
+
+```block
+test.js format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i The size of the file is 13 B, which exceeds the configured maximum of 1 B for this project.
+    Use the `files.maxSize` configuration to change the maximum size of files processed, or `files.ignore` to ignore the file.
+  
+
+```
+
+```block
+Checked 0 files in <TIME>. No fixes applied.
+```

crates/biome_configuration/src/lib.rs

@@ -57,8 +57,8 @@ pub use html::{HtmlConfiguration, html_configuration};
 pub use javascript::{JsConfiguration, js_configuration};
 pub use json::{JsonConfiguration, json_configuration};
 pub use overrides::{
-    OverrideAssistConfiguration, OverrideFormatterConfiguration, OverrideGlobs,
-    OverrideLinterConfiguration, OverridePattern, Overrides,
+    OverrideAssistConfiguration, OverrideFilesConfiguration, OverrideFormatterConfiguration,
+    OverrideGlobs, OverrideLinterConfiguration, OverridePattern, Overrides,
 };
 use plugins::Plugins;
 use regex::Regex;