fix: feedback

Author: Netail

crates/biome_js_analyze/src/lint/nursery/no_duplicated_spread_props.rs

@@ -45,26 +45,6 @@ declare_node_union! {
         | JsxSelfClosingElement
 }
 
-fn validate_attributes(list: &JsxAttributeList) -> Option<String> {
-    let mut seen_spreads = HashSet::new();
-
-    for attribute in list {
-        if let AnyJsxAttribute::JsxSpreadAttribute(spread) = attribute
-            && let Some(argument) = spread.argument().ok()
-            && let Some(express) = argument.as_js_identifier_expression()
-        {
-            let name = express.name().ok()?;
-            let value_token = name.value_token().ok()?;
-            let text = value_token.text_trimmed().to_string();
-            if !seen_spreads.insert(text.clone()) {
-                return Some(text);
-            }
-        }
-    }
-
-    None
-}
-
 impl Rule for NoDuplicatedSpreadProps {
     type Query = Ast<NoDuplicatedSpreadPropsQuery>;
     type State = String;
@@ -102,3 +82,23 @@ impl Rule for NoDuplicatedSpreadProps {
         )
     }
 }
+
+fn validate_attributes(list: &JsxAttributeList) -> Option<String> {
+    let mut seen_spreads = HashSet::new();
+
+    for attribute in list {
+        if let AnyJsxAttribute::JsxSpreadAttribute(spread) = attribute
+            && let Some(argument) = spread.argument().ok()
+            && let Some(express) = argument.as_js_identifier_expression()
+            && let Some(name) = express.name().ok()
+            && let Some(value_token) = name.value_token().ok()
+        {
+            let text = value_token.text_trimmed().to_string();
+            if !seen_spreads.insert(text.clone()) {
+                return Some(text);
+            }
+        }
+    }
+
+    None
+}

crates/biome_js_analyze/tests/specs/nursery/noDuplicatedSpreadProps/invalid.jsx

@@ -1,7 +1,23 @@
 const Invalid1 = () => {
-	return <div {...props} something="else" {...props} />
+	return <div {...props} something="else" {...props}></div>
 }
 
 const Invalid2 = () => {
+	return <div {...foo.bar} {...props} {...props}></div>
+}
+
+const Invalid3 = () => {
+	return <div {...{}} {...props} {...props}></div>
+}
+
+const Invalid4 = () => {
+	return <div {...props} something="else" {...props} />
+}
+
+const Invalid5 = () => {
 	return <div {...foo.bar} {...props} {...props} />
 }
+
+const Invalid6 = () => {
+	return <div {...{}} {...props} {...props} />
+}

crates/biome_js_analyze/tests/specs/nursery/noDuplicatedSpreadProps/invalid.jsx.snap

@@ -5,13 +5,29 @@ expression: invalid.jsx
 # Input
 ```jsx
 const Invalid1 = () => {
-	return <div {...props} something="else" {...props} />
+	return <div {...props} something="else" {...props}></div>
 }
 
 const Invalid2 = () => {
+	return <div {...foo.bar} {...props} {...props}></div>
+}
+
+const Invalid3 = () => {
+	return <div {...{}} {...props} {...props}></div>
+}
+
+const Invalid4 = () => {
+	return <div {...props} something="else" {...props} />
+}
+
+const Invalid5 = () => {
 	return <div {...foo.bar} {...props} {...props} />
 }
 
+const Invalid6 = () => {
+	return <div {...{}} {...props} {...props} />
+}
+
 ```
 
 # Diagnostics
@@ -21,8 +37,8 @@ invalid.jsx:2:9 lint/nursery/noDuplicatedSpreadProps ━━━━━━━━━
   i The expression props has spread more than once.
   
     1 │ const Invalid1 = () => {
-  > 2 │ 	return <div {...props} something="else" {...props} />
-      │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  > 2 │ 	return <div {...props} something="else" {...props}></div>
+      │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     3 │ }
     4 │ 
   
@@ -37,12 +53,76 @@ invalid.jsx:6:9 lint/nursery/noDuplicatedSpreadProps ━━━━━━━━━
   i The expression props has spread more than once.
   
     5 │ const Invalid2 = () => {
-  > 6 │ 	return <div {...foo.bar} {...props} {...props} />
-      │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  > 6 │ 	return <div {...foo.bar} {...props} {...props}></div>
+      │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     7 │ }
     8 │ 
   
   i Spreading an expression more than once will lead to unnecessary computations being performed. Reduce spreads of this expression down to 1.
   
 
 ```
+
+```
+invalid.jsx:10:9 lint/nursery/noDuplicatedSpreadProps ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i The expression props has spread more than once.
+  
+     9 │ const Invalid3 = () => {
+  > 10 │ 	return <div {...{}} {...props} {...props}></div>
+       │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    11 │ }
+    12 │ 
+  
+  i Spreading an expression more than once will lead to unnecessary computations being performed. Reduce spreads of this expression down to 1.
+  
+
+```
+
+```
+invalid.jsx:14:9 lint/nursery/noDuplicatedSpreadProps ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i The expression props has spread more than once.
+  
+    13 │ const Invalid4 = () => {
+  > 14 │ 	return <div {...props} something="else" {...props} />
+       │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    15 │ }
+    16 │ 
+  
+  i Spreading an expression more than once will lead to unnecessary computations being performed. Reduce spreads of this expression down to 1.
+  
+
+```
+
+```
+invalid.jsx:18:9 lint/nursery/noDuplicatedSpreadProps ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i The expression props has spread more than once.
+  
+    17 │ const Invalid5 = () => {
+  > 18 │ 	return <div {...foo.bar} {...props} {...props} />
+       │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    19 │ }
+    20 │ 
+  
+  i Spreading an expression more than once will lead to unnecessary computations being performed. Reduce spreads of this expression down to 1.
+  
+
+```
+
+```
+invalid.jsx:22:9 lint/nursery/noDuplicatedSpreadProps ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i The expression props has spread more than once.
+  
+    21 │ const Invalid6 = () => {
+  > 22 │ 	return <div {...{}} {...props} {...props} />
+       │ 	       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    23 │ }
+    24 │ 
+  
+  i Spreading an expression more than once will lead to unnecessary computations being performed. Reduce spreads of this expression down to 1.
+  
+
+```

crates/biome_js_analyze/tests/specs/nursery/noDuplicatedSpreadProps/valid.jsx

@@ -1,12 +1,32 @@
 /* should not generate diagnostics */
 const Valid1 = () => {
-	return <div {...props} something="else" />
+	return <div {...props} something="else"></div>
 }
 
 const Valid2 = () => {
-	return <div something="else" {...props} />
+	return <div something="else" {...props}></div>
 }
 
 const Valid3 = () => {
+	return <div {...props} something="else" {...otherProps}></div>
+}
+
+const Valid4 = () => {
+	return <div {...{}} something="else" {...otherProps}></div>
+}
+
+const Valid5 = () => {
+	return <div {...props} something="else" />
+}
+
+const Valid6 = () => {
+	return <div something="else" {...props} />
+}
+
+const Valid7 = () => {
 	return <div {...props} something="else" {...otherProps} />
 }
+
+const Valid8 = () => {
+	return <div {...{}} something="else" {...otherProps} />
+}

crates/biome_js_analyze/tests/specs/nursery/noDuplicatedSpreadProps/valid.jsx.snap

@@ -6,15 +6,35 @@ expression: valid.jsx
 ```jsx
 /* should not generate diagnostics */
 const Valid1 = () => {
-	return <div {...props} something="else" />
+	return <div {...props} something="else"></div>
 }
 
 const Valid2 = () => {
-	return <div something="else" {...props} />
+	return <div something="else" {...props}></div>
 }
 
 const Valid3 = () => {
+	return <div {...props} something="else" {...otherProps}></div>
+}
+
+const Valid4 = () => {
+	return <div {...{}} something="else" {...otherProps}></div>
+}
+
+const Valid5 = () => {
+	return <div {...props} something="else" />
+}
+
+const Valid6 = () => {
+	return <div something="else" {...props} />
+}
+
+const Valid7 = () => {
 	return <div {...props} something="else" {...otherProps} />
 }
 
+const Valid8 = () => {
+	return <div {...{}} something="else" {...otherProps} />
+}
+
 ```