fixes from review from dyc3

Author: tylersayshi

.changeset/brave-scripts-dance.md

@@ -2,46 +2,4 @@
 "@biomejs/biome": patch
 ---
 
-Added the new nursery rule [`useRequiredScripts`](https://biomejs.dev/linter/rules/use-required-scripts/), which enforces the presence of required scripts in `package.json`. This rule is particularly useful in monorepo environments where consistency across workspaces is important.
-
-The rule accepts a `requiredScripts` option to specify which scripts must be present:
-
-```json
-{
-    "linter": {
-        "rules": {
-            "nursery": {
-                "useRequiredScripts": {
-                    "level": "error",
-                    "options": {
-                        "requiredScripts": ["test", "build", "lint"]
-                    }
-                }
-            }
-        }
-    }
-}
-```
-
-For example, the following `package.json` triggers the rule when `["test", "build"]` are required:
-
-```json
-{
-    "scripts": {
-        "test": "vitest"
-    }
-}
-```
-
-```
-package.json:1:1 lint/nursery/useRequiredScripts ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  ✖ The required script "build" is missing from package.json.
-
-  > 1 │ {
-      │ ^
-    2 │     "scripts": {
-    3 │         "test": "vitest"
-
-  ℹ Add the missing script to your package.json.
-```
+Added the rule [`useRequiredScripts`](https://biomejs.dev/linter/rules/use-required-scripts/), which enforces presence of configurable entries in the `scripts` section of `package.json` files.

crates/biome_json_analyze/src/lint/nursery/use_required_scripts.rs

@@ -3,49 +3,46 @@ use biome_console::markup;
 use biome_json_syntax::JsonRoot;
 use biome_rowan::{AstNode, AstSeparatedList};
 use biome_rule_options::use_required_scripts::UseRequiredScriptsOptions;
-use rustc_hash::FxHashSet;
 
 declare_lint_rule! {
     /// Enforce the presence of required scripts in package.json.
     ///
     /// This rule ensures that specified scripts are defined in the `scripts` section of a `package.json` file.
     /// It's particularly useful in monorepo environments where consistency across workspaces is important.
     ///
-    /// ## Examples
+    /// ## Options
     ///
-    /// ### Invalid
+    /// ### `requiredScripts`
     ///
-    /// ```json
+    /// An array of script names that must be present in the `scripts` section of `package.json`.
+    ///
+    /// ```json,options
     /// {
-    ///     "scripts": {
-    ///         "test": "vitest"
+    ///     "options": {
+    ///         "requiredScripts": ["test", "build"]
     ///     }
     /// }
     /// ```
     ///
-    /// With options `{ "requiredScripts": ["test", "build"] }`, this is invalid because `build` is missing.
+    /// ## Examples
     ///
-    /// ### Valid
+    /// ### Invalid
     ///
-    /// ```json
+    /// ```json,expect_diagnostic,use_options
     /// {
     ///     "scripts": {
-    ///         "test": "vitest",
-    ///         "build": "tsc"
+    ///         "test": "vitest"
     ///     }
     /// }
     /// ```
     ///
-    /// With options `{ "requiredScripts": ["test", "build"] }`, this is valid because all required scripts are present.
-    ///
-    /// ## Options
-    ///
-    /// The rule accepts an array of script names that must be present:
+    /// ### Valid
     ///
-    /// ```json,options
+    /// ```json,use_options
     /// {
-    ///     "options": {
-    ///         "requiredScripts": ["test", "build", "lint"]
+    ///     "scripts": {
+    ///         "test": "vitest",
+    ///         "build": "tsc"
     ///     }
     /// }
     /// ```
@@ -86,18 +83,18 @@ impl Rule for UseRequiredScripts {
             .iter()
             .flatten()
             .find(|member| {
-                if let Ok(name) = member.name() {
-                    if let Ok(text) = name.inner_string_text() {
-                        return text.text() == "scripts";
-                    }
+                if let Ok(name) = member.name()
+                    && let Ok(text) = name.inner_string_text()
+                {
+                    return text.text() == "scripts";
                 }
                 false
             })?;
 
         let scripts_value = scripts_member.value().ok()?;
         let scripts_object = scripts_value.as_json_object_value()?;
 
-        let existing_scripts: FxHashSet<String> = scripts_object
+        let existing_scripts: Vec<String> = scripts_object
             .json_member_list()
             .iter()
             .flatten()
@@ -111,7 +108,7 @@ impl Rule for UseRequiredScripts {
         let missing_scripts: Vec<String> = options
             .required_scripts
             .iter()
-            .filter(|script| !existing_scripts.contains(*script))
+            .filter(|script| !existing_scripts.iter().any(|s| s == *script))
             .cloned()
             .collect();