fix(lsp): remove rename capability (#6422)

Co-authored-by: siketyan <[email protected]>

Author: ematipico

.changeset/wild-chefs-sit.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Removed the experimental rename feature from Biome LSP, which caused some issues inside existing editors such as Zed.

crates/biome_lsp/src/extension_settings.rs

@@ -59,18 +59,6 @@ impl ExtensionSettings {
         Ok(())
     }
 
-    pub(crate) fn rename_enabled(&self) -> bool {
-        let new_setting = self
-            .settings
-            .experimental
-            .as_ref()
-            .is_some_and(|experimental| experimental.rename.unwrap_or(false));
-
-        let old_setting = self.settings.rename.unwrap_or(false);
-
-        new_setting | old_setting
-    }
-
     pub(crate) fn requires_configuration(&self) -> bool {
         self.settings.require_configuration.unwrap_or_default()
     }

crates/biome_lsp/src/handlers.rs

@@ -1,4 +1,3 @@
 pub(crate) mod analysis;
 pub(crate) mod formatting;
-pub(crate) mod rename;
 pub(crate) mod text_document;

crates/biome_lsp/src/handlers/rename.rs

@@ -222,21 +222,6 @@ impl LSPServer {
             },
         );
 
-        let rename = {
-            let config = self.session.extension_settings.read().ok();
-            config.is_some_and(|x| x.rename_enabled())
-        };
-
-        capabilities.add_capability(
-            "biome_rename",
-            "textDocument/rename",
-            if rename {
-                CapabilityStatus::Enable(None)
-            } else {
-                CapabilityStatus::Disable
-            },
-        );
-
         self.session.register_capabilities(capabilities).await;
     }
 
@@ -483,25 +468,6 @@ impl LanguageServer for LSPServer {
 
         self.map_op_error(result).await
     }
-
-    async fn rename(&self, params: RenameParams) -> LspResult<Option<WorkspaceEdit>> {
-        biome_diagnostics::panic::catch_unwind(move || {
-            let rename_enabled = self
-                .session
-                .extension_settings
-                .read()
-                .ok()
-                .and_then(|config| config.settings.rename)
-                .unwrap_or(false);
-
-            if rename_enabled {
-                handlers::rename::rename(&self.session, params).map_err(into_lsp_error)
-            } else {
-                Ok(None)
-            }
-        })
-        .map_err(into_lsp_error)?
-    }
 }
 
 impl Drop for LSPServer {