feat(lint): implement useObjectSpread rule

Author: mdevils

.changeset/puny-lands-drop.md

@@ -0,0 +1,33 @@
+---
+"@biomejs/biome": minor
+---
+
+Added the new rule [`useObjectSpread`](https://biomejs.dev/linter/rules/use-object-spread), which prefers object spread syntax over `Object.assign()` when constructing new objects.
+
+**Example (Invalid): Using Object.assign with an empty object:**
+
+```js
+Object.assign({}, foo);
+Object.assign({}, { foo: 'bar' });
+```
+
+**Example (Invalid): Using Object.assign with object literal as first argument:**
+
+```js
+Object.assign({ foo: 'bar' }, baz);
+Object.assign({}, baz, { foo: 'bar' });
+```
+
+**Example (Valid): Using object spread syntax:**
+
+```js
+({ ...foo });
+({ ...baz, foo: 'bar' });
+```
+
+**Example (Valid): Modifying existing objects is allowed:**
+
+```js
+Object.assign(foo, { bar: baz });
+Object.assign(foo, bar, baz);
+```

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

@@ -202,6 +202,7 @@ define_categories! {
     "lint/nursery/useNamedOperation": "https://biomejs.dev/linter/rules/use-named-operation",
     "lint/nursery/useNamingConvention": "https://biomejs.dev/linter/rules/use-naming-convention",
     "lint/nursery/useNumericSeparators": "https://biomejs.dev/linter/rules/use-numeric-separators",
+    "lint/nursery/useObjectSpread": "https://biomejs.dev/linter/rules/use-object-spread",
     "lint/nursery/useParseIntRadix": "https://biomejs.dev/linter/rules/use-parse-int-radix",
     "lint/nursery/useSingleJsDocAsterisk": "https://biomejs.dev/linter/rules/use-single-js-doc-asterisk",
     "lint/nursery/useSortedClasses": "https://biomejs.dev/linter/rules/use-sorted-classes",

crates/biome_configuration/src/analyzer/linter/rules.rs

@@ -32,9 +32,10 @@ pub mod use_for_component;
 pub mod use_google_font_preconnect;
 pub mod use_iterable_callback_return;
 pub mod use_numeric_separators;
+pub mod use_object_spread;
 pub mod use_parse_int_radix;
 pub mod use_single_js_doc_asterisk;
 pub mod use_sorted_classes;
 pub mod use_symbol_description;
 pub mod use_unique_element_ids;
-declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_await_in_loop :: NoAwaitInLoop , self :: no_bitwise_operators :: NoBitwiseOperators , self :: no_constant_binary_expression :: NoConstantBinaryExpression , self :: no_destructured_props :: NoDestructuredProps , self :: no_floating_promises :: NoFloatingPromises , self :: no_global_dirname_filename :: NoGlobalDirnameFilename , self :: no_import_cycles :: NoImportCycles , self :: no_nested_component_definitions :: NoNestedComponentDefinitions , self :: no_noninteractive_element_interactions :: NoNoninteractiveElementInteractions , self :: no_process_global :: NoProcessGlobal , self :: no_restricted_elements :: NoRestrictedElements , self :: no_secrets :: NoSecrets , self :: no_shadow :: NoShadow , self :: no_ts_ignore :: NoTsIgnore , self :: no_unresolved_imports :: NoUnresolvedImports , self :: no_unwanted_polyfillio :: NoUnwantedPolyfillio , self :: no_useless_backref_in_regex :: NoUselessBackrefInRegex , self :: no_useless_escape_in_string :: NoUselessEscapeInString , self :: no_useless_undefined :: NoUselessUndefined , self :: use_adjacent_getter_setter :: UseAdjacentGetterSetter , self :: use_consistent_object_definition :: UseConsistentObjectDefinition , self :: use_consistent_response :: UseConsistentResponse , self :: use_exhaustive_switch_cases :: UseExhaustiveSwitchCases , self :: use_explicit_type :: UseExplicitType , self :: use_exports_last :: UseExportsLast , self :: use_for_component :: UseForComponent , self :: use_google_font_preconnect :: UseGoogleFontPreconnect , self :: use_iterable_callback_return :: UseIterableCallbackReturn , self :: use_numeric_separators :: UseNumericSeparators , self :: use_parse_int_radix :: UseParseIntRadix , self :: use_single_js_doc_asterisk :: UseSingleJsDocAsterisk , self :: use_sorted_classes :: UseSortedClasses , self :: use_symbol_description :: UseSymbolDescription , self :: use_unique_element_ids :: UseUniqueElementIds ,] } }
+declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_await_in_loop :: NoAwaitInLoop , self :: no_bitwise_operators :: NoBitwiseOperators , self :: no_constant_binary_expression :: NoConstantBinaryExpression , self :: no_destructured_props :: NoDestructuredProps , self :: no_floating_promises :: NoFloatingPromises , self :: no_global_dirname_filename :: NoGlobalDirnameFilename , self :: no_import_cycles :: NoImportCycles , self :: no_nested_component_definitions :: NoNestedComponentDefinitions , self :: no_noninteractive_element_interactions :: NoNoninteractiveElementInteractions , self :: no_process_global :: NoProcessGlobal , self :: no_restricted_elements :: NoRestrictedElements , self :: no_secrets :: NoSecrets , self :: no_shadow :: NoShadow , self :: no_ts_ignore :: NoTsIgnore , self :: no_unresolved_imports :: NoUnresolvedImports , self :: no_unwanted_polyfillio :: NoUnwantedPolyfillio , self :: no_useless_backref_in_regex :: NoUselessBackrefInRegex , self :: no_useless_escape_in_string :: NoUselessEscapeInString , self :: no_useless_undefined :: NoUselessUndefined , self :: use_adjacent_getter_setter :: UseAdjacentGetterSetter , self :: use_consistent_object_definition :: UseConsistentObjectDefinition , self :: use_consistent_response :: UseConsistentResponse , self :: use_exhaustive_switch_cases :: UseExhaustiveSwitchCases , self :: use_explicit_type :: UseExplicitType , self :: use_exports_last :: UseExportsLast , self :: use_for_component :: UseForComponent , self :: use_google_font_preconnect :: UseGoogleFontPreconnect , self :: use_iterable_callback_return :: UseIterableCallbackReturn , self :: use_numeric_separators :: UseNumericSeparators , self :: use_object_spread :: UseObjectSpread , self :: use_parse_int_radix :: UseParseIntRadix , self :: use_single_js_doc_asterisk :: UseSingleJsDocAsterisk , self :: use_sorted_classes :: UseSortedClasses , self :: use_symbol_description :: UseSymbolDescription , self :: use_unique_element_ids :: UseUniqueElementIds ,] } }

crates/biome_diagnostics_categories/src/categories.rs

@@ -0,0 +1,108 @@
+use crate::services::semantic::Semantic;
+use biome_analyze::{Rule, RuleDiagnostic, RuleSource, context::RuleContext, declare_lint_rule};
+use biome_console::markup;
+use biome_js_syntax::{JsCallExpression, global_identifier};
+use biome_rowan::{AstNode, AstSeparatedList, TextRange};
+
+declare_lint_rule! {
+    /// Prefer object spread over `Object.assign()` when constructing new objects.
+    ///
+    /// Object spread syntax is more concise, more readable, and performs better
+    /// than `Object.assign()` when creating a new object from existing objects.
+    /// It also has better TypeScript integration.
+    ///
+    /// ## Examples
+    ///
+    /// ### Invalid
+    ///
+    /// ```js,expect_diagnostic
+    /// Object.assign({}, foo);
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// Object.assign({}, { foo: 'bar' });
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// Object.assign({ foo: 'bar' }, baz);
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// Object.assign({}, baz, { foo: 'bar' });
+    /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```js
+    /// ({ ...foo });
+    /// ```
+    ///
+    /// ```js
+    /// ({ ...baz, foo: 'bar' });
+    /// ```
+    ///
+    /// Modifying an existing object is allowed:
+    /// ```js
+    /// Object.assign(foo, { bar: baz });
+    /// ```
+    ///
+    pub UseObjectSpread {
+        version: "2.0.0",
+        name: "useObjectSpread",
+        language: "js",
+        sources: &[
+            RuleSource::Eslint("prefer-object-spread"),
+        ],
+        recommended: false,
+    }
+}
+
+impl Rule for UseObjectSpread {
+    type Query = Semantic<JsCallExpression>;
+    type State = TextRange;
+    type Signals = Option<Self::State>;
+    type Options = ();
+
+    fn run(ctx: &RuleContext<Self>) -> Self::Signals {
+        let node = ctx.query();
+
+        let callee = node.callee().ok()?;
+        let member_expr = callee.as_js_static_member_expression()?;
+
+        let obj = member_expr.object().ok()?;
+        let (reference, obj_name) = global_identifier(&obj)?;
+        if obj_name.text() != "Object" || ctx.model().binding(&reference).is_some() {
+            return None;
+        }
+
+        let method = member_expr.member().ok()?;
+        if method.value_token().ok()?.text() != "assign" {
+            return None;
+        }
+
+        let args = node.arguments().ok()?;
+        let first_arg = args.args().first()?.ok()?;
+        let expression = first_arg.as_any_js_expression()?;
+
+        expression
+            .as_js_object_expression()
+            .and(Some(member_expr.range()))
+    }
+
+    fn diagnostic(_ctx: &RuleContext<Self>, state: &Self::State) -> Option<RuleDiagnostic> {
+        Some(
+            RuleDiagnostic::new(
+                rule_category!(),
+                state,
+                markup! {
+                    "Object spread should be used instead of "<Emphasis>"Object.assign"</Emphasis>
+                    " when constructing new objects."
+                },
+            )
+            .note(markup! {
+                "Replace "<Emphasis>"Object.assign({...}, <object>)"</Emphasis>
+                " with "<Emphasis>"{ ...<object> }"</Emphasis>"."
+            }),
+        )
+    }
+}

crates/biome_js_analyze/src/lint/nursery.rs

@@ -0,0 +1,7 @@
+Object.assign({}, foo);
+Object.assign({}, {foo: 'bar'});
+Object.assign({ foo: 'bar'}, baz);
+Object.assign({}, baz, { foo: 'bar' });
+Object.assign({}, { ...baz });
+Object.assign({});
+Object.assign({ foo: bar });