Skip to content

Commit 4709fb4

Browse files
committed
add note to docstring and changeset
1 parent 6a0e199 commit 4709fb4

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

.changeset/brave-scripts-dance.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@
33
---
44

55
Added the rule [`useRequiredScripts`](https://biomejs.dev/linter/rules/use-required-scripts/), which enforces presence of configurable entries in the `scripts` section of `package.json` files.
6+
7+
Fixed [`noDuplicateDependencies`](https://biomejs.dev/linter/rules/no-duplicate-dependencies/) incorrectly triggering on files like `_package.json`.

crates/biome_json_analyze/src/lint/nursery/use_required_scripts.rs

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ declare_lint_rule! {
2020
/// This rule ensures that specified scripts are defined in the `scripts` section of a `package.json` file.
2121
/// It's particularly useful in monorepo environments where consistency across workspaces is important.
2222
///
23+
/// Without required scripts configured, this rule doesn't do anything.
24+
///
2325
/// ## Examples
2426
///
2527
/// ### Invalid
@@ -87,15 +89,14 @@ impl Rule for UseRequiredScripts {
8789
let value = query.value().ok()?;
8890
let object_value = value.as_json_object_value()?;
8991

90-
let scripts_member =
91-
object_value
92-
.json_member_list()
93-
.iter()
94-
.flatten()
95-
.find_map(|member| {
96-
(member.name().ok()?.inner_string_text().ok()?.text() == "scripts")
97-
.then_some(member)
98-
});
92+
let scripts_member = object_value
93+
.json_member_list()
94+
.iter()
95+
.flatten()
96+
.find_map(|member| {
97+
(member.name().ok()?.inner_string_text().ok()?.text() == "scripts")
98+
.then_some(member)
99+
});
99100

100101
// If there's no scripts section, all required scripts are missing
101102
// Point to the root object in this case

0 commit comments

Comments
 (0)