refactor(lint): move useValidTypeof, noNamespaceImport, useNumericLiterals

Author: Conaclos

.changeset/rule-promotion.md

@@ -2,7 +2,16 @@
 "@biomejs/biome": major
 ---
 
-Promote nursery rules and update the recommended rule set.
+Change the group of some rules, promote nursery rules and update the recommended rule set.
+
+The following rules have been moved to a new group:
+
+- [complexity/noFlatMapIdentity](https://biomejs.dev/linter/rules/no-flat-map-identity)
+- [complexity/useNumericLiterals](https://biomejs.dev/linter/rules/use-numeric-literals)
+- [correctness/useValidTypeof](https://biomejs.dev/linter/rules/use-valid-typeof)
+- [performance/noNamespaceImport](https://biomejs.dev/linter/rules/no-namespace-import/)
+- [style/useArrayLiterals](https://biomejs.dev/linter/rules/use-array-literals)
+- [suspicious/noWith](https://biomejs.dev/linter/rules/no-with)
 
 New rules are incubated in the nursery group.
 Once stable, we promote them to a stable group.
@@ -60,12 +69,6 @@ The following JavaScript rules have been promoted:
 - [suspicious/useGuardForIn](https://biomejs.dev/linter/rules/use-guard-for-in)
 - [suspicious/useStrictMode](https://biomejs.dev/linter/rules/use-strict-mode)
 
-The following rules have been moved to another group:
-
-- [noFlatMapIdentity](https://biomejs.dev/linter/rules/no-flat-map-identity) is now in the `complexity` group
-- [noWith](https://biomejs.dev/linter/rules/no-with) is now in the `suspicious` group
-- [useArrayLiterals](https://biomejs.dev/linter/rules/use-array-literals) is now in the `style` group
-
 Moreover, the following JavaScript rules are now recommended:
 
 - [complexity/noUselessUndefinedInitialization](https://biomejs.dev/linter/rules/no-useless-undefined-initialization)

benchmark/biome.json

@@ -26,6 +26,7 @@
         "noVoid": "error",
         "useArrowFunction": "error",
         "useLiteralKeys": "error",
+        "useNumericLiterals": "error",
         "useRegexLiterals": "error"
       },
       "correctness": {
@@ -53,6 +54,7 @@
         "noUnusedVariables": "error",
         "useIsNan": "error",
         "useValidForDirection": "error",
+        "useValidTypeof": "error",
         "useYield": "error"
       },
       "security": {
@@ -67,7 +69,6 @@
         "useCollapsedElseIf": "error",
         "useDefaultParameterLast": "error",
         "useExponentiationOperator": "error",
-        "useNumericLiterals": "error",
         "useSingleVarDeclarator": "error",
         "useTemplate": "error"
       },
@@ -102,7 +103,6 @@
         "useAwait": "error",
         "useDefaultSwitchClauseLast": "error",
         "useGetterReturn": "error",
-        "useValidTypeof": "error",
         "noVar": "error"
       }
     }

benchmark/ts-biome.json

@@ -15,6 +15,7 @@
         "noVoid": "error",
         "noWith": "error",
         "useArrowFunction": "error",
+        "useNumericLiterals": "error",
         "useRegexLiterals": "error"
       },
       "correctness": {
@@ -68,7 +69,6 @@
         "useExponentiationOperator": "error",
         "useForOf": "error",
         "useLiteralEnumMembers": "error",
-        "useNumericLiterals": "error",
         "useShorthandFunctionType": "error",
         "useSingleVarDeclarator": "error",
         "useTemplate": "error"

biome.json

@@ -48,26 +48,16 @@
     "enabled": true,
     "rules": {
       "style": {
-        "noNonNullAssertion": "off",
-        "useNodejsImportProtocol": "error",
-        "useLiteralEnumMembers": "error",
-        "noArguments": "error",
         "noParameterAssign": "error",
-        "useShorthandFunctionType": "error",
-        "useExportType": "error",
         "useDefaultParameterLast": "error",
-        "noCommaOperator": "error",
         "useSingleVarDeclarator": "error",
         "useConst": "error",
         "noInferrableTypes": "error",
-        "useExponentiationOperator": "error",
         "noUselessElse": "error",
         "useSelfClosingElements": "error",
-        "useImportType": "error",
         "useNumberNamespace": "error",
         "useAsConstAssertion": "error",
         "noUnusedTemplateLiteral": "error",
-        "useNumericLiterals": "error",
         "useTemplate": "error",
         "useEnumInitializers": "error"
       },

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

@@ -13,7 +13,6 @@ expression: redactor(content)
         "noDebugger": "error",
         "noShadowRestrictedNames": "off",
         "noExplicitAny": "off",
-        "useValidTypeof": "error",
         "noAsyncPromiseExecutor": "off",
         "noEmptyInterface": "error",
         "noAssignInExpressions": "error",
@@ -53,7 +52,8 @@ expression: redactor(content)
         "noUnreachable": "error",
         "noUnsafeFinally": "error",
         "noSwitchDeclarations": "off",
-        "noSelfAssign": "off"
+        "noSelfAssign": "off",
+        "useValidTypeof": "error"
       }
     }
   }

crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_migrate_issue_5465.snap

@@ -62,7 +62,6 @@ biome.json:5:17 deserialize ━━━━━━━━━━━━━━━━━
   - noImplicitBoolean
   - noInferrableTypes
   - noNamespace
-  - noNamespaceImport
   - noNegationElse
   - noNestedTernary
   - noNonNullAssertion
@@ -106,7 +105,6 @@ biome.json:5:17 deserialize ━━━━━━━━━━━━━━━━━
   - useNodeAssertStrict
   - useNodejsImportProtocol
   - useNumberNamespace
-  - useNumericLiterals
   - useSelfClosingElements
   - useShorthandAssign
   - useShorthandFunctionType

crates/biome_cli/tests/snapshots/main_commands_lint/linter_shows_the_default_severity_of_rule_on.snap

@@ -91,6 +91,7 @@ Linter:
     complexity/useDateNow
     complexity/useFlatMap
     complexity/useLiteralKeys
+    complexity/useNumericLiterals
     complexity/useOptionalChain
     complexity/useRegexLiterals
     complexity/useSimpleNumberKeys

crates/biome_cli/tests/snapshots/main_commands_rage/with_linter_configuration.snap

@@ -101,6 +101,7 @@ biome.json:6:13 deserialize ━━━━━━━━━━━━━━━━━
   - useIsNan
   - useJsxKeyInIterable
   - useValidForDirection
+  - useValidTypeof
   - useYield
   
 
@@ -133,7 +134,6 @@ biome.json:9:13 deserialize ━━━━━━━━━━━━━━━━━
   - noImplicitBoolean
   - noInferrableTypes
   - noNamespace
-  - noNamespaceImport
   - noNegationElse
   - noNestedTernary
   - noNonNullAssertion
@@ -177,7 +177,6 @@ biome.json:9:13 deserialize ━━━━━━━━━━━━━━━━━
   - useNodeAssertStrict
   - useNodejsImportProtocol
   - useNumberNamespace
-  - useNumericLiterals
   - useSelfClosingElements
   - useShorthandAssign
   - useShorthandFunctionType