fix(cli): don't use temporary file in stdin (#6461)

Co-authored-by: arendjr <[email protected]>

Author: ematipico

.changeset/late-flies-glow.md

@@ -0,0 +1,7 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#6419](https://github.com/biomejs/biome/issues/6419), a regression where stdin mode would create a temporary new file instead of using the one provided by the user. This was an intended regression.
+
+Now Biome will use the file path passed via `--std-file-path`, and apply the configuration that matches it.

crates/biome_cli/src/execute/std_in.rs

@@ -2,7 +2,7 @@
 //!
 use crate::diagnostics::StdinDiagnostic;
 use crate::execute::Execution;
-use crate::{CliDiagnostic, CliSession, TEMPORARY_INTERNAL_FILE_NAME, TraversalMode};
+use crate::{CliDiagnostic, CliSession, TraversalMode};
 use biome_analyze::RuleCategoriesBuilder;
 use biome_console::{ConsoleExt, markup};
 use biome_diagnostics::Diagnostic;
@@ -15,7 +15,6 @@ use biome_service::workspace::{
     ChangeFileParams, CloseFileParams, DropPatternParams, FeaturesBuilder, FileContent,
     FixFileParams, FormatFileParams, OpenFileParams, SupportsFeatureParams,
 };
-use camino::Utf8PathBuf;
 use std::borrow::Cow;
 
 pub(crate) fn run<'a>(
@@ -30,12 +29,9 @@ pub(crate) fn run<'a>(
     let console = &mut *session.app.console;
     let mut version = 0;
 
-    let std_in_file = biome_path
-        .extension()
-        .map(|ext| {
-            BiomePath::new(Utf8PathBuf::from(TEMPORARY_INTERNAL_FILE_NAME).with_extension(ext))
-        })
-        .ok_or_else(|| CliDiagnostic::from(StdinDiagnostic::new_no_extension()))?;
+    if biome_path.extension().is_none() {
+        return Err(CliDiagnostic::from(StdinDiagnostic::new_no_extension()));
+    }
 
     if mode.is_format() {
         let file_features = workspace.file_features(SupportsFeatureParams {
@@ -58,14 +54,14 @@ pub(crate) fn run<'a>(
         if file_features.supports_format() {
             workspace.open_file(OpenFileParams {
                 project_key,
-                path: std_in_file.clone(),
+                path: biome_path.clone(),
                 content: FileContent::from_client(content),
                 document_file_source: None,
                 persist_node_cache: false,
             })?;
             let printed = workspace.format_file(FormatFileParams {
                 project_key,
-                path: std_in_file.clone(),
+                path: biome_path.clone(),
             })?;
 
             let code = printed.into_code();
@@ -80,7 +76,7 @@ pub(crate) fn run<'a>(
             });
             workspace.close_file(CloseFileParams {
                 project_key,
-                path: std_in_file.clone(),
+                path: biome_path.clone(),
             })?;
         } else {
             console.append(markup! {
@@ -96,7 +92,7 @@ pub(crate) fn run<'a>(
 
         workspace.open_file(OpenFileParams {
             project_key,
-            path: std_in_file.clone(),
+            path: biome_path.clone(),
             content: FileContent::from_client(content),
             document_file_source: None,
             persist_node_cache: false,
@@ -147,7 +143,7 @@ pub(crate) fn run<'a>(
                 let fix_file_result = workspace.fix_file(FixFileParams {
                     project_key,
                     fix_file_mode: *fix_file_mode,
-                    path: std_in_file.clone(),
+                    path: biome_path.clone(),
                     should_format: mode.is_check() && file_features.supports_format(),
                     only: only.clone(),
                     skip: skip.clone(),
@@ -167,7 +163,7 @@ pub(crate) fn run<'a>(
                     workspace.change_file(ChangeFileParams {
                         project_key,
                         content: output.clone(),
-                        path: std_in_file.clone(),
+                        path: biome_path.clone(),
                         version,
                     })?;
                     new_content = Cow::Owned(output);
@@ -178,7 +174,7 @@ pub(crate) fn run<'a>(
         if file_features.supports_format() && mode.is_check() {
             let printed = workspace.format_file(FormatFileParams {
                 project_key,
-                path: std_in_file.clone(),
+                path: biome_path.clone(),
             })?;
             let code = printed.into_code();
             let output = match biome_path.extension() {
@@ -212,7 +208,7 @@ pub(crate) fn run<'a>(
         }
         workspace.close_file(CloseFileParams {
             project_key,
-            path: std_in_file.clone(),
+            path: biome_path.clone(),
         })?;
     } else if let TraversalMode::Search { pattern, .. } = mode.traversal_mode() {
         // Make sure patterns are always cleaned up at the end of execution.

crates/biome_cli/src/lib.rs

@@ -43,10 +43,6 @@ pub(crate) const VERSION: &str = match option_env!("BIOME_VERSION") {
     None => env!("CARGO_PKG_VERSION"),
 };
 
-/// File name  that is temporarily used when running the workspace internally.
-/// When using this file, make sure to close it via [Workspace::close_file].
-pub const TEMPORARY_INTERNAL_FILE_NAME: &str = "__BIOME_INTERNAL_FILE__";
-
 /// JSON file that is temporarily to handle internal files via [Workspace].
 /// When using this file, make sure to close it via [Workspace::close_file].
 pub const TEMPORARY_INTERNAL_REPORTER_FILE: &str = "__BIOME_INTERNAL_FILE__.json";

crates/biome_cli/tests/commands/check.rs

@@ -1780,6 +1780,96 @@ fn check_stdin_write_successfully() {
     ));
 }
 
+#[test]
+fn check_stdin_applies_the_config_based_on_path() {
+    let mut fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    fs.insert(
+        "biome.json".into(),
+        r#"{
+  "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  },
+  "formatter": {
+    "indentStyle": "space"
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single",
+      "semicolons": "asNeeded",
+      "arrowParentheses": "always",
+      "trailingCommas": "es5"
+    }
+  },
+  "overrides": [
+    {
+      "includes": ["apps/test/**"],
+      "javascript": {
+        "formatter": {
+          "lineWidth": 100
+        }
+      }
+    }
+  ]
+}
+"#
+        .as_bytes(),
+    );
+
+    console.in_buffer.push(
+        r#"const _t = [
+  colors.l3BackgroundTertiary,
+  colors.l3BackgroundPositive,
+  colors.l3BackgroundTertiary,
+]
+"#
+        .to_string(),
+    );
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(
+            [
+                "check",
+                "--write",
+                "--stdin-file-path",
+                "apps/test/index.tsx",
+            ]
+            .as_slice(),
+        ),
+    );
+
+    assert!(result.is_ok(), "run_cli returned {result:?}");
+
+    let message = console
+        .out_buffer
+        .first()
+        .expect("Console should have written a message");
+
+    let content = markup_to_string(markup! {
+        {message.content}
+    });
+
+    assert_eq!(
+        content,
+        "const _t = [colors.l3BackgroundTertiary, colors.l3BackgroundPositive, colors.l3BackgroundTertiary]\n"
+    );
+
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "check_stdin_applies_the_config_based_on_path",
+        fs,
+        console,
+        result,
+    ));
+}
+
 #[test]
 fn check_stdin_write_unsafe_successfully() {
     let fs = MemoryFileSystem::default();

crates/biome_cli/tests/snapshots/main_commands_check/check_stdin_applies_the_config_based_on_path.snap

@@ -0,0 +1,56 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  },
+  "formatter": {
+    "indentStyle": "space"
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single",
+      "semicolons": "asNeeded",
+      "arrowParentheses": "always",
+      "trailingCommas": "es5"
+    }
+  },
+  "overrides": [
+    {
+      "includes": ["apps/test/**"],
+      "javascript": {
+        "formatter": {
+          "lineWidth": 100
+        }
+      }
+    }
+  ]
+}
+```
+
+# Input messages
+
+```block
+const _t = [
+  colors.l3BackgroundTertiary,
+  colors.l3BackgroundPositive,
+  colors.l3BackgroundTertiary,
+]
+
+```
+
+# Emitted Messages
+
+```block
+const _t = [colors.l3BackgroundTertiary, colors.l3BackgroundPositive, colors.l3BackgroundTertiary]
+
+```