feat(biome-js-analyze): adjusts members update assignments to be marked as valid updates and no errors triggered

Author: vladimir-ivanov

crates/biome_js_analyze/src/services/semantic_class.rs

@@ -57,9 +57,26 @@ impl Phase for SemanticClassServices {
     }
 }
 
-pub struct ClassMemberReferencesVisitor {}
+pub struct SyntaxClassMemberReferencesVisitor {}
 
-impl Visitor for ClassMemberReferencesVisitor {
+impl Visitor for SyntaxClassMemberReferencesVisitor {
+    type Language = JsLanguage;
+
+    fn visit(
+        &mut self,
+        _event: &WalkEvent<JsSyntaxNode>,
+        mut _ctx: VisitorContext<'_, '_, JsLanguage>,
+    ) {
+    }
+
+    fn finish(self: Box<Self>, ctx: VisitorFinishContext<JsLanguage>) {
+        ctx.services.insert_service(SemanticClassModel {});
+    }
+}
+
+pub struct SemanticClassMemberReferencesVisitor {}
+
+impl Visitor for SemanticClassMemberReferencesVisitor {
     type Language = JsLanguage;
 
     fn visit(
@@ -73,10 +90,6 @@ impl Visitor for ClassMemberReferencesVisitor {
             ctx.match_query(node.clone());
         }
     }
-
-    fn finish(self: Box<Self>, ctx: VisitorFinishContext<JsLanguage>) {
-        ctx.services.insert_service(SemanticClassModel {});
-    }
 }
 
 #[derive(Clone)]
@@ -99,8 +112,8 @@ where
     type Services = SemanticClassServices;
 
     fn build_visitor(analyzer: &mut impl AddVisitor<JsLanguage>, _root: &AnyJsRoot) {
-        analyzer.add_visitor(Phases::Syntax, || ClassMemberReferencesVisitor {});
-        analyzer.add_visitor(Phases::Semantic, || ClassMemberReferencesVisitor {});
+        analyzer.add_visitor(Phases::Syntax, || SyntaxClassMemberReferencesVisitor {});
+        analyzer.add_visitor(Phases::Semantic, || SemanticClassMemberReferencesVisitor {});
     }
 
     fn key() -> QueryKey<Self::Language> {